From: Aditya Gupta <adityag@linux.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, irogers@google.com,
namhyung@kernel.org
Cc: linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
disgoel@linux.vnet.ibm.com
Subject: [PATCH v2 3/4] perf tests task_analyzer: use perf check for libtraceevent support
Date: Thu, 21 Sep 2023 00:58:46 +0530 [thread overview]
Message-ID: <20230920192847.975897-4-adityag@linux.ibm.com> (raw)
In-Reply-To: <20230920192847.975897-1-adityag@linux.ibm.com>
Currently we use output of 'perf version --build-options', to check whether
perf was built with libtraceevent support.
Instead, use 'perf check --feature libtraceevent' to check for
libtraceevent support.
Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
---
tools/perf/tests/shell/test_task_analyzer.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
index 92d15154ba79..f4db68edb2e3 100755
--- a/tools/perf/tests/shell/test_task_analyzer.sh
+++ b/tools/perf/tests/shell/test_task_analyzer.sh
@@ -52,8 +52,8 @@ find_str_or_fail() {
# check if perf is compiled with libtraceevent support
skip_no_probe_record_support() {
- perf version --build-options | grep -q " OFF .* HAVE_LIBTRACEEVENT" && return 2
- return 0
+ perf check -q --feature libtraceevent && return 0
+ return 2
}
prepare_perf_data() {
--
2.41.0
next prev parent reply other threads:[~2023-09-20 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 19:28 [PATCH v2 0/4] Introduce perf check subcommand Aditya Gupta
2023-09-20 19:28 ` [PATCH v2 1/4] perf check: introduce " Aditya Gupta
2023-09-27 0:29 ` Namhyung Kim
2023-09-27 10:03 ` Aditya Gupta
2023-09-28 4:10 ` Namhyung Kim
2023-09-20 19:28 ` [PATCH v2 2/4] perf version: update --build-options to use 'supported_features' array Aditya Gupta
2023-09-20 19:28 ` Aditya Gupta [this message]
2023-09-20 19:28 ` [PATCH v2 4/4] tools/perf/tests: Update probe_vfs_getname.sh script to use perf check --feature Aditya Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920192847.975897-4-adityag@linux.ibm.com \
--to=adityag@linux.ibm.com \
--cc=acme@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).