* [PATCH] perf tools: Do not ignore the default vmlinux.h
[not found] <202310110451.rvdUZJEY-lkp@intel.com>
@ 2023-10-10 23:42 ` Namhyung Kim
2023-10-11 1:35 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2023-10-10 23:42 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ian Rogers, Adrian Hunter, Peter Zijlstra, Ingo Molnar, LKML,
linux-perf-users, kernel test robot, oe-kbuild-all
The recent change made it possible to generate vmlinux.h from BTF and
to ignore the file. But we also have a minimal vmlinux.h that will be
used by default. It should not be ignored by GIT.
Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310110451.rvdUZJEY-lkp@intel.com/
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/bpf_skel/vmlinux/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 tools/perf/util/bpf_skel/vmlinux/.gitignore
diff --git a/tools/perf/util/bpf_skel/vmlinux/.gitignore b/tools/perf/util/bpf_skel/vmlinux/.gitignore
new file mode 100644
index 000000000000..49502c04183a
--- /dev/null
+++ b/tools/perf/util/bpf_skel/vmlinux/.gitignore
@@ -0,0 +1 @@
+!vmlinux.h
--
2.42.0.609.gbb76f46606-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tools: Do not ignore the default vmlinux.h
2023-10-10 23:42 ` [PATCH] perf tools: Do not ignore the default vmlinux.h Namhyung Kim
@ 2023-10-11 1:35 ` Ian Rogers
2023-10-20 5:40 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2023-10-11 1:35 UTC (permalink / raw)
To: Namhyung Kim
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Adrian Hunter,
Peter Zijlstra, Ingo Molnar, LKML, linux-perf-users,
kernel test robot, oe-kbuild-all
On Tue, Oct 10, 2023 at 4:42 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The recent change made it possible to generate vmlinux.h from BTF and
> to ignore the file. But we also have a minimal vmlinux.h that will be
> used by default. It should not be ignored by GIT.
>
> Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310110451.rvdUZJEY-lkp@intel.com/
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks!
Ian
> ---
> tools/perf/util/bpf_skel/vmlinux/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/perf/util/bpf_skel/vmlinux/.gitignore
>
> diff --git a/tools/perf/util/bpf_skel/vmlinux/.gitignore b/tools/perf/util/bpf_skel/vmlinux/.gitignore
> new file mode 100644
> index 000000000000..49502c04183a
> --- /dev/null
> +++ b/tools/perf/util/bpf_skel/vmlinux/.gitignore
> @@ -0,0 +1 @@
> +!vmlinux.h
> --
> 2.42.0.609.gbb76f46606-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tools: Do not ignore the default vmlinux.h
2023-10-11 1:35 ` Ian Rogers
@ 2023-10-20 5:40 ` Namhyung Kim
0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2023-10-20 5:40 UTC (permalink / raw)
To: Ian Rogers
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Adrian Hunter,
Peter Zijlstra, Ingo Molnar, LKML, linux-perf-users,
kernel test robot, oe-kbuild-all
On Tue, Oct 10, 2023 at 6:36 PM Ian Rogers <irogers@google.com> wrote:
>
> On Tue, Oct 10, 2023 at 4:42 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > The recent change made it possible to generate vmlinux.h from BTF and
> > to ignore the file. But we also have a minimal vmlinux.h that will be
> > used by default. It should not be ignored by GIT.
> >
> > Fixes: b7a2d774c9c5 ("perf build: Add ability to build with a generated vmlinux.h")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202310110451.rvdUZJEY-lkp@intel.com/
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Applied to perf-tools-next, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-20 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202310110451.rvdUZJEY-lkp@intel.com>
2023-10-10 23:42 ` [PATCH] perf tools: Do not ignore the default vmlinux.h Namhyung Kim
2023-10-11 1:35 ` Ian Rogers
2023-10-20 5:40 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).