From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Mike Leach" <mike.leach@linaro.org>,
"James Clark" <james.clark@arm.com>,
"Leo Yan" <leo.yan@linaro.org>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Sean Christopherson" <seanjc@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kajol Jain" <kjain@linux.ibm.com>,
"Athira Rajeev" <atrajeev@linux.vnet.ibm.com>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Atish Patra" <atishp@rivosinc.com>,
"Steinar H. Gunderson" <sesse@google.com>,
"Yang Jihong" <yangjihong1@huawei.com>,
"Yang Li" <yang.lee@linux.alibaba.com>,
"Changbin Du" <changbin.du@huawei.com>,
"Sandipan Das" <sandipan.das@amd.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Paran Lee" <p4ranlee@gmail.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Yanteng Si" <siyanteng@loongson.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
bpf@vger.kernel.org
Subject: [PATCH v1 00/14] Clean up libperf cpumap's empty function
Date: Tue, 28 Nov 2023 22:01:57 -0800 [thread overview]
Message-ID: <20231129060211.1890454-1-irogers@google.com> (raw)
Rename and clean up the use of libperf CPU map functions particularly
focussing on perf_cpu_map__empty that may return true for maps
containing CPUs but also with an "any CPU"/dummy value.
perf_cpu_map__nr is also troubling in that iterating an empty CPU map
will yield the "any CPU"/dummy value. Reduce the appearance of some
calls to this by using the perf_cpu_map__for_each_cpu macro.
Ian Rogers (14):
libperf cpumap: Rename perf_cpu_map__dummy_new
libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new
libperf cpumap: Rename perf_cpu_map__empty
libperf cpumap: Replace usage of perf_cpu_map__new(NULL)
libperf cpumap: Add for_each_cpu that skips the "any CPU" case
libperf cpumap: Add any, empty and min helpers
perf arm-spe/cs-etm: Directly iterate CPU maps
perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
use
perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
perf top: Avoid repeated function calls
perf arm64 header: Remove unnecessary CPU map get and put
perf stat: Remove duplicate cpus_map_matched function
perf cpumap: Use perf_cpu_map__for_each_cpu when possible
libperf cpumap: Document perf_cpu_map__nr's behavior
.../perf/Documentation/examples/sampling.c | 2 +-
.../perf/Documentation/libperf-sampling.txt | 2 +-
tools/lib/perf/Documentation/libperf.txt | 4 +-
tools/lib/perf/cpumap.c | 92 +++++++++++++------
tools/lib/perf/evlist.c | 6 +-
tools/lib/perf/evsel.c | 2 +-
tools/lib/perf/include/perf/cpumap.h | 56 ++++++++++-
tools/lib/perf/libperf.map | 10 +-
tools/lib/perf/tests/test-cpumap.c | 4 +-
tools/lib/perf/tests/test-evlist.c | 6 +-
tools/lib/perf/tests/test-evsel.c | 2 +-
tools/perf/arch/arm/util/cs-etm.c | 83 +++++++----------
tools/perf/arch/arm64/util/arm-spe.c | 4 +-
tools/perf/arch/arm64/util/header.c | 15 +--
tools/perf/arch/x86/util/intel-bts.c | 4 +-
tools/perf/arch/x86/util/intel-pt.c | 10 +-
tools/perf/bench/epoll-ctl.c | 2 +-
tools/perf/bench/epoll-wait.c | 2 +-
tools/perf/bench/futex-hash.c | 2 +-
tools/perf/bench/futex-lock-pi.c | 2 +-
tools/perf/bench/futex-requeue.c | 2 +-
tools/perf/bench/futex-wake-parallel.c | 2 +-
tools/perf/bench/futex-wake.c | 2 +-
tools/perf/builtin-c2c.c | 6 +-
tools/perf/builtin-ftrace.c | 2 +-
tools/perf/builtin-record.c | 4 +-
tools/perf/builtin-stat.c | 31 +------
tools/perf/tests/bitmap.c | 13 +--
tools/perf/tests/code-reading.c | 2 +-
tools/perf/tests/cpumap.c | 2 +-
tools/perf/tests/keep-tracking.c | 2 +-
tools/perf/tests/mmap-basic.c | 2 +-
tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
tools/perf/tests/perf-time-to-tsc.c | 2 +-
tools/perf/tests/sw-clock.c | 2 +-
tools/perf/tests/switch-tracking.c | 2 +-
tools/perf/tests/task-exit.c | 2 +-
tools/perf/tests/topology.c | 48 +++++-----
tools/perf/util/auxtrace.c | 4 +-
tools/perf/util/bpf_counter.c | 2 +-
tools/perf/util/bpf_kwork.c | 16 ++--
tools/perf/util/bpf_kwork_top.c | 12 +--
tools/perf/util/cpumap.c | 14 ++-
tools/perf/util/cputopo.c | 2 +-
tools/perf/util/evlist.c | 4 +-
tools/perf/util/evsel.c | 2 +-
tools/perf/util/perf_api_probe.c | 4 +-
tools/perf/util/record.c | 4 +-
.../scripting-engines/trace-event-python.c | 12 ++-
tools/perf/util/session.c | 5 +-
tools/perf/util/stat.c | 2 +-
tools/perf/util/svghelper.c | 20 ++--
tools/perf/util/top.c | 9 +-
53 files changed, 296 insertions(+), 254 deletions(-)
--
2.43.0.rc1.413.gea7ed67945-goog
next reply other threads:[~2023-11-29 6:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 6:01 Ian Rogers [this message]
2023-11-29 6:01 ` [PATCH v1 01/14] libperf cpumap: Rename perf_cpu_map__dummy_new Ian Rogers
2023-12-12 11:20 ` James Clark
2023-11-29 6:01 ` [PATCH v1 02/14] libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new Ian Rogers
2023-12-12 11:32 ` James Clark
2023-12-12 17:39 ` Arnaldo Carvalho de Melo
2023-12-12 17:52 ` Ian Rogers
2023-11-29 6:02 ` [PATCH v1 03/14] libperf cpumap: Rename perf_cpu_map__empty Ian Rogers
2023-12-12 11:38 ` James Clark
2023-11-29 6:02 ` [PATCH v1 04/14] libperf cpumap: Replace usage of perf_cpu_map__new(NULL) Ian Rogers
2023-12-12 11:44 ` James Clark
2023-11-29 6:02 ` [PATCH v1 05/14] libperf cpumap: Add for_each_cpu that skips the "any CPU" case Ian Rogers
2023-12-12 13:54 ` James Clark
2023-11-29 6:02 ` [PATCH v1 06/14] libperf cpumap: Add any, empty and min helpers Ian Rogers
2023-12-12 14:00 ` James Clark
2023-12-12 14:51 ` James Clark
2023-12-12 20:02 ` Ian Rogers
2023-12-12 15:06 ` James Clark
2023-12-12 20:27 ` Ian Rogers
2023-12-13 13:48 ` James Clark
2023-11-29 6:02 ` [PATCH v1 07/14] perf arm-spe/cs-etm: Directly iterate CPU maps Ian Rogers
2023-12-12 14:17 ` James Clark
2023-12-12 14:36 ` James Clark
2024-02-01 2:12 ` Ian Rogers
2024-02-01 11:06 ` James Clark
2023-11-29 6:02 ` [PATCH v1 08/14] perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty use Ian Rogers
2023-11-29 6:02 ` [PATCH v1 09/14] perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty Ian Rogers
2023-12-12 15:10 ` James Clark
2023-11-29 6:02 ` [PATCH v1 10/14] perf top: Avoid repeated function calls Ian Rogers
2023-12-12 15:11 ` James Clark
2023-12-18 20:34 ` Arnaldo Carvalho de Melo
2023-11-29 6:02 ` [PATCH v1 11/14] perf arm64 header: Remove unnecessary CPU map get and put Ian Rogers
2023-12-12 15:13 ` James Clark
2023-11-29 6:02 ` [PATCH v1 12/14] perf stat: Remove duplicate cpus_map_matched function Ian Rogers
2023-12-12 11:28 ` James Clark
2023-11-29 6:02 ` [PATCH v1 13/14] perf cpumap: Use perf_cpu_map__for_each_cpu when possible Ian Rogers
2023-12-12 11:25 ` James Clark
2023-11-29 6:02 ` [PATCH v1 14/14] libperf cpumap: Document perf_cpu_map__nr's behavior Ian Rogers
2023-12-12 15:20 ` James Clark
2023-12-18 20:36 ` Arnaldo Carvalho de Melo
2023-12-11 19:31 ` [PATCH v1 00/14] Clean up libperf cpumap's empty function Ian Rogers
2023-12-12 17:59 ` Arnaldo Carvalho de Melo
2023-12-13 12:48 ` Adrian Hunter
2023-12-14 13:49 ` Arnaldo Carvalho de Melo
2023-12-13 23:29 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129060211.1890454-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ajones@ventanamicro.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexghiti@rivosinc.com \
--cc=andrealmeid@igalia.com \
--cc=atishp@rivosinc.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=changbin.du@huawei.com \
--cc=chenhuacai@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=p4ranlee@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=sesse@google.com \
--cc=siyanteng@loongson.cn \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yang.lee@linux.alibaba.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).