From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
Quentin Monnet <quentin@isovalent.com>,
Fangrui Song <maskray@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Yanteng Si <siyanteng@loongson.cn>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Artem Savkov <asavkov@redhat.com>,
James Clark <james.clark@arm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v1 0/6] Add io_dir to avoid memory overhead from opendir
Date: Wed, 6 Dec 2023 21:04:27 -0800 [thread overview]
Message-ID: <20231207050433.1426834-1-irogers@google.com> (raw)
glibc's opendir allocates a minimum of 32kb, when called recursively
for a directory tree the memory consumption can add up - nearly 300kb
during perf start-up when processing modules. Add a stack allocated
variant of readdir sized a little more than 1kb
This was previously part of the memory saving change set:
https://lore.kernel.org/lkml/20231127220902.1315692-1-irogers@google.com/
It is separated here and a feature check and syscall workaround for
missing getdents64 added.
Ian Rogers (6):
tools build: Add a feature test for getdents64
tools lib api: Add io_dir an allocation free readdir alternative
perf maps: Switch modules tree walk to io_dir__readdir
perf pmu: Switch to io_dir__readdir
perf header: Switch mem topology to io_dir__readdir
perf events: Remove scandir in thread synthesis
tools/build/Makefile.feature | 1 +
tools/build/feature/Makefile | 4 ++
tools/build/feature/test-all.c | 5 ++
tools/build/feature/test-getdents64.c | 12 ++++
tools/lib/api/Makefile | 2 +-
tools/lib/api/io_dir.h | 84 +++++++++++++++++++++++++++
tools/perf/Makefile.config | 4 ++
tools/perf/util/header.c | 31 +++++-----
tools/perf/util/machine.c | 19 +++---
tools/perf/util/pmu.c | 48 ++++++---------
tools/perf/util/pmus.c | 30 ++++------
tools/perf/util/synthetic-events.c | 22 +++----
12 files changed, 177 insertions(+), 85 deletions(-)
create mode 100644 tools/build/feature/test-getdents64.c
create mode 100644 tools/lib/api/io_dir.h
--
2.43.0.rc2.451.g8631bc7472-goog
next reply other threads:[~2023-12-07 5:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:04 Ian Rogers [this message]
2023-12-07 5:04 ` [PATCH v1 1/6] tools build: Add a feature test for getdents64 Ian Rogers
2023-12-07 5:04 ` [PATCH v1 2/6] tools lib api: Add io_dir an allocation free readdir alternative Ian Rogers
2023-12-11 23:24 ` Namhyung Kim
2023-12-11 23:54 ` Ian Rogers
2023-12-13 1:33 ` Namhyung Kim
2023-12-07 5:04 ` [PATCH v1 3/6] perf maps: Switch modules tree walk to io_dir__readdir Ian Rogers
2023-12-07 5:04 ` [PATCH v1 4/6] perf pmu: Switch " Ian Rogers
2023-12-07 5:04 ` [PATCH v1 5/6] perf header: Switch mem topology " Ian Rogers
2023-12-07 5:04 ` [PATCH v1 6/6] perf events: Remove scandir in thread synthesis Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207050433.1426834-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asavkov@redhat.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=ravi.bangoria@amd.com \
--cc=siyanteng@loongson.cn \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).