From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
Quentin Monnet <quentin@isovalent.com>,
Fangrui Song <maskray@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Yanteng Si <siyanteng@loongson.cn>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Artem Savkov <asavkov@redhat.com>,
James Clark <james.clark@arm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v1 1/6] tools build: Add a feature test for getdents64
Date: Wed, 6 Dec 2023 21:04:28 -0800 [thread overview]
Message-ID: <20231207050433.1426834-2-irogers@google.com> (raw)
In-Reply-To: <20231207050433.1426834-1-irogers@google.com>
getdents64 may be missing from certain libcs, add a feature test to
determine when such a libc is being used.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/build/Makefile.feature | 1 +
tools/build/feature/Makefile | 4 ++++
tools/build/feature/test-all.c | 5 +++++
tools/build/feature/test-getdents64.c | 12 ++++++++++++
4 files changed, 22 insertions(+)
create mode 100644 tools/build/feature/test-getdents64.c
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 64df118376df..f051d4d8c71c 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -58,6 +58,7 @@ FEATURE_TESTS_BASIC := \
pthread-attr-setaffinity-np \
pthread-barrier \
reallocarray \
+ getdents64 \
stackprotector-all \
timerfd \
libdw-dwarf-unwind \
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 37722e509eb9..5efe89c3b0a6 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -21,6 +21,7 @@ FILES= \
test-disassembler-four-args.bin \
test-disassembler-init-styled.bin \
test-reallocarray.bin \
+ test-getdents64.bin \
test-libbfd-liberty.bin \
test-libbfd-liberty-z.bin \
test-cplus-demangle.bin \
@@ -262,6 +263,9 @@ $(OUTPUT)test-disassembler-init-styled.bin:
$(OUTPUT)test-reallocarray.bin:
$(BUILD)
+$(OUTPUT)test-getdents64.bin:
+ $(BUILD)
+
$(OUTPUT)test-libbfd-liberty.bin:
$(CC) $(CFLAGS) -Wall -Werror -o $@ test-libbfd.c -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty
diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
index 6f4bf386a3b5..c65096f75032 100644
--- a/tools/build/feature/test-all.c
+++ b/tools/build/feature/test-all.c
@@ -166,6 +166,10 @@
# include "test-reallocarray.c"
#undef main
+#define main main_test_getdents64
+# include "test-getdents64.c"
+#undef main
+
#define main main_test_disassembler_four_args
# include "test-disassembler-four-args.c"
#undef main
@@ -216,6 +220,7 @@ int main(int argc, char *argv[])
main_test_setns();
main_test_libaio();
main_test_reallocarray();
+ main_test_getdents64();
main_test_disassembler_four_args();
main_test_libzstd();
diff --git a/tools/build/feature/test-getdents64.c b/tools/build/feature/test-getdents64.c
new file mode 100644
index 000000000000..f7c9df1e2f05
--- /dev/null
+++ b/tools/build/feature/test-getdents64.c
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <stddef.h>
+#define _GNU_SOURCE
+#include <dirent.h>
+
+int main(void)
+{
+ char buf[128];
+ return (int)getdents64(0, buf, sizeof(buf));
+}
+
+#undef _GNU_SOURCE
--
2.43.0.rc2.451.g8631bc7472-goog
next prev parent reply other threads:[~2023-12-07 5:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:04 [PATCH v1 0/6] Add io_dir to avoid memory overhead from opendir Ian Rogers
2023-12-07 5:04 ` Ian Rogers [this message]
2023-12-07 5:04 ` [PATCH v1 2/6] tools lib api: Add io_dir an allocation free readdir alternative Ian Rogers
2023-12-11 23:24 ` Namhyung Kim
2023-12-11 23:54 ` Ian Rogers
2023-12-13 1:33 ` Namhyung Kim
2023-12-07 5:04 ` [PATCH v1 3/6] perf maps: Switch modules tree walk to io_dir__readdir Ian Rogers
2023-12-07 5:04 ` [PATCH v1 4/6] perf pmu: Switch " Ian Rogers
2023-12-07 5:04 ` [PATCH v1 5/6] perf header: Switch mem topology " Ian Rogers
2023-12-07 5:04 ` [PATCH v1 6/6] perf events: Remove scandir in thread synthesis Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207050433.1426834-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asavkov@redhat.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=ravi.bangoria@amd.com \
--cc=siyanteng@loongson.cn \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).