From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Yang Jihong <yangjihong1@huawei.com>
Subject: [RFC PATCH v3 11/18] perf stat: Add function to handle special events in hardware-grouping
Date: Tue, 12 Dec 2023 15:02:17 -0800 [thread overview]
Message-ID: <20231212230224.1473300-13-weilin.wang@intel.com> (raw)
In-Reply-To: <20231212230224.1473300-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
There are some special events like topdown events and TSC that are not
decribed in pmu-event JSON files. Add support to handle this type of
events. This should be considered as a temporary solution because including
these events in JSON files would be a better solution.
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
tools/perf/util/metricgroup.c | 25 +++++++++++++++++++++++--
tools/perf/util/metricgroup.h | 15 +++++++++++++++
2 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 5d9ed22963be..03383f820e06 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -2023,6 +2023,15 @@ static int create_grouping(struct list_head *pmu_info_list,
return ret;
};
+static bool is_special_event(const char *id)
+{
+ for (int i = 0; i < SPECIAL_EVENT_MAX; i++) {
+ if (!strncmp(id, special_event_names[i], strlen(special_event_names[i])))
+ return true;
+ }
+ return false;
+}
+
/**
* hw_aware_build_grouping - Build event groupings by reading counter
* requirement of the events and counter available on the system from
@@ -2047,7 +2056,17 @@ static int hw_aware_build_grouping(struct expr_parse_ctx *ctx __maybe_unused,
hashmap__for_each_entry(ctx->ids, cur, bkt) {
const char *id = cur->pkey;
- pr_debug("found event %s\n", id);
+ if (is_special_event(id)) {
+ struct metricgroup__event_info *event;
+
+ event = event_info__new(id, "default_core", "0",
+ /*free_counter=*/true);
+ if (!event)
+ goto err_out;
+
+ list_add(&event->nd, &event_info_list);
+ continue;
+ }
ret = get_metricgroup_events(id, etable, &event_info_list);
if (ret)
goto err_out;
@@ -2519,8 +2538,10 @@ int metricgroup__parse_groups(struct evlist *perf_evlist,
ret = hw_aware_parse_groups(perf_evlist, pmu, str,
metric_no_threshold, user_requested_cpu_list, system_wide,
/*fake_pmu=*/NULL, metric_events, table);
- if (!ret)
+ if (!ret) {
+ pr_info("Hardware aware grouping completed\n");
return 0;
+ }
}
return parse_groups(perf_evlist, pmu, str, metric_no_group, metric_no_merge,
diff --git a/tools/perf/util/metricgroup.h b/tools/perf/util/metricgroup.h
index 51596e4b4341..37fdf8c5ba77 100644
--- a/tools/perf/util/metricgroup.h
+++ b/tools/perf/util/metricgroup.h
@@ -79,6 +79,21 @@ struct metric_expr {
#define TRANSFER_FIRST_BYTE(pos) (7 - pos)
#define TRANSFER_SEC_BYTE(pos) (23 - pos)
+/* Special events that are not described in pmu-event JSON files.
+ * topdown-* and TSC use dedicated registers, set as free
+ * counter for grouping purpose
+ */
+enum special_events {
+ TOPDOWN = 0,
+ TSC = 1,
+ SPECIAL_EVENT_MAX,
+};
+
+static const char *const special_event_names[SPECIAL_EVENT_MAX] = {
+ "topdown-",
+ "TSC",
+};
+
/**
* An event used in a metric. This info is for metric grouping.
*/
--
2.39.3
next prev parent reply other threads:[~2023-12-12 23:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 23:02 [RFC PATCH v3 00/18] Perf stat metric grouping with hardware information weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 01/18] perf stat: Add new field in stat_config to enable hardware aware grouping weilin.wang
2023-12-12 23:26 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 02/18] perf stat: Add basic functions for the " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 02/18] perf stat: Add basic functions for the hardware-grouping stat cmd option weilin.wang
2023-12-12 23:29 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 03/18] perf pmu-events: Add functions in jevent.py to parse counter and event info for hardware aware grouping weilin.wang
2024-01-24 0:06 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 04/18] perf pmu-events: Add counter info into JSON files for SapphireRapids weilin.wang
2024-01-24 4:53 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 05/18] perf pmu-events: Add event counter data for Cascadelakex weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 06/18] perf pmu-events: Add event counter data for Icelakex weilin.wang
2024-01-25 4:54 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 07/18] perf stat: Add functions to set counter bitmaps for hardware-grouping method weilin.wang
2024-01-24 5:17 ` Ian Rogers
2024-01-24 16:59 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 08/18] perf stat: Add functions to get counter info weilin.wang
2024-01-24 15:57 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 09/18] perf stat: Add functions to create new group and assign events into groups for hardware-grouping method weilin.wang
2024-01-24 16:52 ` Ian Rogers
2024-01-24 17:06 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 10/18] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2024-01-24 18:36 ` Ian Rogers
2023-12-12 23:02 ` weilin.wang [this message]
2024-01-24 18:58 ` [RFC PATCH v3 11/18] perf stat: Add function to handle special events " Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 12/18] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 13/18] perf stat: Handle taken alone in hardware-grouping weilin.wang
2024-01-25 5:02 ` Ian Rogers
2024-01-26 18:14 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 14/18] perf stat: Handle NMI " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 15/18] perf stat: Code refactoring " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 16/18] perf stat: Add tool events support " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 17/18] perf pmu-events: Add event counter data for Tigerlake weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 18/18] perf stat: Add hardware-grouping cmd option to perf stat weilin.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212230224.1473300-13-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).