From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Yang Jihong <yangjihong1@huawei.com>
Subject: [RFC PATCH v3 18/18] perf stat: Add hardware-grouping cmd option to perf stat
Date: Tue, 12 Dec 2023 15:02:24 -0800 [thread overview]
Message-ID: <20231212230224.1473300-20-weilin.wang@intel.com> (raw)
In-Reply-To: <20231212230224.1473300-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
Add a cmd option to allow user to choose this new metric grouping method.
$ perf stat -M TopdownL1 -a --hardware-grouping
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
tools/perf/builtin-stat.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index a7a8018c3511..2f9fe54248a3 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1256,6 +1256,8 @@ static struct option stat_options[] = {
"don't try to share events between metrics in a group"),
OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
"don't try to share events between metrics in a group "),
+ OPT_BOOLEAN(0, "hardware-grouping", &stat_config.hardware_aware_grouping,
+ "Use hardware aware metric grouping method"),
OPT_BOOLEAN(0, "topdown", &topdown_run,
"measure top-down statistics"),
OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
@@ -2506,9 +2508,6 @@ int cmd_stat(int argc, const char **argv)
(const char **) stat_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
- /* Set hardware_aware_grouping to false on default before completely enable it.*/
- stat_config.hardware_aware_grouping = false;
-
if (stat_config.csv_sep) {
stat_config.csv_output = true;
if (!strcmp(stat_config.csv_sep, "\\t"))
--
2.39.3
prev parent reply other threads:[~2023-12-12 23:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 23:02 [RFC PATCH v3 00/18] Perf stat metric grouping with hardware information weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 01/18] perf stat: Add new field in stat_config to enable hardware aware grouping weilin.wang
2023-12-12 23:26 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 02/18] perf stat: Add basic functions for the " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 02/18] perf stat: Add basic functions for the hardware-grouping stat cmd option weilin.wang
2023-12-12 23:29 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 03/18] perf pmu-events: Add functions in jevent.py to parse counter and event info for hardware aware grouping weilin.wang
2024-01-24 0:06 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 04/18] perf pmu-events: Add counter info into JSON files for SapphireRapids weilin.wang
2024-01-24 4:53 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 05/18] perf pmu-events: Add event counter data for Cascadelakex weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 06/18] perf pmu-events: Add event counter data for Icelakex weilin.wang
2024-01-25 4:54 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 07/18] perf stat: Add functions to set counter bitmaps for hardware-grouping method weilin.wang
2024-01-24 5:17 ` Ian Rogers
2024-01-24 16:59 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 08/18] perf stat: Add functions to get counter info weilin.wang
2024-01-24 15:57 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 09/18] perf stat: Add functions to create new group and assign events into groups for hardware-grouping method weilin.wang
2024-01-24 16:52 ` Ian Rogers
2024-01-24 17:06 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 10/18] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2024-01-24 18:36 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 11/18] perf stat: Add function to handle special events " weilin.wang
2024-01-24 18:58 ` Ian Rogers
2023-12-12 23:02 ` [RFC PATCH v3 12/18] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 13/18] perf stat: Handle taken alone in hardware-grouping weilin.wang
2024-01-25 5:02 ` Ian Rogers
2024-01-26 18:14 ` Wang, Weilin
2023-12-12 23:02 ` [RFC PATCH v3 14/18] perf stat: Handle NMI " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 15/18] perf stat: Code refactoring " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 16/18] perf stat: Add tool events support " weilin.wang
2023-12-12 23:02 ` [RFC PATCH v3 17/18] perf pmu-events: Add event counter data for Tigerlake weilin.wang
2023-12-12 23:02 ` weilin.wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212230224.1473300-20-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).