From: Leo Yan <leo.yan@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3] perf doc: Document ring buffer mechanism
Date: Sat, 6 Jan 2024 18:48:56 +0800 [thread overview]
Message-ID: <20240106104856.GA172473@leoy-huanghe> (raw)
In-Reply-To: <ZRvjTW4PACGaU2h+@gmail.com>
Hi Ingo,
On Tue, Oct 03, 2023 at 11:47:57AM +0200, Ingo Molnar wrote:
[...]
> > > tools/perf/Documentation/perf-ring-buffer.txt | 762 ++++++++++++++++++
> > > 1 file changed, 762 insertions(+)
> > > create mode 100644 tools/perf/Documentation/perf-ring-buffer.txt
> >
> > Nice addition!
> >
> > If it hasn't been picked up yet:
> >
> > Acked-by: Ingo Molnar <mingo@kernel.org>
>
> Note that my ack is conditional on the conversion to RST and moving to
> Documentation/ - this documents an important aspect of the primary perf
> ABI, it deserves to be on the kernel side.
I sent patch v8 on the LKML [1], patch v8 has converted the doc to RST
format and with other amending, this is why I didn't add your Acked tag
in it.
Anyway, thanks for review and sorry for my long delayed response.
Leo
[1] https://lore.kernel.org/lkml/20240102085001.228815-1-leo.yan@linaro.org/
prev parent reply other threads:[~2024-01-06 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:46 [PATCH v3] perf doc: Document ring buffer mechanism Leo Yan
2023-10-03 9:22 ` Ingo Molnar
2023-10-03 9:47 ` Ingo Molnar
2024-01-06 10:48 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240106104856.GA172473@leoy-huanghe \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).