From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471BA7F5; Wed, 17 Jan 2024 02:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705459564; cv=none; b=ovGzjuhdrg4Ce2q722GZswnTteMv6JXF1gZfyEbk9wFH6IssPKWFk/J/67PeBWtYumHZmdsvLV3Fxld079rrzCAYY0CPLbZkGQkp+S/MU7o/GqyNhrTfZD4PfFasHJ0R9EL0lMMCBa61mi7pJNyKZNImujCCecPwRda6Q13wIVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705459564; c=relaxed/simple; bh=L+322wxPKL4eMRTYmUzw04vNs6lJ31cNwDNHzWkMclo=; h=Received:Received:Received:Date:From:To:CC:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:X-Originating-IP:X-ClientProxiedBy; b=T+x1guc+wp7RwAbynEzA7NIP1de/zbyuBwU+QKWACU14nJqnYdjTUZ1l+r1ZHXQeNalBIheGZyTgz2i/11TIvxHTZXWBhT7iQ9HzW8beUkUxZfZogvSy58/GR+KnZXflaV3fW/ATvIBaT/R7eEBS6wTa3WT2+JizIAnEo+9ZVfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TF9Gq2rBvz1wnCy; Wed, 17 Jan 2024 10:45:39 +0800 (CST) Received: from kwepemd100002.china.huawei.com (unknown [7.221.188.184]) by mail.maildlp.com (Postfix) with ESMTPS id 4D746140113; Wed, 17 Jan 2024 10:45:58 +0800 (CST) Received: from M910t (10.110.54.157) by kwepemd100002.china.huawei.com (7.221.188.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Wed, 17 Jan 2024 10:45:57 +0800 Date: Wed, 17 Jan 2024 10:45:46 +0800 From: Changbin Du To: Andi Kleen CC: Changbin Du , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , , Subject: Re: [PATCH 0/3] perf: script: Intro capstone disasm engine to show instruction trace Message-ID: <20240117024546.2npqrprazaobyogn@M910t> References: <20240116113437.1507537-1-changbin.du@huawei.com> <87il3tl6zf.fsf@linux.intel.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87il3tl6zf.fsf@linux.intel.com> X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100002.china.huawei.com (7.221.188.184) On Tue, Jan 16, 2024 at 05:53:40AM -0800, Andi Kleen wrote: > Changbin Du writes: > > > This series introduces capstone disassembler engine to print instructions of > > Intel PT trace, which was printed via the XED tool. > > FWIW at least on x86 in my experience capstone isn't that great an > disassembler. I used it in another project and ran into many decoding bugs. > They're mostly in obscure corners, but can be fairly annoying. > If so, I will preserve the old --xed option as an alternate. > My other concern with your patchkit is that you change the default > output formats. Since perf script is often used with scripts > (as the name implies) there is a certain expectation that the output > remains stable and parse-able. There are actually use cases where > the raw bytes "insn" output is needed. > > I would rather define new perf script output types for the new decoded output, > but keep the old alone. Agreed. What about these? - Add a new field 'insn_disam' to display decoded output. - Add params to '--insn-trace' option, that is '--insn-trace=[raw|disam]'. 'raw' is the default value. > > -Andi -- Cheers, Changbin Du