From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B4CA1FAD for ; Wed, 24 Jan 2024 04:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706070623; cv=none; b=OTjSxqvcrds1hwL+bIDFn3p0xBdFJ5GpVNprOGaWP/jsSDpN/MxK5e3WFDeRT2/hVkBy6sIlXCpL6hQrCcF22IGgXCdedL2qBSUH9eSFeaj6tDSVsoQTsiBEQf+bHxuyTPhBq6XS/w8tHrJEYZn0m3ECTDOwwzW43HpSARkHPdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706070623; c=relaxed/simple; bh=Vi/GfW1dMQPoGBuKzYbsciwSwEbn5gukZ6R2a6MtY+w=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=Eqph+cR3psER+fHjSdFcmh56CVkUP17Non6dTamOyG66vc8rz5xdsF80Gpnf0YooWXukHF4Uc8OR36i+q3g6bufIGb7gFyCMuDbymFgppSpFY7ysx3vVpH5Fbsd7EUPoOAekOf/hXD0n30Ce22MJ1EpPnCS9dZe9Tdd2KkqswsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZKwuifcd; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZKwuifcd" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5f53b4554b6so74954287b3.3 for ; Tue, 23 Jan 2024 20:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706070621; x=1706675421; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=NGesi/lkn/z+ibscMuM5m5HKI16hb6v/aTcwmpsw9TE=; b=ZKwuifcd1sXYBpwthPqpMbGMO0e41n7mnUDZ2amFZvyquT1643vj4e4rrBRmICD3vK zXPU0gkOW6zZ7jAOShcWzT3B4jFEXUBMkQJ5oel7Tz5ZL6qbOE8SND+b6AEHI437NVxD quMteipk7AdAobMNh1lpnLFXMIZip9ztVhu067S4OyeCSYl4v3Ow0kfj8fYGPUq4jn8k tZJtINh6MhGnoeiuP0cGgsza2U+D/aMyRfmpL5+IrGrzbBkV5PgitNUrIceusAiKLawy St9+YX+ruz1/jqUvHxGf8mvymMecdQWVmCjz/6oW1F80rw9S6FTJgMWfnA/GpW3juacB a9vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706070621; x=1706675421; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NGesi/lkn/z+ibscMuM5m5HKI16hb6v/aTcwmpsw9TE=; b=HbIXYBrTioUk17hWp3jGZJWI3Wq2eir89hlwgpuw5Nk/pUGPlmE/A0leMNmhfgNEUQ jZkht4JPt7QU2edAoFQvu4cYOtD57xNFilSbxTV7QVXu0/Gv3ZhadNVdOXXcIk28RzJB SQ0E70NAbwu7AVlPGBq1ZaFzj5nJ5CfY7mDCNJh6XUxIVlAL3FhArQpG7Apxz4SgRdGv /ZJpnBONlAbfkfKwN9zD5t8ONimOxOY5uWCSqT+FvJ8vSLnf8vtVzvHdGBXMFFTu8x5H FnUQCs4PI08JOdRyKfIbrBLMFbV5PbkAO4HmEgzvzdII2ebTOhgBBfvDS4Dk9zrIbADD J96A== X-Gm-Message-State: AOJu0Yx7p8M3+PGqg+BMOKXwtrcm6Gp8WuHNyVm1g9RvUqTZrn5DYXhN 3HLmynBsxbCIsQio+Hwx588dkBya7RC3LbElhy/TL01YErC1Gs6cj/oTct7F8PFkClIOT1tXHO+ tEyWDFw== X-Google-Smtp-Source: AGHT+IFuyLICJEIzRyi+Jplw1i4utF9oYp3mAPPTFQaHlqHi3G4RBhbpQUYe7uRk+csKQHqIDFE1YEy6OGoA X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:b37:2438:2b2f:daae]) (user=irogers job=sendgmr) by 2002:a81:99d6:0:b0:5e6:1070:44e0 with SMTP id q205-20020a8199d6000000b005e6107044e0mr74539ywg.5.1706070621186; Tue, 23 Jan 2024 20:30:21 -0800 (PST) Date: Tue, 23 Jan 2024 20:30:11 -0800 In-Reply-To: <20240124043015.1388867-1-irogers@google.com> Message-Id: <20240124043015.1388867-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240124043015.1388867-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Subject: [PATCH v2 1/5] perf list: Switch error message to pr_err From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Ravi Bangoria , Ross Zwisler , Athira Rajeev , Shirisha G , Kajol Jain , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Using printf can interrupt perf list output, use pr_err which can respect debug settings and the debug file. Signed-off-by: Ian Rogers Acked-by: Namhyung Kim --- tools/perf/util/print-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index b0fc48be623f..9e47712507cc 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -66,7 +66,7 @@ void print_tracepoint_events(const struct print_callbacks *print_cb __maybe_unus put_tracing_file(events_path); if (events_fd < 0) { - printf("Error: failed to open tracing events directory\n"); + pr_err("Error: failed to open tracing events directory\n"); return; } -- 2.43.0.429.g432eaa2c6b-goog