From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3808B4D131 for ; Wed, 31 Jan 2024 06:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682663; cv=none; b=PJ2dxnjY7DqkuQqFMgT6SWFyVpcTLg88DjzFZ/pQPBq33ogYXD6Spf4pQYKIzl5te/g20iT3C2kc88tUfyLh5qKakAEnYW1zfd3Ml9UR1bEp4ECMsLuMOBJcfNRyy1nl1YE54GPAWM9p4E4KsgvvZ0uBg8YVHZvCkNIiskUtPME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706682663; c=relaxed/simple; bh=u2dme1MUFaWQF1BSStVrUjjYLnHIqMsZ+Wjfwetyd+o=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=AVFl0OFLB6a4J3PPCxa6wAsTnhkAU5WQyewflezdtDUI1i6rGZre0N+aGYC65V9VNGBAcxzBlT1DCITt+2BJMdR5O5cROV6BE08EbyvecgQFVTvI4oNyLtoPsMu5u9bOUXHr/2GjzPWvKyMgD5AfiYAg1FQM2oUx6U8SNHl8BDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lEY1N22a; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lEY1N22a" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60406626b50so12705407b3.0 for ; Tue, 30 Jan 2024 22:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706682661; x=1707287461; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=TRAmZ7zfR7GIpS+aIsz6syaxM6Q4TrPavG5oF05xWJs=; b=lEY1N22aJJjhJRhsVvGAVQPEvDbXmvRSX97spBk7Kb2HByaW1DeNHA3PKNI49OeAvV nuF3qFqv+xfoQmEsMnaJLSr0I51Xk3m6lUtvepUFZdeL5YWiJFgj6idkZSau7c2dJ3wv tQhUiIvoiy7ST5arM0rukkJQpspxEo/vjviYkqFTXAl8QFHMSKidDA2bv1utAWEs/b02 oUl7FaKzrA5I7PTQcZZK6Qf7cDzqPW5yYOLgfA8klQ+AG/xmEPQeagIf+4fbmx9iaLL6 dWj6pqNIc3iloB8cvSU4Ua85fYXDoVtEAq+QDmuAeZywfmnOLvRD4p2U9eh9R1XWWKPX YeBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706682661; x=1707287461; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TRAmZ7zfR7GIpS+aIsz6syaxM6Q4TrPavG5oF05xWJs=; b=TOyTYFvn/P+sG2MgjoZKcnWjz0fnprydt1zSjedMXS4AN+Z2kPAaqOU565YEczwh5q iIA4b8zmN8IsgBHpsTqsOkGmUacAFNSL+P06TFs/U2e5AjEdT4O2Y25NqCABqGOzuOQp 0gV7XvS1fo/Z95XP85X7aAZaCdRPGZtnx+9M59nBjdNqIk7kK4W/uJ3IHgPpceU92ItC cy+NnJedZpBED9J8QBA2o3/ljS10tlL0hRXEoLcwgxMtJURywgBkIdt+zk5lY1VAg8b8 ahxRBLMVGllunmaUUz2Rw2TmmtCDX39gSlMfTZHyiaxixt/gijNQlU4TbPhkkDk6i4jG lOSg== X-Gm-Message-State: AOJu0Yx56kXWT0HvA7Y1R8FYHJxnG55XtTWfusRbuuZwxNlSJBuBsdev 6uXH6tdacXEdUPzAFE1YxtoB/1M1cAqygl7WmTqU0FSHKTh7aESbqYaYgaTONgSBIUZe6zDa06q rWF1hlQ== X-Google-Smtp-Source: AGHT+IFsiiN7iGKJd/InFXViWO69CjjVsRDCvAxsD8KKE2kphIKbHGhlve9tfNNSeYZg/JPhRlGwiUilpQ+z X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:d0ab:43c6:7969:62ab]) (user=irogers job=sendgmr) by 2002:a81:9946:0:b0:604:45a:6740 with SMTP id q67-20020a819946000000b00604045a6740mr134886ywg.2.1706682661259; Tue, 30 Jan 2024 22:31:01 -0800 (PST) Date: Tue, 30 Jan 2024 22:30:46 -0800 Message-Id: <20240131063048.492010-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Subject: [PATCH v1 1/2] perf tsc: Add missing newlines to debug statements From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, tchen168@asu.edu, Michael Petlan Content-Type: text/plain; charset="UTF-8" It is assumed that debug statements always print a newline, fix two missing ones. Signed-off-by: Ian Rogers --- This patch was inspired by bad debug output in: https://lore.kernel.org/linux-perf-users/CAGjhMsg_bVKJ_zfsLUR32+oZwGDr3OiBHV_BJ3QtFjyKAs7Sgg@mail.gmail.com/ --- tools/perf/arch/x86/util/tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c index 9b99f48b923c..e2d6cfe21057 100644 --- a/tools/perf/arch/x86/util/tsc.c +++ b/tools/perf/arch/x86/util/tsc.c @@ -33,7 +33,7 @@ static double cpuinfo_tsc_freq(void) cpuinfo = fopen("/proc/cpuinfo", "r"); if (!cpuinfo) { - pr_err("Failed to read /proc/cpuinfo for TSC frequency"); + pr_err("Failed to read /proc/cpuinfo for TSC frequency\n"); return NAN; } while (getline(&line, &len, cpuinfo) > 0) { @@ -48,7 +48,7 @@ static double cpuinfo_tsc_freq(void) } out: if (fpclassify(result) == FP_ZERO) - pr_err("Failed to find TSC frequency in /proc/cpuinfo"); + pr_err("Failed to find TSC frequency in /proc/cpuinfo\n"); free(line); fclose(cpuinfo); -- 2.43.0.429.g432eaa2c6b-goog