From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: [RFC PATCH v4 04/15] find_bit: add _find_last_and_bit() to support finding the most significant set bit
Date: Thu, 8 Feb 2024 19:14:30 -0800 [thread overview]
Message-ID: <20240209031441.943012-5-weilin.wang@intel.com> (raw)
In-Reply-To: <20240209031441.943012-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
This function is required for more efficient PMU counter assignment.
When we use bitmap to log available PMU counters and counters that support a
given event, we want to find a most significant set bit so that we could
starting assigning counters with larger index first. This is helpful
because counters with smaller indexes usually are more generic and
support more events.
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
tools/include/linux/find.h | 18 ++++++++++++++++++
tools/lib/find_bit.c | 33 +++++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
diff --git a/tools/include/linux/find.h b/tools/include/linux/find.h
index 38c0a542b0e2..fce336ec2b96 100644
--- a/tools/include/linux/find.h
+++ b/tools/include/linux/find.h
@@ -18,6 +18,8 @@ extern unsigned long _find_first_bit(const unsigned long *addr, unsigned long si
extern unsigned long _find_first_and_bit(const unsigned long *addr1,
const unsigned long *addr2, unsigned long size);
extern unsigned long _find_first_zero_bit(const unsigned long *addr, unsigned long size);
+extern unsigned long _find_last_and_bit(const unsigned long *addr1,
+ const unsigned long *addr2, unsigned long size);
#ifndef find_next_bit
/**
@@ -174,4 +176,20 @@ unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size)
}
#endif
+#ifndef find_last_and_bit
+static inline
+unsigned long find_last_and_bit(const unsigned long *addr1,
+ const unsigned long *addr2,
+ unsigned long size)
+{
+ if (small_const_nbits(size)) {
+ unsigned long val = *addr1 & *addr2 & GENMASK(size - 1, 0);
+
+ return val ? __fls(val) : size;
+ }
+
+ return _find_last_and_bit(addr1, addr2, size);
+}
+#endif
+
#endif /*__LINUX_FIND_H_ */
diff --git a/tools/lib/find_bit.c b/tools/lib/find_bit.c
index 6a3dc167d30e..e475a7368e36 100644
--- a/tools/lib/find_bit.c
+++ b/tools/lib/find_bit.c
@@ -67,6 +67,27 @@ out: \
sz; \
})
+/*
+ * Common helper for find_bit() function family
+ * @FETCH: The expression that fetches and pre-processes each word of bitmap(s)
+ * @MUNGE: The expression that post-processes a word containing found bit (may be empty)
+ * @size: The bitmap size in bits
+ */
+#define FIND_LAST_BIT(FETCH, MUNGE, size) \
+({ \
+ unsigned long idx, val, sz = (size); \
+ \
+ for (idx = ((size - 1) / BITS_PER_LONG); idx >= 0; idx--) { \
+ val = (FETCH); \
+ if (val) { \
+ sz = min(idx * BITS_PER_LONG + __fls(MUNGE(val)), sz); \
+ break; \
+ } \
+ } \
+ \
+ sz; \
+})
+
#ifndef find_first_bit
/*
* Find the first set bit in a memory region.
@@ -121,3 +142,15 @@ unsigned long _find_next_zero_bit(const unsigned long *addr, unsigned long nbits
return FIND_NEXT_BIT(~addr[idx], /* nop */, nbits, start);
}
#endif
+
+#ifndef find_last_and_bit
+/*
+ * Find the last set bit in two memory regions.
+ */
+unsigned long _find_last_and_bit(const unsigned long *addr1,
+ const unsigned long *addr2,
+ unsigned long size)
+{
+ return FIND_LAST_BIT(addr1[idx] & addr2[idx], /* nop */, size);
+}
+#endif
\ No newline at end of file
--
2.42.0
next prev parent reply other threads:[~2024-02-09 3:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 3:14 [RFC PATCH v4 00/15] Perf stat metric grouping with hardware information weilin.wang
2024-02-09 3:14 ` [RFC PATCH v4 01/15] perf stat: Add new field in stat_config to enable hardware aware grouping weilin.wang
2024-02-09 3:14 ` [RFC PATCH v4 02/15] perf stat: Add basic functions for the " weilin.wang
2024-02-09 3:14 ` [RFC PATCH v4 03/15] perf pmu-events: Add functions in jevent.py to parse counter and event info for " weilin.wang
2024-03-24 4:49 ` Ian Rogers
2024-03-26 22:41 ` Wang, Weilin
2024-03-27 0:02 ` Ian Rogers
2024-02-09 3:14 ` weilin.wang [this message]
2024-03-24 4:19 ` [RFC PATCH v4 04/15] find_bit: add _find_last_and_bit() to support finding the most significant set bit Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 05/15] perf stat: Add functions to set counter bitmaps for hardware-grouping method weilin.wang
2024-03-24 4:51 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 06/15] perf stat: Add functions to get counter info weilin.wang
2024-03-24 4:58 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 07/15] perf stat: Add functions to create new group and assign events into groups weilin.wang
2024-03-24 5:00 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 08/15] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2024-02-09 3:14 ` [RFC PATCH v4 09/15] perf stat: Add function to handle special events " weilin.wang
2024-03-24 5:20 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 10/15] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2024-02-09 3:14 ` [RFC PATCH v4 11/15] perf stat: Handle taken alone in hardware-grouping weilin.wang
2024-03-24 5:24 ` Ian Rogers
2024-03-26 23:06 ` Wang, Weilin
2024-03-27 0:05 ` Ian Rogers
2024-03-27 0:40 ` Wang, Weilin
2024-02-09 3:14 ` [RFC PATCH v4 12/15] perf stat: Handle NMI " weilin.wang
2024-03-24 5:26 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 13/15] perf stat: Code refactoring " weilin.wang
2024-03-24 5:46 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 14/15] perf stat: Add tool events support " weilin.wang
2024-03-24 5:56 ` Ian Rogers
2024-04-09 20:51 ` Wang, Weilin
2024-04-10 17:47 ` Ian Rogers
2024-02-09 3:14 ` [RFC PATCH v4 15/15] perf stat: Add hardware-grouping cmd option to perf stat weilin.wang
2024-03-24 5:56 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209031441.943012-5-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).