From: Pairman Guo <pairmanxlr@gmail.com>
To: mingo@redhat.com, namhyung@kernel.org
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Pairman Guo <pairmanxlr@gmail.com>
Subject: [PATCH] Perf: Use fallthrough pseudo-keyword
Date: Thu, 15 Feb 2024 17:26:59 +0800 [thread overview]
Message-ID: <20240215092659.148946-1-pairmanxlr@gmail.com> (raw)
Hi maintainers,
There is a usage of ``/* fall thru */`` in a switch statement in
hist_browser__handle_hotkey() that have long been untouched.
This patch replaced it with the better and proper pseudo-keyword
``fallthrough;``.
Please merge if it is the case. Thank you in advance.
Signed-off-by: Pairman Guo <pairmanxlr@gmail.com>
---
tools/perf/ui/browsers/hists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 0c02b3a8e..aed835946 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -732,7 +732,7 @@ static int hist_browser__handle_hotkey(struct hist_browser *browser, bool warn_l
case '+':
if (hist_browser__toggle_fold(browser))
break;
- /* fall thru */
+ fallthrough;
default:
return -1;
}
--
2.43.1
reply other threads:[~2024-02-15 9:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215092659.148946-1-pairmanxlr@gmail.com \
--to=pairmanxlr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).