linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Perry Taylor <perry.taylor@intel.com>,
	Samantha Alt <samantha.alt@intel.com>,
	 Caleb Biggers <caleb.biggers@intel.com>,
	Weilin Wang <weilin.wang@intel.com>,
	 Edward Baker <edward.baker@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	 Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@arm.com>,
	John Garry <john.g.garry@oracle.com>,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Stephane Eranian <eranian@google.com>
Subject: [PATCH v2 16/20] perf jevents: Add local/remote "mem" breakdown metrics for Intel
Date: Fri,  1 Mar 2024 10:55:55 -0800	[thread overview]
Message-ID: <20240301185559.2661241-17-irogers@google.com> (raw)
In-Reply-To: <20240301185559.2661241-1-irogers@google.com>

Breakdown local and remote memory bandwidth, read and writes. The
implementation uses the HA and CHA PMUs present in server models
broadwellde, broadwellx cascadelakex, emeraldrapids, haswellx,
icelakex, ivytown, sapphirerapids and skylakex.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/intel_metrics.py | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events/intel_metrics.py
index a5d68b7deab3..76e71f11a579 100755
--- a/tools/perf/pmu-events/intel_metrics.py
+++ b/tools/perf/pmu-events/intel_metrics.py
@@ -784,6 +784,32 @@ def IntelLdSt() -> Optional[MetricGroup]:
   ], description = "Breakdown of load/store instructions")
 
 
+def UncoreMem() -> Optional[MetricGroup]:
+  try:
+    loc_rds = Event("UNC_CHA_REQUESTS.READS_LOCAL", "UNC_H_REQUESTS.READS_LOCAL")
+    rem_rds = Event("UNC_CHA_REQUESTS.READS_REMOTE", "UNC_H_REQUESTS.READS_REMOTE")
+    loc_wrs = Event("UNC_CHA_REQUESTS.WRITES_LOCAL", "UNC_H_REQUESTS.WRITES_LOCAL")
+    rem_wrs = Event("UNC_CHA_REQUESTS.WRITES_REMOTE", "UNC_H_REQUESTS.WRITES_REMOTE")
+  except:
+    return None
+
+  scale = 64 / 1_000_000
+  return MetricGroup("mem", [
+      MetricGroup("mem_local", [
+          Metric("mem_local_read", "Local memory read bandwidth not including directory updates",
+                 d_ratio(loc_rds, interval_sec), f"{scale}MB/s"),
+          Metric("mem_local_write", "Local memory write bandwidth not including directory updates",
+                 d_ratio(loc_wrs, interval_sec), f"{scale}MB/s"),
+      ]),
+      MetricGroup("mem_remote", [
+          Metric("mem_remote_read", "Remote memory read bandwidth not including directory updates",
+                 d_ratio(rem_rds, interval_sec), f"{scale}MB/s"),
+          Metric("mem_remote_write", "Remote memory write bandwidth not including directory updates",
+                 d_ratio(rem_wrs, interval_sec), f"{scale}MB/s"),
+      ]),
+  ], description = "Memory Bandwidth breakdown local vs. remote (remote requests in). directory updates not included")
+
+
 def UncoreMemBw() -> Optional[MetricGroup]:
   mem_events = []
   try:
@@ -859,6 +885,7 @@ all_metrics = MetricGroup("", [
     IntelMlp(),
     IntelPorts(),
     IntelSwpf(),
+    UncoreMem(),
     UncoreMemBw(),
 ])
 
-- 
2.44.0.278.ge034bb2e1d-goog


  parent reply	other threads:[~2024-03-01 18:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 18:55 [PATCH v2 00/20] Python generated Intel metrics Ian Rogers
2024-03-01 18:55 ` [PATCH v2 01/20] perf jevents: Add RAPL metrics for all Intel models Ian Rogers
2024-03-01 18:55 ` [PATCH v2 02/20] perf jevents: Add idle metric for " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 03/20] perf jevents: Add smi metric group " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 04/20] perf jevents: Add tsx " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 05/20] perf jevents: Add CheckPmu to see if a PMU is in loaded json events Ian Rogers
2024-03-01 18:55 ` [PATCH v2 06/20] perf jevents: Add br metric group for branch statistics on Intel Ian Rogers
2024-03-01 18:55 ` [PATCH v2 07/20] perf jevents: Add software prefetch (swpf) metric group for Intel Ian Rogers
2024-03-01 18:55 ` [PATCH v2 08/20] perf jevents: Add ports metric group giving utilization on Intel Ian Rogers
2024-03-01 18:55 ` [PATCH v2 09/20] perf jevents: Add L2 metrics for Intel Ian Rogers
2024-03-01 18:55 ` [PATCH v2 10/20] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 11/20] perf jevents: Add ILP metrics " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 12/20] perf jevents: Add context switch " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 13/20] perf jevents: Add FPU " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 14/20] perf jevents: Add Miss Level Parallelism (MLP) metric " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 15/20] perf jevents: Add mem_bw " Ian Rogers
2024-03-01 18:55 ` Ian Rogers [this message]
2024-03-01 18:55 ` [PATCH v2 17/20] perf jevents: Add dir breakdown metrics " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 18/20] perf jevents: Add C-State metrics from the PCU PMU " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 19/20] perf jevents: Add local/remote miss latency metrics " Ian Rogers
2024-03-01 18:55 ` [PATCH v2 20/20] perf jevents: Add upi_bw metric " Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301185559.2661241-17-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=caleb.biggers@intel.com \
    --cc=edward.baker@intel.com \
    --cc=eranian@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=samantha.alt@intel.com \
    --cc=weilin.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).