From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B806B335C7 for ; Sat, 9 Mar 2024 05:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709963562; cv=none; b=fWvZHJRGgvfczBOGWfC8TOiPZhMzeFl2JN4b/yMjazEb5gTGLYDXDtUbFWF4EtktY5x8HAQhe1Pf7PZbRidO1uIlOES2hUhrEbwFtfejSlzEFsCgLyy+wSC7Qrd9qWQLryMiI+KC/emUvjcX5HP1ESf2VKKoqWEHt/vVSwvnoPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709963562; c=relaxed/simple; bh=sR+BPHJ1/sj+1OYrzbGt3pdUlfbZ2z+4FBt9JSITybU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r2TmfViEBDFgckaB2Bppq92WSG/agt7CaLURD0CSHg8Gi/1yk3/5JkamUZuGIKFL02Q6T44zQnsZBJHJu+50ViZ/AiPZ2SuZHA4ISCHvF5aysAYtT5qL7zXSdrLvWu4C3MQZZTFFr+xs48IXZ0s2z4F9QY+BcXLmiVLaipkOdOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com; spf=none smtp.mailfrom=linux.vnet.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ADreIOTi; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ADreIOTi" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4295Hd15025051; Sat, 9 Mar 2024 05:52:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=wR8wsx8XHoyJZG6Govc76HMoUvHf7YwLRQtEF1VahdQ=; b=ADreIOTizFFqo/sRljFX6WQgVUxPbpbaEHKNs1A7DppD+gSMzMk5jKRdTgedW01BLSz3 ES7Ccj26iQ102Hpl3OR2scINbzkbT/pkRpL9K5WKshcA9torzg4xI0o7r6DNEBV2KsZg 7IL4ZU6WrPvs/x4ecmMDeOphW+KFia8hsHrcuRFcLvm+Rgz1DQarnvxQol4I0Jj/D26N zraEkq88bKnfAA0zp9I7BGAm53TqJll1tsN4bbOF/MLBD+9QshsQnLnXpcJLu67qgz/h 8QyCptv0vYunB4M0Jrr6/iZMQ+Q0FOpelrnX6MBZbbG15wFf0fFxQYMm/+HyE3bo8BAD 1g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wrhg907j4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 05:52:33 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4295oFQE018476; Sat, 9 Mar 2024 05:52:32 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wrhg907j3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 05:52:32 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4295e8hb024211; Sat, 9 Mar 2024 05:52:32 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wpjwsvahg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 05:52:32 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4295qQn637683546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 9 Mar 2024 05:52:28 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D66A20040; Sat, 9 Mar 2024 05:52:26 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E15D920043; Sat, 9 Mar 2024 05:52:20 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.52.192]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 9 Mar 2024 05:52:20 +0000 (GMT) From: Athira Rajeev To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, irogers@google.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com Subject: [PATCH 2/3] tools/erf/util/annotate: Set register_char and memory_ref_char for powerpc Date: Sat, 9 Mar 2024 11:21:35 +0530 Message-Id: <20240309055136.96556-3-atrajeev@linux.vnet.ibm.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20240309055136.96556-1-atrajeev@linux.vnet.ibm.com> References: <20240309055136.96556-1-atrajeev@linux.vnet.ibm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: J8uDUiWwdi-WPjKgVUEqfKX00d6RndVV X-Proofpoint-GUID: 12W07VxBTvcenmWkhsR2OmT_NSwAqBZ0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403090045 To identify if the instruction has any memory reference, "memory_ref_char" field needs to be set for specific architecture. Example memory instruction: lwz r10,0(r9) Here "(" is the memory_ref_char. Set this as part of arch->objdump To get register number and access offset from the given instruction, arch->objdump.register_char is used. In case of powerpc, the register char is "r" (since reg names are r0 to r31). Hence set register_char as "r". Signed-off-by: Athira Rajeev --- tools/perf/util/annotate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index ac002d907d81..d69bd6edafcb 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -216,6 +216,11 @@ static struct arch architectures[] = { { .name = "powerpc", .init = powerpc__annotate_init, + .objdump = { + .comment_char = '#', + .register_char = 'r', + .memory_ref_char = '(', + }, }, { .name = "riscv64", -- 2.43.0