From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F261EB39 for ; Sat, 9 Mar 2024 07:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709969140; cv=none; b=hsJxUafKdVcVx/HenU4spT6qtxlzvuYfRfOnR/ZHYtN2vJjJMnbEavRgTFqCnkSQOYdkZkutq7YBD+FjpOjOdjc6PNpln1bhhPQqCp6lRoT9A5WYXuGfUSwAmzJyjMQqhV4kBGtk0+Sj1DIlpFYr7zypZ0YO8aCHNg/AD5Imh7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709969140; c=relaxed/simple; bh=288g0/lGhBnLB0NGSdbh8XC17Hu8CxDRpGft0kUe8T0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r2B/GyMEw72HYIlt7eocEELmyotSA6ye4yOxHkveNTnsf1ySgFqiBuQqsugC3kpKmO99hW8WDSUtiTr3l26hy4/+tM8G3cpl0fslQGi6r999pmQDqHRfh7E2Sqy2f1LL6MfeAfYrkRmggT5UFMOsgL/MgrjqfILN3xrUD2OwKhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com; spf=none smtp.mailfrom=linux.vnet.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=C0trd+Sn; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="C0trd+Sn" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4296vsqG022371; Sat, 9 Mar 2024 07:25:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=X5I2w3f3XI/N9qabVyA/+yTilyvXl6YZKjwMTw3cU5U=; b=C0trd+SnS9o1DCmtPBt9UH4JWrFs77E2YDDApwBrJTDj3SmrrS9IKSUpbESZwLk77w4o /GWe8L64f6q58AZHZF4EXYbrlc5FKHh5ieyulPfyYNCTYyuMaBVzNH8TNzZP4fdyQUt8 9SY0RNEe/7OnA/Nkv+n/LwybCSQKtp1b7sE+4KncYLps1j2fT8hykeitNqObP9E4+OCJ U/DgDQ6gOZ8uvshQEWx8yyTNpXivRI43kfqsJE8sPsMKKvVwHhEDzpHU53P9F9T1neGv Paqj1FNlQTAP8c+sdIESSWzoOuoEqmWHTxKGPGoV/xKXZlOTmWFgRUjCK1Bi7YQGHLiU KQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wrjy389da-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 07:25:28 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4297PGtj015946; Sat, 9 Mar 2024 07:25:28 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wrjy389d7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 07:25:28 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4295PZVZ024172; Sat, 9 Mar 2024 07:25:27 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wpjwsvnq2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 09 Mar 2024 07:25:27 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4297PMwQ35520976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 9 Mar 2024 07:25:24 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2F46520043; Sat, 9 Mar 2024 07:25:22 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0EA002004E; Sat, 9 Mar 2024 07:25:17 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.52.192]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 9 Mar 2024 07:25:16 +0000 (GMT) From: Athira Rajeev To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, irogers@google.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com Subject: [PATCH 0/3] Add data type profiling support for powerpc Date: Sat, 9 Mar 2024 12:55:10 +0530 Message-Id: <20240309072513.9418-1-atrajeev@linux.vnet.ibm.com> X-Mailer: git-send-email 2.35.1 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5dNOiW_83gD_gwIfHblHmQIvH67HeLzr X-Proofpoint-GUID: UusuRdxouf3WDuNRbRvk7_PPNvXn7q36 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403090058 The patchset from Namhyung added support for data type profiling in perf tool. This enabled support to associate PMU samples to data types they refer using DWARF debug information. With the upstream perf, currently it possible to run perf report or perf annotate to view the data type information on x86. This patchset includes changes need to enable data type profiling support for powerpc. Main change are: 1. powerpc instruction nmemonic table to associate load/store instructions with move_ops which is use to identify if instruction is a memory access one. 2. To get register number and access offset from the given instruction, code uses fields from "struct arch" -> objump. Add entry for powerpc here. 3. A get_arch_regnum to return register number from the register name string. These three patches are the basic foundational patches. With these changes, data types is getting identified for kernel and user-space samples. There are still samples, which comes as "unknown" and needs to be checked. We plan to get those addressed in follow up. With the current patchset: ./perf record -a -e mem-loads sleep 1 ./perf report -s type,typeoff --hierarchy --group --stdio Snippet of logs: Total Lost Samples: 0 Samples: 277 of events 'mem-loads, dummy:u' Event count (approx.): 149813 Overhead Data Type / Data Type Offset ................... ............................ 65.93% 0.00% (unknown) 65.93% 0.00% (unknown) +0 (no field) 8.19% 0.00% struct vm_area_struct 8.19% 0.00% struct vm_area_struct +136 (vm_file) 4.53% 0.00% struct rq 3.14% 0.00% struct rq +0 (__lock.raw_lock.val) 0.83% 0.00% struct rq +3216 (avg_irq.runnable_sum) 0.24% 0.00% struct rq +4 (nr_running) 0.14% 0.00% struct rq +12 (nr_preferred_running) 0.12% 0.00% struct rq +2760 (sd) 0.06% 0.00% struct rq +3368 (prev_steal_time_rq) 0.01% 0.00% struct rq +2592 (curr) 3.53% 0.00% struct rb_node 3.53% 0.00% struct rb_node +0 (__rb_parent_color) 3.43% 0.00% struct slab 3.43% 0.00% struct slab +32 (freelist) 3.30% 0.00% unsigned int 3.30% 0.00% unsigned int +0 (no field) 3.22% 0.00% struct vm_fault 3.22% 0.00% struct vm_fault +48 (pmd) 2.55% 0.00% unsigned char 2.55% 0.00% unsigned char +0 (no field) 1.06% 0.00% struct task_struct 1.06% 0.00% struct task_struct +4 (thread_info.cpu) 0.92% 0.00% void* 0.92% 0.00% void* +0 (no field) 0.74% 0.00% __int128 unsigned 0.74% 0.00% __int128 unsigned +8 (no field) 0.59% 0.00% struct perf_event 0.54% 0.00% struct perf_event +552 (ctx) 0.04% 0.00% struct perf_event +152 (pmu) 0.20% 0.00% struct sched_entity 0.20% 0.00% struct sched_entity +0 (load.weight) 0.18% 0.00% struct cfs_rq 0.18% 0.00% struct cfs_rq +96 (curr) Thanks Athira Athira Rajeev (3): tools/perf/arch/powerpc: Add load/store in powerpc annotate instructions for data type profling tools/erf/util/annotate: Set register_char and memory_ref_char for powerpc tools/perf/arch/powerc: Add get_arch_regnum for powerpc .../perf/arch/powerpc/annotate/instructions.c | 66 +++++++++++++++++++ tools/perf/arch/powerpc/util/dwarf-regs.c | 29 ++++++++ tools/perf/util/annotate.c | 5 ++ 3 files changed, 100 insertions(+) -- 2.43.0