linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 John Garry <john.g.garry@oracle.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	 Jing Zhang <renyu.zj@linux.alibaba.com>,
	Thomas Richter <tmricht@linux.ibm.com>,
	 James Clark <james.clark@arm.com>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>,
	 Kajol Jain <kjain@linux.ibm.com>,
	Sandipan Das <sandipan.das@amd.com>,
	 Ravi Bangoria <ravi.bangoria@amd.com>,
	Perry Taylor <perry.taylor@intel.com>,
	 Samantha Alt <samantha.alt@intel.com>,
	Caleb Biggers <caleb.biggers@intel.com>,
	 Weilin Wang <weilin.wang@intel.com>,
	Edward Baker <edward.baker@intel.com>,
	 Stephane Eranian <eranian@google.com>
Subject: [PATCH v3 09/12] perf jevents: Drop duplicate pending metrics
Date: Wed, 13 Mar 2024 22:50:48 -0700	[thread overview]
Message-ID: <20240314055051.1960527-10-irogers@google.com> (raw)
In-Reply-To: <20240314055051.1960527-1-irogers@google.com>

Drop adding a pending metric if there is an existing one.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/jevents.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index f68b0a60cdef..23f9809b3850 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -473,7 +473,7 @@ def add_events_table_entries(item: os.DirEntry, topic: str) -> None:
   for e in read_json_events(item.path, topic):
     if e.name:
       _pending_events.append(e)
-    if e.metric_name:
+    if e.metric_name and not any(e.metric_name == x.metric_name for x in _pending_metrics):
       _pending_metrics.append(e)
 
 
-- 
2.44.0.278.ge034bb2e1d-goog


  parent reply	other threads:[~2024-03-14  5:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  5:50 [PATCH v3 00/12] Foundations for metric generation with Python Ian Rogers
2024-03-14  5:50 ` [PATCH v3 01/12] perf jevents: Allow multiple metricgroups.json files Ian Rogers
2024-03-14  5:50 ` [PATCH v3 02/12] perf jevents: Update metric constraint support Ian Rogers
2024-03-14  5:50 ` [PATCH v3 03/12] perf jevents: Add descriptions to metricgroup abstraction Ian Rogers
2024-03-14  5:50 ` [PATCH v3 04/12] perf jevents: Allow metric groups not to be named Ian Rogers
2024-03-14  5:50 ` [PATCH v3 05/12] perf jevents: Support parsing negative exponents Ian Rogers
2024-03-14  5:50 ` [PATCH v3 06/12] perf jevents: Term list fix in event parsing Ian Rogers
2024-03-14  5:50 ` [PATCH v3 07/12] perf jevents: Add threshold expressions to Metric Ian Rogers
2024-03-14  5:50 ` [PATCH v3 08/12] perf jevents: Move json encoding to its own functions Ian Rogers
2024-03-14  5:50 ` Ian Rogers [this message]
2024-03-14  5:50 ` [PATCH v3 10/12] perf jevents: Skip optional metrics in metric group list Ian Rogers
2024-03-14  5:50 ` [PATCH v3 11/12] perf jevents: Build support for generating metrics from python Ian Rogers
2024-03-14  5:50 ` [PATCH v3 12/12] perf jevents: Add load event json to verify and allow fallbacks Ian Rogers
2024-03-22  2:57   ` kernel test robot
2024-04-19 19:37   ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314055051.1960527-10-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=caleb.biggers@intel.com \
    --cc=edward.baker@intel.com \
    --cc=eranian@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=samantha.alt@intel.com \
    --cc=sandipan.das@amd.com \
    --cc=tmricht@linux.ibm.com \
    --cc=weilin.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).