linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Perry Taylor <perry.taylor@intel.com>,
	Samantha Alt <samantha.alt@intel.com>,
	 Caleb Biggers <caleb.biggers@intel.com>,
	Weilin Wang <weilin.wang@intel.com>,
	 Edward Baker <edward.baker@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	 Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@arm.com>,
	John Garry <john.g.garry@oracle.com>,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Stephane Eranian <eranian@google.com>
Subject: [PATCH v3 04/20] perf jevents: Add CheckPmu to see if a PMU is in loaded json events
Date: Wed, 13 Mar 2024 22:59:03 -0700	[thread overview]
Message-ID: <20240314055919.1979781-5-irogers@google.com> (raw)
In-Reply-To: <20240314055919.1979781-1-irogers@google.com>

CheckPmu can be used to determine if hybrid events are present,
allowing for hybrid conditional metrics/events/pmus to be premised on
the json files rather than hard coded tables.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/metric.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric.py
index 03312cd6d491..e1847cccfdb0 100644
--- a/tools/perf/pmu-events/metric.py
+++ b/tools/perf/pmu-events/metric.py
@@ -8,10 +8,12 @@ import re
 from enum import Enum
 from typing import Dict, List, Optional, Set, Tuple, Union
 
+all_pmus = set()
 all_events = set()
 
 def LoadEvents(directory: str) -> None:
   """Populate a global set of all known events for the purpose of validating Event names"""
+  global all_pmus
   global all_events
   all_events = {
       "context\-switches",
@@ -24,12 +26,18 @@ def LoadEvents(directory: str) -> None:
     filename = os.fsdecode(file)
     if filename.endswith(".json"):
       for x in json.load(open(f"{directory}/{filename}")):
+        if "Unit" in x:
+          all_pmus.add(x["Unit"])
         if "EventName" in x:
           all_events.add(x["EventName"])
         elif "ArchStdEvent" in x:
           all_events.add(x["ArchStdEvent"])
 
 
+def CheckPmu(name: str) -> bool:
+  return name in all_pmus
+
+
 def CheckEvent(name: str) -> bool:
   """Check the event name exists in the set of all loaded events"""
   global all_events
-- 
2.44.0.278.ge034bb2e1d-goog


  parent reply	other threads:[~2024-03-14  5:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  5:58 [PATCH v3 00/20] Python generated Intel metrics Ian Rogers
2024-03-14  5:59 ` [PATCH v3 01/20] perf jevents: Add RAPL metrics for all Intel models Ian Rogers
2024-03-14  5:59 ` [PATCH v3 02/20] perf jevents: Add idle metric for " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 03/20] perf jevents: Add smi metric group " Ian Rogers
2024-03-14  5:59 ` Ian Rogers [this message]
2024-03-14  5:59 ` [PATCH v3 05/20] perf jevents: Add tsx " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 06/20] perf jevents: Add br metric group for branch statistics on Intel Ian Rogers
2024-03-14  5:59 ` [PATCH v3 07/20] perf jevents: Add software prefetch (swpf) metric group for Intel Ian Rogers
2024-03-14  5:59 ` [PATCH v3 08/20] perf jevents: Add ports metric group giving utilization on Intel Ian Rogers
2024-03-14  5:59 ` [PATCH v3 09/20] perf jevents: Add L2 metrics for Intel Ian Rogers
2024-03-14  5:59 ` [PATCH v3 10/20] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 11/20] perf jevents: Add ILP metrics " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 12/20] perf jevents: Add context switch " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 13/20] perf jevents: Add FPU " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 14/20] perf jevents: Add Miss Level Parallelism (MLP) metric " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 15/20] perf jevents: Add mem_bw " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 16/20] perf jevents: Add local/remote "mem" breakdown metrics " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 17/20] perf jevents: Add dir " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 18/20] perf jevents: Add C-State metrics from the PCU PMU " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 19/20] perf jevents: Add local/remote miss latency metrics " Ian Rogers
2024-03-14  5:59 ` [PATCH v3 20/20] perf jevents: Add upi_bw metric " Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314055919.1979781-5-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=caleb.biggers@intel.com \
    --cc=edward.baker@intel.com \
    --cc=eranian@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=samantha.alt@intel.com \
    --cc=weilin.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).