From: Ian Rogers <irogers@google.com>
To: Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Edward Baker <edward.baker@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@arm.com>,
John Garry <john.g.garry@oracle.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: [PATCH v3 08/20] perf jevents: Add ports metric group giving utilization on Intel
Date: Wed, 13 Mar 2024 22:59:07 -0700 [thread overview]
Message-ID: <20240314055919.1979781-9-irogers@google.com> (raw)
In-Reply-To: <20240314055919.1979781-1-irogers@google.com>
The ports metric group contains a metric for each port giving its
utilization as a ratio of cycles. The metrics are created by looking
for UOPS_DISPATCHED.PORT events.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/intel_metrics.py | 32 ++++++++++++++++++++++++--
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events/intel_metrics.py
index b02d0c0c3793..b181574c9486 100755
--- a/tools/perf/pmu-events/intel_metrics.py
+++ b/tools/perf/pmu-events/intel_metrics.py
@@ -1,17 +1,23 @@
#!/usr/bin/env python3
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
from metric import (d_ratio, has_event, max, CheckPmu, Event, JsonEncodeMetric,
- JsonEncodeMetricGroupDescriptions, LoadEvents, Metric,
- MetricGroup, MetricRef, Select)
+ JsonEncodeMetricGroupDescriptions, Literal, LoadEvents,
+ Metric, MetricGroup, MetricRef, Select)
import argparse
import json
import math
import os
+import re
from typing import Optional
# Global command line arguments.
_args = None
interval_sec = Event("duration_time")
+core_cycles = Event("CPU_CLK_UNHALTED.THREAD_P_ANY",
+ "CPU_CLK_UNHALTED.DISTRIBUTED",
+ "cycles")
+# Number of CPU cycles scaled for SMT.
+smt_cycles = Select(core_cycles / 2, Literal("#smt_on"), core_cycles)
def Idle() -> Metric:
cyc = Event("msr/mperf/")
@@ -260,6 +266,27 @@ def IntelBr():
description="breakdown of retired branch instructions")
+def IntelPorts() -> Optional[MetricGroup]:
+ pipeline_events = json.load(open(f"{_args.events_path}/x86/{_args.model}/pipeline.json"))
+
+ metrics = []
+ for x in pipeline_events:
+ if "EventName" in x and re.search("^UOPS_DISPATCHED.PORT", x["EventName"]):
+ name = x["EventName"]
+ port = re.search(r"(PORT_[0-9].*)", name).group(0).lower()
+ if name.endswith("_CORE"):
+ cyc = core_cycles
+ else:
+ cyc = smt_cycles
+ metrics.append(Metric(port, f"{port} utilization (higher is better)",
+ d_ratio(Event(name), cyc), "100%"))
+ if len(metrics) == 0:
+ return None
+
+ return MetricGroup("ports", metrics, "functional unit (port) utilization -- "
+ "fraction of cycles each port is utilized (higher is better)")
+
+
def IntelSwpf() -> Optional[MetricGroup]:
ins = Event("instructions")
try:
@@ -352,6 +379,7 @@ def main() -> None:
Smi(),
Tsx(),
IntelBr(),
+ IntelPorts(),
IntelSwpf(),
])
--
2.44.0.278.ge034bb2e1d-goog
next prev parent reply other threads:[~2024-03-14 5:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 5:58 [PATCH v3 00/20] Python generated Intel metrics Ian Rogers
2024-03-14 5:59 ` [PATCH v3 01/20] perf jevents: Add RAPL metrics for all Intel models Ian Rogers
2024-03-14 5:59 ` [PATCH v3 02/20] perf jevents: Add idle metric for " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 03/20] perf jevents: Add smi metric group " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 04/20] perf jevents: Add CheckPmu to see if a PMU is in loaded json events Ian Rogers
2024-03-14 5:59 ` [PATCH v3 05/20] perf jevents: Add tsx metric group for Intel models Ian Rogers
2024-03-14 5:59 ` [PATCH v3 06/20] perf jevents: Add br metric group for branch statistics on Intel Ian Rogers
2024-03-14 5:59 ` [PATCH v3 07/20] perf jevents: Add software prefetch (swpf) metric group for Intel Ian Rogers
2024-03-14 5:59 ` Ian Rogers [this message]
2024-03-14 5:59 ` [PATCH v3 09/20] perf jevents: Add L2 metrics " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 10/20] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 11/20] perf jevents: Add ILP metrics " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 12/20] perf jevents: Add context switch " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 13/20] perf jevents: Add FPU " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 14/20] perf jevents: Add Miss Level Parallelism (MLP) metric " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 15/20] perf jevents: Add mem_bw " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 16/20] perf jevents: Add local/remote "mem" breakdown metrics " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 17/20] perf jevents: Add dir " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 18/20] perf jevents: Add C-State metrics from the PCU PMU " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 19/20] perf jevents: Add local/remote miss latency metrics " Ian Rogers
2024-03-14 5:59 ` [PATCH v3 20/20] perf jevents: Add upi_bw metric " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314055919.1979781-9-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=edward.baker@intel.com \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).