From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB7714C5B3 for ; Wed, 3 Apr 2024 16:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712162803; cv=none; b=YhpWs2bPsT9AA7YntWBKVZvyBHanlGmrrMihGLNBkKNAKXnxt1xKu+diroMoSaM2Okl/jUhQVkouPZo50ila2jbYxTCmPd39r8y6Kza6RGYGlAsK9b8oczdiPpv2A30mcG6/zAtxthSfifBEV6YBldu5IQpUDL//DjTdKNd3MTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712162803; c=relaxed/simple; bh=Lvj8qthx1cwI8FohJsFz5Fd8TgpulGpsMXGwcZOcLTM=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=MEd+YLPc1R2vGrXPUH6xo6YI8Y6Z9Tj5LcVack66yEHFTZTbA5yNtV34GWEl+P3jJ3FvW+ek5Gh87gFID+diZpAqLXuNgMg1pV0UyPftMXKRGm2qSwdmK55+JC7lzwTVzEneRqFwMB1WOg4phhpet+illqf2IWqvoObBLx6UFgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=0WluMAVa; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="0WluMAVa" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6eab623fdadso6307614b3a.1 for ; Wed, 03 Apr 2024 09:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712162801; x=1712767601; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=BRVtdj0oK10e4j2h20xlPt/xFCKFRdEtGHks2UFPYJg=; b=0WluMAVa8ahifuvBk7rkpb+Yf+Orv4+o/sBJZJXejKTZV3FtM2w2LSY+zO3a67L2TN LB+zzd/vkEknct//Rr7YOOPVYQfzvfHrSgdBFex59qN9+u1KUrNlbZ0CZsfhKFcAvJXJ 27ky7P0V0GXGnRQmrVRWKlS5Xcv1m2OBKJ5ruCHC7kV0yuvfLd9yNLp8GKH3XQXsO85V GVXrFXBR9/uFIgqYhj1r7TjUCL8guUO3M0Z29IcYnyrliMrsxqKFgsjwtlMsjbb/O4pR lKz7uP99uES017zWLUNDWa+9hjNTPHeCla+mCBmJa3KqnzVR62G5tNUttt6VxKDSaDLA jCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712162801; x=1712767601; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BRVtdj0oK10e4j2h20xlPt/xFCKFRdEtGHks2UFPYJg=; b=DNBWUZ62Gqi49CciTBDGRW1Xa/AiqjGCxgl7Y8J8JIOlCfKy+d+jOBOOI8ti7R+eCh dgvHFd51cxblsLx/Kx5jeuNHwEBZv76wBreqYY9rCiASEMEcCJjdrovLd5ja9IJjd2qb I2i/9tuBv2+R/m4dp1u0+Zk2d61dC5mbabZ2i/8dowSi48dOgd4ds4GAgbwwNKk9LbW3 tL1nh1SOBYs3d9diStNgDiEszqQ6NizJJnJpVwhlu4ZvahntWYF3MIoRJakW0PHwoEuK 0MY3XFrbZ0jTrZE+aFb0oa1byyHnSKjxW/k1K2XUSI/Zkc0yO7YBjU0uRl7/vAABE9Dm wxnA== X-Forwarded-Encrypted: i=1; AJvYcCWT78Us7XAJlcB0A7BuiWsqimnM7xThx2NiEYlTvo16FPhXeXIllo7efqvWEGuaTz65Mhkoyztdy/e14CNQFTaCFmSL/UwwFG1sqs4Q/CtOJA== X-Gm-Message-State: AOJu0YzRYn2XCQ66Eq37MoSI+ITmxYm0q9XNUkdeNqMFN7vB7HabaDdi Q6tTRn9c6sxM7jTLRiDBvRzSQca/3hrIo9S4kHBVZ/8S2iffEXf6U8voVoXP7wMu2X0iDmr+EMA qbSHckQ== X-Google-Smtp-Source: AGHT+IGYtD0V2Rk3G0pROazlnGdYtSA1K54+7Vk/W68lWWQ805HcZbk6O4AzOpNO5lCWkXbDSd5k7dp+0AZ6 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:12e:26c0:7a24:6d64]) (user=irogers job=sendgmr) by 2002:a05:6a00:3920:b0:6e7:4a2f:56c0 with SMTP id fh32-20020a056a00392000b006e74a2f56c0mr80pfb.4.1712162801440; Wed, 03 Apr 2024 09:46:41 -0700 (PDT) Date: Wed, 3 Apr 2024 09:46:36 -0700 Message-Id: <20240403164636.3429091-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Subject: [PATCH v1] perf metrics: Remove the "No_group" metric group From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Content-Type: text/plain; charset="UTF-8" Rather than place metrics without a metric group in "No_group" place them in a a metric group that is their name. Still allow such metrics to be selected if "No_group" is passed, this change just impacts perf list. Signed-off-by: Ian Rogers --- tools/perf/util/metricgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 79ef6095ab28..6ec083af14a1 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -455,7 +455,7 @@ static int metricgroup__add_to_mep_groups(const struct pmu_metric *pm, const char *g; char *omg, *mg; - mg = strdup(pm->metric_group ?: "No_group"); + mg = strdup(pm->metric_group ?: pm->metric_name); if (!mg) return -ENOMEM; omg = mg; @@ -466,7 +466,7 @@ static int metricgroup__add_to_mep_groups(const struct pmu_metric *pm, if (strlen(g)) me = mep_lookup(groups, g, pm->metric_name); else - me = mep_lookup(groups, "No_group", pm->metric_name); + me = mep_lookup(groups, pm->metric_name, pm->metric_name); if (me) { me->metric_desc = pm->desc; -- 2.44.0.478.gd926399ef9-goog