Re: [PATCH V2 3/8] perf util: Replace an instance of strtailcmp() by str_has_suffix()

[Masami Hiramatsu (Google) <mhiramat@kernel.org>]

On Mon,  8 Apr 2024 11:52:25 +0530
Chaitanya S Prakash <ChaitanyaS.Prakash@arm.com> wrote:

> From: Chaitanya S Prakash <chaitanyas.prakash@arm.com>
> 
> This particular instance makes use strtailcmp() to check if the "path"
> parameter is a loadable kernel module, it does so by checking if "path"
> is followed by ".ko" suffix. As this use case is more suitable for
> str_has suffix(), replace strtailcmp() with str_has_suffix().
> 
> The other calls to strtailcmp() do not seem equivalent to the
> str_has_suffix() use case. As this function is not being hit in any of
> the tests as well it would be rather risky to replace its use with
> str_has_suffix(). Therefore, those calls are retained as is.
> 
> Signed-off-by: Chaitanya S Prakash <chaitanyas.prakash@arm.com>
> ---
>  tools/perf/util/probe-event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 2a0ad9ecf0a2..59e700170541 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -564,7 +564,7 @@ static struct debuginfo *open_debuginfo(const char *module, struct nsinfo *nsi,
>  	ret = debuginfo__new(path);
>  	if (!ret && !silent) {
>  		pr_warning("The %s file has no debug information.\n", path);
> -		if (!module || !strtailcmp(path, ".ko"))
> +		if (!module || !str_has_suffix(path, ".ko"))

if (!module || str_has_suffix(path, ".ko"))

strtailcmp(a, b) returns 0 (false) if a is end with b. So above condition
checks @module is NULL (== kernel) or @path is end with ".ko" (== module).

Thank you,

>  			pr_warning("Rebuild with CONFIG_DEBUG_INFO=y, ");
>  		else
>  			pr_warning("Rebuild with -g, ");
> -- 
> 2.30.2
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>