From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: [PATCH 1/7] perf annotate-data: Skip sample histogram for stack canary
Date: Wed, 10 Apr 2024 20:32:50 -0700 [thread overview]
Message-ID: <20240411033256.2099646-2-namhyung@kernel.org> (raw)
In-Reply-To: <20240411033256.2099646-1-namhyung@kernel.org>
It's a pseudo data type and has no field.
Fixes: b3c95109c131 ("perf annotate-data: Add stack canary type")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/annotate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 11da27801d88..ec79c120a7d2 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -2399,8 +2399,9 @@ struct annotated_data_type *hist_entry__get_data_type(struct hist_entry *he)
mem_type = find_data_type(&dloc);
if (mem_type == NULL && is_stack_canary(arch, op_loc)) {
- mem_type = &canary_type;
- dloc.type_offset = 0;
+ istat->good++;
+ he->mem_type_off = 0;
+ return &canary_type;
}
if (mem_type)
--
2.44.0.478.gd926399ef9-goog
next prev parent reply other threads:[~2024-04-11 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:32 [PATCHSET 0/7] perf annotate: Add TUI support for data type profiling (v2) Namhyung Kim
2024-04-11 3:32 ` Namhyung Kim [this message]
2024-04-11 3:32 ` [PATCH 2/7] perf annotate: Show progress of sample processing Namhyung Kim
2024-04-11 3:32 ` [PATCH 3/7] perf annotate-data: Add hist_entry__annotate_data_tty() Namhyung Kim
2024-04-11 3:32 ` [PATCH 4/7] perf annotate-data: Add hist_entry__annotate_data_tui() Namhyung Kim
2024-04-11 3:32 ` [PATCH 5/7] perf annotate-data: Support event group display in TUI Namhyung Kim
2024-04-11 3:32 ` [PATCH 6/7] perf report: Add a menu item to annotate data type " Namhyung Kim
2024-04-11 3:32 ` [PATCH 7/7] perf report: Do not collect sample histogram unnecessarily Namhyung Kim
2024-04-11 11:02 ` [PATCHSET 0/7] perf annotate: Add TUI support for data type profiling (v2) Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411033256.2099646-2-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).