From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>
Subject: [RFC PATCH v5 12/16] perf stat: Handle NMI in hardware-grouping
Date: Fri, 12 Apr 2024 14:07:52 -0700 [thread overview]
Message-ID: <20240412210756.309828-13-weilin.wang@intel.com> (raw)
In-Reply-To: <20240412210756.309828-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
Add an easy nmi watchdog support in grouping. When nmi watchdog is enabled,
we reduce the total num of events could be assigned to one group by 1. A
more efficient solution will be added in later.
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
tools/perf/util/metricgroup.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 9548654c9f6d..31036035484c 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -1993,6 +1993,10 @@ static int insert_new_group(struct list_head *head,
size_t counters_num_fixed)
{
INIT_LIST_HEAD(&new_group->event_head);
+ if (sysctl__nmi_watchdog_enabled()) {
+ pr_debug("NMI watchdog is enabled. Reduce num of counters by 1\n");
+ counters_num_gp -= 1;
+ }
fill_counter_bitmap(new_group->gp_counters, 0, counters_num_gp);
fill_counter_bitmap(new_group->fixed_counters, 0, counters_num_fixed);
list_add_tail(&new_group->nd, head);
--
2.42.0
next prev parent reply other threads:[~2024-04-12 21:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 21:07 [RFC PATCH v5 00/16] Perf stat metric grouping with hardware information weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 01/16] perf stat: Add new field in stat_config to enable hardware aware grouping weilin.wang
2024-04-17 3:49 ` Ian Rogers
2024-04-17 16:21 ` Arnaldo Carvalho de Melo
2024-04-12 21:07 ` [RFC PATCH v5 02/16] perf stat: Add basic functions for the " weilin.wang
2024-04-17 4:56 ` Ian Rogers
2024-04-17 16:24 ` Arnaldo Carvalho de Melo
2024-04-12 21:07 ` [RFC PATCH v5 03/16] perf pmu-events: Add functions in jevent.py to parse counter and event info for " weilin.wang
2024-04-17 5:42 ` Ian Rogers
2024-04-12 21:07 ` [RFC PATCH v5 04/16] find_bit: add _find_last_and_bit() to support finding the most significant set bit weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 05/16] perf stat: Add functions to set counter bitmaps for hardware-grouping method weilin.wang
2024-04-17 5:35 ` Ian Rogers
2024-04-12 21:07 ` [RFC PATCH v5 06/16] perf stat: Add functions to get counter info weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 07/16] perf stat: Add functions to create new group and assign events into groups weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 08/16] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2024-04-17 5:56 ` Ian Rogers
2024-04-12 21:07 ` [RFC PATCH v5 09/16] perf stat: Add function to handle special events " weilin.wang
2024-04-17 6:12 ` Ian Rogers
2024-04-12 21:07 ` [RFC PATCH v5 10/16] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 11/16] perf stat: Add partial support on MSR in hardware-grouping weilin.wang
2024-04-12 21:07 ` weilin.wang [this message]
2024-04-12 21:07 ` [RFC PATCH v5 13/16] perf stat: Code refactoring " weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 14/16] perf stat: Add tool events support " weilin.wang
2024-04-12 21:07 ` [RFC PATCH v5 15/16] perf stat: use tool event helper function in metricgroup__build_event_string weilin.wang
2024-04-17 6:36 ` Ian Rogers
2024-04-12 21:07 ` [RFC PATCH v5 16/16] perf stat: Add hardware-grouping cmd option to perf stat weilin.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412210756.309828-13-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).