linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yabin Cui <yabinc@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Yabin Cui <yabinc@google.com>
Subject: [PATCH] perf/core: Trim dyn_size if raw data is absent
Date: Thu, 25 Apr 2024 15:05:09 -0700	[thread overview]
Message-ID: <20240425220509.1751260-1-yabinc@google.com> (raw)

Currently, perf_tp_event() always allocates space for raw sample data,
even when the PERF_SAMPLE_RAW flag is not set. This leads to unused
spaces within generated sample records.

This patch reduces dyn_size when PERF_SAMPLE_RAW is not present,
ensuring sample records use only the necessary amount of space.

Fixes: 0a9081cf0a11 ("perf/core: Add perf_sample_save_raw_data() helper")
Signed-off-by: Yabin Cui <yabinc@google.com>
---
 kernel/events/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 724e6d7e128f..d68ecdc264d3 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7688,6 +7688,10 @@ void perf_prepare_sample(struct perf_sample_data *data,
 		data->raw = NULL;
 		data->dyn_size += sizeof(u64);
 		data->sample_flags |= PERF_SAMPLE_RAW;
+	} else if ((data->sample_flags & ~sample_type) & PERF_SAMPLE_RAW) {
+		data->dyn_size -= data->raw->size + sizeof(u32);
+		data->raw = NULL;
+		data->sample_flags &= ~PERF_SAMPLE_RAW;
 	}
 
 	if (filtered_sample_type & PERF_SAMPLE_BRANCH_STACK) {
-- 
2.44.0.769.g3c40516874-goog


             reply	other threads:[~2024-04-25 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 22:05 Yabin Cui [this message]
2024-04-29 21:59 ` [PATCH] perf/core: Trim dyn_size if raw data is absent Namhyung Kim
2024-05-02  0:10   ` Yabin Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240425220509.1751260-1-yabinc@google.com \
    --to=yabinc@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).