From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC8416D4EA for ; Tue, 7 May 2024 18:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715106969; cv=none; b=pGj8B/slIpoZcuMj/LWVemVw8XXVLM24HfCRFDOe3AhzUHX/siiBnh0cQ1GN/A3AIlhhYARgDbgAEQKHsOyTlcMCYaqWQO5GLqlFVSr2ssx+sKYsH+XPQJ3zL6DUj7l94mJd7RrwnnXkl3WGZjuFXhGjUO8q5BowYpnWlCc2zb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715106969; c=relaxed/simple; bh=9HuNi58CVXO3IUVCTHfvsKQGxGInbQe5AluYnPVppJE=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=ZJB+LD+szH9yTYHWHddUSr/IqlcopAfixP4jhcQft9Ui6g7o+Zak93qdvgt41EeVNJk7fIwc/mvQbK6DwR2EToL3FSnkbY55yvAy/1GDYFWdTrOUZ+3IktSdiHsWN5DeoZaofhqbpJMpqKO6Vp9oxlb0/yucowScr7ekSe3MP20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K0A7M5f3; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K0A7M5f3" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-61e0949fc17so65867547b3.0 for ; Tue, 07 May 2024 11:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715106966; x=1715711766; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=A1AQvN6jvvxnFiXuFjevdmwJtIquwWKLlnmIOD84P5w=; b=K0A7M5f3fh92ljKD5TmLn7OQJh3155ttieC/tNXUHnZ5b1KxlRmsgIemIaAXzd5Q7g Av608r1PmyJPDI15yc5hRxdSqX+/sYH7S3hCTgEvPvGZkoCER0/Uz9xorXPHHPx85L2g 1Xi8hkVqZ3PMZL4w1IqExZ1ji2hgndIBHtBluWDDzI84ZqxTyXf1eR+OxlCrS7u3meVj 1kzQXLGglv5dEOq2P0Rca+p6fnoXPP7VEvB0r51ADv/Vz9kYiSKHT+tF6eQTwJRcceXe FbP9eAmmcYiGr2Egqa0lHO99ZfnQGcL8Rm45BMpVyJaA6kGcLglfeyoLaIz3wvj8pYM0 1adQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715106966; x=1715711766; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A1AQvN6jvvxnFiXuFjevdmwJtIquwWKLlnmIOD84P5w=; b=WNsiOz6qAWCq/qweuwUe6yj8rBCBkzI3ZvRdvyS3Fk5B2quyUBl93BAASAQNf3vsed qrfLUH6fQ8bMLyJfWdc1MCDl6CjUlGW8Bx5EYNs0Mvj8ZBzXEcE015OSDT3bI7zErXQ5 M0Lcaf8k6twxhxxnDydGpY/uY1CxFZTX6Y/RhbOpRFjqTXQ4V2cBGQyCOkYOwlTLC6sx /Hw1J8oFARM8aGLbGR7xmRLS2KSaZclJyy+RyatE/oRS9bga6v4zJztfoapplygY+nv8 OJa/eDFldsDE40j7/72K5+zYCtgjPbcUF6NjkXl2ALIymx0ulVPa7vNVq0Wp/DeWr1fb YYiA== X-Forwarded-Encrypted: i=1; AJvYcCViv+vQh1jPbm3kYGFFbYVckgr0zy5dMVVifvllYaoTEeInOy8qe8zu4NXw8FBce/NzxPhL7T+myIENQqpYRvES8Pn+aXktutPof4CdwYG3lQ== X-Gm-Message-State: AOJu0YyFNt/lSp8LFW8o6KPly8T3HpEwN6v9o1sYczD5OCllyZvZlP3z Fka03PPVgLqB7gi/3Swu36Hdumhp25mJ2uaMsiug+B4sQy/tdfIQXRSeOd2iWLyxU0emT9U8jR/ zMo/ErA== X-Google-Smtp-Source: AGHT+IGed/Y+GDst8JT+LvB/MbmpsU6swCAmc9AG+SfItDHq2erYw18Mb6CqYUAWqsNpndsK5G3uDW4aq8/Z X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:8095:fd7:9773:b1df]) (user=irogers job=sendgmr) by 2002:a0d:e249:0:b0:61a:d161:ff8a with SMTP id 00721157ae682-62085a37c0amr1273937b3.1.1715106965862; Tue, 07 May 2024 11:36:05 -0700 (PDT) Date: Tue, 7 May 2024 11:35:38 -0700 In-Reply-To: <20240507183545.1236093-1-irogers@google.com> Message-Id: <20240507183545.1236093-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240507183545.1236093-1-irogers@google.com> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog Subject: [PATCH v1 1/8] perf ui browser: Don't save pointer to stack memory From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Oliver Upton , James Clark , Tim Chen , Yicong Yang , K Prateek Nayak , Yanteng Si , Sun Haiyong , Kajol Jain , Ravi Bangoria , Li Dong , Paran Lee , Ben Gainey , Andi Kleen , Athira Rajeev , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ui_browser__show is capturing the input title that is stack allocated memory in hist_browser__run. Avoid a use after return by strdup-ing the string. Fixes: 05e8b0804ec4 ("perf ui browser: Stop using 'self'") Signed-off-by: Ian Rogers --- tools/perf/ui/browser.c | 4 +++- tools/perf/ui/browser.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 603d11283cbd..c4cdf2ea69b7 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -287,7 +287,8 @@ int ui_browser__show(struct ui_browser *browser, const char *title, mutex_lock(&ui__lock); __ui_browser__show_title(browser, title); - browser->title = title; + free(browser->title); + browser->title = strdup(title); zfree(&browser->helpline); va_start(ap, helpline); @@ -304,6 +305,7 @@ void ui_browser__hide(struct ui_browser *browser) mutex_lock(&ui__lock); ui_helpline__pop(); zfree(&browser->helpline); + zfree(&browser->title); mutex_unlock(&ui__lock); } diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h index 510ce4554050..6e98d5f8f71c 100644 --- a/tools/perf/ui/browser.h +++ b/tools/perf/ui/browser.h @@ -21,7 +21,7 @@ struct ui_browser { u8 extra_title_lines; int current_color; void *priv; - const char *title; + char *title; char *helpline; const char *no_samples_msg; void (*refresh_dimensions)(struct ui_browser *browser); -- 2.45.0.rc1.225.g2a3ae87e7f-goog