From: weilin.wang@intel.com
To: weilin.wang@intel.com, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Perry Taylor <perry.taylor@intel.com>,
Samantha Alt <samantha.alt@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>
Subject: [RFC PATCH v8 4/7] perf stat: Add retire latency values into the expr_parse_ctx to prepare for final metric calculation
Date: Wed, 15 May 2024 01:44:26 -0400 [thread overview]
Message-ID: <20240515054443.2824147-5-weilin.wang@intel.com> (raw)
In-Reply-To: <20240515054443.2824147-1-weilin.wang@intel.com>
From: Weilin Wang <weilin.wang@intel.com>
Retire latency values of events are used in metric formulas. This update adds
code to process data from perf record for required retire latency values.
Signed-off-by: Weilin Wang <weilin.wang@intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/stat-shadow.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 3466aa952442..b97d23bfeac1 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -15,6 +15,7 @@
#include <linux/zalloc.h>
#include "iostat.h"
#include "util/hashmap.h"
+#include "util/intel-tpebs.h"
struct stats walltime_nsecs_stats;
struct rusage_stats ru_stats;
@@ -355,6 +356,20 @@ static void print_nsecs(struct perf_stat_config *config,
print_metric(config, ctxp, NULL, NULL, "CPUs utilized", 0);
}
+static int prepare_retire_lat(struct expr_parse_ctx *pctx,
+ struct list_head *retire_lats)
+{
+ int ret = 0;
+ struct tpebs_retire_lat *t;
+
+ list_for_each_entry(t, retire_lats, nd) {
+ ret = expr__add_id_val(pctx, strdup(t->tpebs_name), t->val);
+ if (ret < 0)
+ return ret;
+ }
+ return ret;
+}
+
static int prepare_metric(const struct metric_expr *mexp,
const struct evsel *evsel,
struct expr_parse_ctx *pctx,
@@ -369,6 +384,9 @@ static int prepare_metric(const struct metric_expr *mexp,
double val;
int source_count = 0;
+ if (metric_events[i]->retire_lat)
+ continue;
+
if (evsel__is_tool(metric_events[i])) {
struct stats *stats;
double scale;
@@ -486,6 +504,11 @@ static void generic_metric(struct perf_stat_config *config,
pctx->sctx.user_requested_cpu_list = strdup(config->user_requested_cpu_list);
pctx->sctx.runtime = runtime;
pctx->sctx.system_wide = config->system_wide;
+ i = prepare_retire_lat(pctx, &config->tpebs_results);
+ if (i < 0) {
+ expr__ctx_free(pctx);
+ return;
+ }
i = prepare_metric(mexp, evsel, pctx, aggr_idx);
if (i < 0) {
expr__ctx_free(pctx);
--
2.43.0
next prev parent reply other threads:[~2024-05-15 5:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 5:44 [RFC PATCH v8 0/7] TPEBS counting mode support weilin.wang
2024-05-15 5:44 ` [RFC PATCH v8 1/7] perf Document: Add TPEBS to Documents weilin.wang
2024-05-16 16:10 ` Ian Rogers
2024-05-16 17:37 ` Wang, Weilin
2024-05-17 21:28 ` Namhyung Kim
2024-05-15 5:44 ` [RFC PATCH v8 2/7] perf data: Allow to use given fd in data->file.fd weilin.wang
2024-05-16 16:11 ` Ian Rogers
2024-05-15 5:44 ` [RFC PATCH v8 3/7] perf stat: Fork and launch perf record when perf stat needs to get retire latency value for a metric weilin.wang
2024-05-16 16:43 ` Ian Rogers
2024-05-16 17:38 ` Wang, Weilin
2024-05-16 18:07 ` Ian Rogers
2024-05-16 18:16 ` Wang, Weilin
2024-05-17 21:43 ` Namhyung Kim
2024-05-17 21:57 ` Wang, Weilin
2024-05-21 0:10 ` Wang, Weilin
2024-05-21 5:42 ` Namhyung Kim
2024-05-21 16:23 ` Wang, Weilin
2024-05-15 5:44 ` weilin.wang [this message]
2024-05-16 16:44 ` [RFC PATCH v8 4/7] perf stat: Add retire latency values into the expr_parse_ctx to prepare for final metric calculation Ian Rogers
2024-05-15 5:44 ` [RFC PATCH v8 5/7] perf stat: Add retire latency print functions to print out at the very end of print out weilin.wang
2024-05-16 16:47 ` Ian Rogers
2024-05-16 17:51 ` Wang, Weilin
2024-05-16 18:08 ` Ian Rogers
2024-05-15 5:44 ` [RFC PATCH v8 6/7] perf vendor events intel: Add MTL metric json files weilin.wang
2024-05-16 16:57 ` Ian Rogers
2024-05-16 17:44 ` Wang, Weilin
2024-05-15 5:44 ` [RFC PATCH v8 7/7] perf stat: Skip read retire_lat counters and plugin retire_lat data from sampled data weilin.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515054443.2824147-5-weilin.wang@intel.com \
--to=weilin.wang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).