From: yskelg@gmail.com
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Austin Kim <austindh.kim@gmail.com>,
shjy180909@gmail.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, Yunseong Kim <yskelg@gmail.com>
Subject: [PATCH] buitin-kvm: Update cmd_kvm() to check perf_host value
Date: Thu, 16 May 2024 04:52:53 +0900 [thread overview]
Message-ID: <20240515195252.75909-1-yskelg@gmail.com> (raw)
From: Yunseong Kim <yskelg@gmail.com>
According to perf-kvm.txt, the default operation is --guest, meaning
perf_host should be set to false and perf_guest to true. Currently,
the incorrect usage of --no-host and --no-guest still results in
the default --guest operation.
This patch updates the usage messages to include the --no-guest option
for those who only want host data, as well as the --no-host and
--no-guest case.
Signed-off-by: Yunseong Kim <yskelg@gmail.com>
---
tools/perf/builtin-kvm.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 71165036e4ca..654a07658cdd 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -2129,7 +2129,7 @@ int cmd_kvm(int argc, const char **argv)
OPT_BOOLEAN(0, "guest", &perf_guest,
"Collect guest os data"),
OPT_BOOLEAN(0, "host", &perf_host,
- "Collect host os data"),
+ "Collect host os data. Host only with --host --no-guest"),
OPT_STRING(0, "guestmount", &symbol_conf.guestmount, "directory",
"guest mount directory under which every guest os"
" instance has a subdir"),
@@ -2150,16 +2150,23 @@ int cmd_kvm(int argc, const char **argv)
"buildid-list", "stat", NULL };
const char *kvm_usage[] = { NULL, NULL };
- perf_host = 0;
- perf_guest = 1;
+ /*
+ * tools/perf/Documentation/perf-kvm.txt
+ *
+ * Default('') -> perf.data.guest
+ * --host -> perf.data.kvm
+ * --guest -> perf.data.guest
+ * --host --guest -> perf.data.kvm
+ * --host --no-guest -> perf.data.host
+ */
+ perf_host = false;
+ perf_guest = true;
argc = parse_options_subcommand(argc, argv, kvm_options, kvm_subcommands, kvm_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
- if (!argc)
+ if (!argc || (!perf_host && !perf_guest))
usage_with_options(kvm_usage, kvm_options);
- if (!perf_host)
- perf_guest = 1;
if (!file_name) {
file_name = get_filename_for_perf_kvm();
--
2.34.1
next reply other threads:[~2024-05-15 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 19:52 yskelg [this message]
2024-05-23 4:23 ` [PATCH] buitin-kvm: Update cmd_kvm() to check perf_host value Namhyung Kim
2024-05-27 6:12 ` Yunseong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515195252.75909-1-yskelg@gmail.com \
--to=yskelg@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=austindh.kim@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=shjy180909@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).