From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6467C8120F; Fri, 31 May 2024 05:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717135120; cv=none; b=F6iTlqyWxakhEwOOL8x9eS654k04Hbg+riTYg+Ttt3/s3Jjy2q/HAm2Lx1eAXr6CB/9sdUTxwfGoKPD/GmOxRjv+JZ3fkd1FkkCv5VMpe0mr1Ma2ZGxelZh4alFms6wp2iecj1BlDY8XK7Q/1mkn2ZwGBe0/9DAxm8pfo3k6fiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717135120; c=relaxed/simple; bh=r4iClqXS7ZCDO2ydoH5swQyMBUzDbd37DyjB2FNs5L8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V8cxESktDUaybEF59+docd1yWTsa+ihS9CKmKt4XcIOeR1snUsmS04P7soQX43Cwsu89NghjCZTeaugmVwMWRcHlB+gJFcorlOtsGH0CzcpKeusTNLYYCzEHNztHRm6uIKD9nCzZoWgD7B5SjtuAN3qebakB4Rl1lq6Ma2l4Bz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iH/zDonP; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iH/zDonP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717135119; x=1748671119; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r4iClqXS7ZCDO2ydoH5swQyMBUzDbd37DyjB2FNs5L8=; b=iH/zDonPd/IPB1ehT5JIBzUSPyaDCfqlgplRfnBKRUV9fFegC/mi3dn5 wtLyk6B0Sr9wDRZISyxtmP4XoqC0DT5S5mwPIpsTY47HloBUZHWDcx9p5 fGx8zsm8dkdLk70PrpzXZTN1IUFS37Ih/kpLZaUcOKqFUUX6gBzLF7CXE yGb+Kyi1NRM7BuXTcb4bObldnuvu3tBv7ESQBavEoYuW0mxTO9M7dZsXA Lew+ZLGdf+54eewO7PmAj3iRdIP7xa3QjhqWnewNvB4st7pnq1BvR6EWc Fo6L0WsDAy116WPLAlgfnD7sHsrO3xDHRR8YpXedhFtchsyahp0cpjIru g==; X-CSE-ConnectionGUID: YtxQKB26R+mpCpYsiDmDog== X-CSE-MsgGUID: qNFIYa+pTWmlYaL7FrGdCA== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="25068280" X-IronPort-AV: E=Sophos;i="6.08,203,1712646000"; d="scan'208";a="25068280" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 22:58:39 -0700 X-CSE-ConnectionGUID: ED6sFlj6S/CWVJI4O0y/hg== X-CSE-MsgGUID: 8eAaUlSKS42ooochBT9VkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,203,1712646000"; d="scan'208";a="40510963" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO localhost.localdomain) ([10.246.41.28]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 22:58:35 -0700 From: Adrian Hunter To: Peter Zijlstra Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH V7 09/12] perf tools: Add missing_features for aux_start_paused, aux_pause, aux_resume Date: Fri, 31 May 2024 08:57:28 +0300 Message-Id: <20240531055731.12541-10-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240531055731.12541-1-adrian.hunter@intel.com> References: <20240531055731.12541-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit Display "feature is not supported" error message if aux_start_paused, aux_pause or aux_resume result in a perf_event_open() error. Signed-off-by: Adrian Hunter Acked-by: Ian Rogers Reviewed-by: Andi Kleen --- tools/perf/util/evsel.c | 10 +++++++++- tools/perf/util/evsel.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 297e3a0bcf82..11141daad4bd 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1896,7 +1896,13 @@ bool evsel__detect_missing_features(struct evsel *evsel) * Must probe features in the order they were added to the * perf_event_attr interface. */ - if (!perf_missing_features.branch_counters && + if (!perf_missing_features.aux_pause_resume && + (evsel->core.attr.aux_pause || evsel->core.attr.aux_resume || + evsel->core.attr.aux_start_paused)) { + perf_missing_features.aux_pause_resume = true; + pr_debug2_peo("Kernel has no aux_pause/aux_resume support, bailing out\n"); + return false; + } else if (!perf_missing_features.branch_counters && (evsel->core.attr.branch_sample_type & PERF_SAMPLE_BRANCH_COUNTERS)) { perf_missing_features.branch_counters = true; pr_debug2("switching off branch counters support\n"); @@ -3095,6 +3101,8 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target, return scnprintf(msg, size, "clockid feature not supported."); if (perf_missing_features.clockid_wrong) return scnprintf(msg, size, "wrong clockid (%d).", clockid); + if (perf_missing_features.aux_pause_resume) + return scnprintf(msg, size, "The 'aux_pause / aux_resume' feature is not supported, update the kernel."); if (perf_missing_features.aux_output) return scnprintf(msg, size, "The 'aux_output' feature is not supported, update the kernel."); if (!target__has_cpu(target)) diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 375a38e15cd9..338dd76ba332 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -192,6 +192,7 @@ struct perf_missing_features { bool weight_struct; bool read_lost; bool branch_counters; + bool aux_pause_resume; }; extern struct perf_missing_features perf_missing_features; -- 2.34.1