* [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
@ 2024-06-02 0:07 linux
2024-06-03 8:31 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: linux @ 2024-06-02 0:07 UTC (permalink / raw)
To: yangyicong, jonathan.cameron, peterz, mingo, jolsa, irogers
Cc: linux-perf-users, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
tools/perf/util/hisi-ptt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
u32 pmu_type;
};
-struct hisi_ptt_queue {
- struct hisi_ptt *ptt;
- struct auxtrace_buffer *buffer;
-};
-
static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
{
uint32_t head = *(uint32_t *)buf;
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
2024-06-02 0:07 [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue' linux
@ 2024-06-03 8:31 ` Jonathan Cameron
2024-06-03 16:31 ` Ian Rogers
2024-06-06 17:11 ` Namhyung Kim
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-06-03 8:31 UTC (permalink / raw)
To: linux
Cc: yangyicong, peterz, mingo, jolsa, irogers, linux-perf-users,
linux-kernel
On Sun, 2 Jun 2024 01:07:09 +0100
linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
by which I mean I searched for it and indeed found only this definition.
> ---
> tools/perf/util/hisi-ptt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
> u32 pmu_type;
> };
>
> -struct hisi_ptt_queue {
> - struct hisi_ptt *ptt;
> - struct auxtrace_buffer *buffer;
> -};
> -
> static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
> {
> uint32_t head = *(uint32_t *)buf;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
2024-06-02 0:07 [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue' linux
2024-06-03 8:31 ` Jonathan Cameron
@ 2024-06-03 16:31 ` Ian Rogers
2024-06-06 17:11 ` Namhyung Kim
2 siblings, 0 replies; 4+ messages in thread
From: Ian Rogers @ 2024-06-03 16:31 UTC (permalink / raw)
To: linux
Cc: yangyicong, jonathan.cameron, peterz, mingo, jolsa,
linux-perf-users, linux-kernel
On Sat, Jun 1, 2024 at 5:07 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi/thanks David,
Reviewed-by: Ian Rogers <irogers@google.com>
Ian
> ---
> tools/perf/util/hisi-ptt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
> u32 pmu_type;
> };
>
> -struct hisi_ptt_queue {
> - struct hisi_ptt *ptt;
> - struct auxtrace_buffer *buffer;
> -};
> -
> static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
> {
> uint32_t head = *(uint32_t *)buf;
> --
> 2.45.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
2024-06-02 0:07 [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue' linux
2024-06-03 8:31 ` Jonathan Cameron
2024-06-03 16:31 ` Ian Rogers
@ 2024-06-06 17:11 ` Namhyung Kim
2 siblings, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2024-06-06 17:11 UTC (permalink / raw)
To: yangyicong, jonathan.cameron, peterz, mingo, jolsa, irogers,
linux
Cc: linux-perf-users, linux-kernel
On Sun, 02 Jun 2024 01:07:09 +0100, linux@treblig.org wrote:
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-06 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-02 0:07 [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue' linux
2024-06-03 8:31 ` Jonathan Cameron
2024-06-03 16:31 ` Ian Rogers
2024-06-06 17:11 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).