linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Changbin Du <changbin.du@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	<linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
	Changbin Du <changbin.du@huawei.com>
Subject: [PATCH 0/2] perf: support specify vdso path in cmdline
Date: Thu, 13 Jun 2024 14:35:08 +0800	[thread overview]
Message-ID: <20240613063510.348692-1-changbin.du@huawei.com> (raw)

The vdso dumped from process memory (in buildid-cache) lacks debugging
info. To annotate vdso symbols with source lines we need specify a
debugging version.

For x86, we can find them from your local build as
arch/x86/entry/vdso/vdso{32,64}.so.dbg. Or they may resides in
/lib/modules/<version>/vdso/vdso{32,64}.so on Ubuntu. But notice that the
builid has to match.

$ sudo perf record -a
$ sudo perf report --objdump=llvm-objdump \
      --vdso arch/x86/entry/vdso/vdso64.so.dbg,arch/x86/entry/vdso/vdso32.so.dbg

Samples: 17K of event 'cycles:P', 4000 Hz, Event count (approx.): 1760
__vdso_clock_gettime  /work/linux-host/arch/x86/entry/vdso/vdso64.so.d
Percent│       movq    -48(%rbp),%rsi                                ▒
       │       testq   %rax,%rax                                     ▒
       │     ;               return vread_hvclock();                 ▒
       │       movq    %rax,%rdx                                     ▒
       │     ;               if (unlikely(!vdso_cycles_ok(cycles)))  ▒
       │     ↑ js      eb                                            ▒
       │     ↑ jmp     74                                            ▒
       │     ;               ts->tv_sec = vdso_ts->sec;              ▒
  0.02 │147:   leaq    2(%rbx),%rax                                  ▒
       │       shlq    $4, %rax                                      ▒
       │       addq    %r10,%rax                                     ▒
       │     ;               while ((seq = READ_ONCE(vd->seq)) & 1) {▒
  9.38 │152:   movl    (%r10),%ecx                                   ▒


When doing cross platform analysis, we also need specify the vdso path if
we are interested in its symbols.

Changbin Du (2):
  perf: support specify vdso path in cmdline
  perf: disasm: prefer symsrc_filename for filename

 tools/perf/builtin-annotate.c |  2 +
 tools/perf/builtin-c2c.c      |  2 +
 tools/perf/builtin-inject.c   |  2 +
 tools/perf/builtin-report.c   |  2 +
 tools/perf/builtin-script.c   |  2 +
 tools/perf/builtin-top.c      |  2 +
 tools/perf/util/disasm.c      |  5 +++
 tools/perf/util/symbol.c      | 82 ++++++++++++++++++++++++++++++++++-
 tools/perf/util/symbol_conf.h |  5 +++
 9 files changed, 102 insertions(+), 2 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-06-13  6:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13  6:35 Changbin Du [this message]
2024-06-13  6:35 ` [PATCH 1/2] perf: support specify vdso path in cmdline Changbin Du
2024-06-13  8:23   ` Adrian Hunter
2024-06-13  9:49     ` duchangbin
2024-06-13 10:19       ` Adrian Hunter
2024-06-14  3:55         ` duchangbin
2024-06-13  6:35 ` [PATCH 2/2] perf: disasm: prefer symsrc_filename for filename Changbin Du
2024-06-13  8:15   ` Adrian Hunter
2024-06-13  9:43     ` duchangbin
2024-06-13 10:26       ` Adrian Hunter
2024-06-14  3:48         ` duchangbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613063510.348692-1-changbin.du@huawei.com \
    --to=changbin.du@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).