From: Jinjie Ruan <ruanjinjie@huawei.com>
To: <linux@armlinux.org.uk>, <will@kernel.org>,
<mark.rutland@arm.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>, <namhyung@kernel.org>,
<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
<irogers@google.com>, <adrian.hunter@intel.com>,
<kan.liang@linux.intel.com>, <arnd@arndb.de>, <afd@ti.com>,
<akpm@linux-foundation.org>, <rmk+kernel@armlinux.org.uk>,
<linus.walleij@linaro.org>, <eric.devolder@oracle.com>,
<robh@kernel.org>, <ardb@kernel.org>, <broonie@kernel.org>,
<lihuafei1@huawei.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH 1/2] ARM: 9258/1: Fix callchain_trace() return value
Date: Tue, 18 Jun 2024 11:26:19 +0800 [thread overview]
Message-ID: <20240618032620.2445395-2-ruanjinjie@huawei.com> (raw)
In-Reply-To: <20240618032620.2445395-1-ruanjinjie@huawei.com>
perf_callchain_store() return 0 on success, -1 otherwise, fix
callchain_trace() to return correct bool value. So walk_stackframe() can
have a chance to stop walking the stack ahead.
Fixes: 70ccc7c0667b ("ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
arch/arm/kernel/perf_callchain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/kernel/perf_callchain.c b/arch/arm/kernel/perf_callchain.c
index 7147edbe56c6..1d230ac9d0eb 100644
--- a/arch/arm/kernel/perf_callchain.c
+++ b/arch/arm/kernel/perf_callchain.c
@@ -85,8 +85,7 @@ static bool
callchain_trace(void *data, unsigned long pc)
{
struct perf_callchain_entry_ctx *entry = data;
- perf_callchain_store(entry, pc);
- return true;
+ return perf_callchain_store(entry, pc) == 0;
}
void
--
2.34.1
next prev parent reply other threads:[~2024-06-18 3:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 3:26 [PATCH 0/2] ARM: 9259/1: stacktrace: Add USER_STACKTRACE support Jinjie Ruan
2024-06-18 3:26 ` Jinjie Ruan [this message]
2024-06-26 9:50 ` [PATCH 1/2] ARM: 9258/1: Fix callchain_trace() return value Linus Walleij
2024-06-27 7:14 ` Jinjie Ruan
2024-06-18 3:26 ` [PATCH 2/2] ARM: 9259/1: stacktrace: Add USER_STACKTRACE support Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618032620.2445395-2-ruanjinjie@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=eric.devolder@oracle.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=lihuafei1@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).