From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649AA1F95A for ; Wed, 19 Jun 2024 15:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718810232; cv=none; b=ZxvCjDBxybF3cnRXzzX2cgxWlytBUoqwBcS2DePy1pZiUO7200/2bUd26SXDOag4wJHs/xUiJsg2xJGdFD1XGVWaWos05bE1YEzQoDEMZepxyFejLlll3oVufPq1yIHqf2ibiQQOhjWFawRvTw51WlBG4xQ0GilkCBHawwAyueQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718810232; c=relaxed/simple; bh=hgEb586LrO9KPIUgZrYV++LUVTqkU6h8UN3b41kMY14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jpi8IWKb6WrmzNE+F7ve2WynL0KtSWNV3xDzCyQOTh1F6GQqDJsKRT+AP8kmIvq1tgih8NbMt0a/Ssq0C77Zl2eP1g68mj2dLZSexD7aJNpgsvCcKr3X3tYhDXYyo1E5OO6c0tl/3FZGhFK3fBtq9ihC/z34SIaiQxFJyaPbljc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dnB8NUuN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dnB8NUuN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718810230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gC7WNA1QA+YwkrX8gjXlglJDeCpaBidYafu3xduhGfM=; b=dnB8NUuNvVrcYPoceYP9IKrQ3EUQGbOkuOj/ClFnpgiHxUDyCNigWXTjFxMb47WxxQj/T7 0xrB1HwVsXyiCl7ulsB3tDqLBDu6yM+7jU86eJqJlclsbwNFi0JdyOKKKoFTWitpIJwquO hv/9MpJQvsGhlu0zOyqMLAZ+vCS6ii0= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-xiTvddoYPcSYiaLGHLgSeQ-1; Wed, 19 Jun 2024 11:17:04 -0400 X-MC-Unique: xiTvddoYPcSYiaLGHLgSeQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09CA41955E82; Wed, 19 Jun 2024 15:17:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.168]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 5D1551956087; Wed, 19 Jun 2024 15:16:56 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 19 Jun 2024 17:15:30 +0200 (CEST) Date: Wed, 19 Jun 2024 17:15:24 +0200 From: Oleg Nesterov To: Tiezhu Yang Cc: Will Deacon , Mark Rutland , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: hw_breakpoint: Save privilege of access control via ptrace Message-ID: <20240619151524.GB24240@redhat.com> References: <20240618071010.11214-1-yangtiezhu@loongson.cn> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618071010.11214-1-yangtiezhu@loongson.cn> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 I don't understand what this patch does, but... On 06/18, Tiezhu Yang wrote: > > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -467,6 +467,7 @@ struct perf_event_attr { > __u32 wakeup_watermark; /* bytes before wakeup */ > }; > > + __u8 bp_priv; > __u32 bp_type; Is it safe to add the new member in the middle of uapi struct? This will break userspace... Oleg.