From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053ED19581B for ; Wed, 26 Jun 2024 20:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719434238; cv=none; b=DBx/aiKmEozY7fVkp2bV3BXUu/gVe/tCMz9BcCyQUTWGOiY25M3WAeZFZlKLZ+5RJjxNcfd8Jd9Tb7Gby/rnT5MDkgCkuFPqKR7IJY5sayd4kq8CevbiZn6OvY7k2LAkxCZs3Ov/TnLIp8C9qijkyNLDjLhv+AGMxcdcdj6ItIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719434238; c=relaxed/simple; bh=4w87sKvNwVN1XhdwrvqeSGrSkFFASpDkmJtJS5HZHW4=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=biYsGOwMMk8HEWkYpbwjQKRK7F6tqZjv3rA66S0VGMZ7cq5TMpr7/dAcCJ3JzpDlh3Ny0/npoqb2Oq4pBV872GS3DL3k8pSeoX8NAHI0sSxC42WLeEn4tgJypOr15N89ezD5OTjExjxxO41hy2nRcP2CEasdJZikjK+sIzuq3V4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Jp84zSvE; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Jp84zSvE" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc691f1f83aso574187276.1 for ; Wed, 26 Jun 2024 13:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719434236; x=1720039036; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=m0zVM37WL2jQNln7xrBKCslp+8pFTT04OTNtW91i/Qc=; b=Jp84zSvED2CJ4/tOzX6r8XMAqb8eMoBjdRCwRdsyvjZUWB57Zafuui0R30ulaBQbeZ 2NTYZQyanKraXN5ykDKiseZ3G6IPnsyuh208IJNPITyAWgdhXfbCHzRgI+k9SNaQs2bd rnWWyee5q3ZMrJby/Z9gaYOQLUKn/DxpVLgxJ0oHQJ3kXBIiAkZFdDJscZnVR2bxBQ1V 606YmSMfTfdNnxEdmSLvL7mxH8lUVxG47+oyP5sGw1qSDBUIFkuDniyONretOr8gi3kb 8x+XAQw+ZZ7FQZ4T+LgR3FdV8T+DklKpR7HRntSzVSJxnwbx1AC04wPJTkEr/stId6g5 iuOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719434236; x=1720039036; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m0zVM37WL2jQNln7xrBKCslp+8pFTT04OTNtW91i/Qc=; b=Zo5Gi0Kn4DEYTNjy8MxEueF5Ch29kUkMGX/v9i4KMIpFB1R9/+mIXn1kpRr6PnPkCE h7Adw4leu85N6yWLwgIN8A1EkaDHCPe/eUwgQKx7lbrHVcGjJz2WfGz4OXFCO+zmr8DI tyAageb3Mv3INoVWC5Iyay4io3Q56ZgZM9XUYApPStHc2fhcH1BmOG5wsDe6Yj8B7aC7 qNKMAARhcXxi9Tjo3io/catef6dBqfNNGcqwSnMBWvjJoOBYHGcXvBiHTW5gEictI/Ay 6OdVQnNY7NGnXZALdMrYpgfMQOnewnaf2ujvVX0u8Ivo+voRuY7KybPWO2xKrJrocsIZ v8oA== X-Forwarded-Encrypted: i=1; AJvYcCXTBmtBI4wu40rKf0UKO68f3lAOOHiMmpjjrFTHLVYH8LTC8t8Crdf/hkWymrZYQtwZ4PdSGtWNbpoWkz7RDusWzTxTG9upGgHwhcb5LmVOpw== X-Gm-Message-State: AOJu0YwH8WlS8X/49lmMPMUnsPhffSw5xDeUW6goDxOvVl2mYZEfVqDC 7WhWoz+4DHudThpEZb/seVJ52PZz8HHhfZkvyqWlch6WUvqLrVpCJKhZYqBUhast9YLxQINx9YI H9PuKrw== X-Google-Smtp-Source: AGHT+IEdvjzHXQRmiTPCVocpPSkdF6uIWaJjq0GRNCNUep0zQF7CpSWTKGCjbHc0CcZZYOIBveH+JUOt7qyE X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:23a1:25b9:2412:56de]) (user=irogers job=sendgmr) by 2002:a05:6902:727:b0:dfb:b1d:a16f with SMTP id 3f1490d57ef6-e03423f3a92mr38602276.3.1719434236037; Wed, 26 Jun 2024 13:37:16 -0700 (PDT) Date: Wed, 26 Jun 2024 13:36:18 -0700 In-Reply-To: <20240626203630.1194748-1-irogers@google.com> Message-Id: <20240626203630.1194748-17-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240626203630.1194748-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v2 16/27] perf stat: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index d460c46f15fd..a3d77a55d17f 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2271,15 +2271,6 @@ static const char * const stat_report_usage[] = { }; static struct perf_stat perf_stat = { - .tool = { - .attr = perf_event__process_attr, - .event_update = perf_event__process_event_update, - .thread_map = process_thread_map_event, - .cpu_map = process_cpu_map_event, - .stat_config = process_stat_config_event, - .stat = perf_event__process_stat_event, - .stat_round = process_stat_round_event, - }, .aggr_mode = AGGR_UNSET, .aggr_level = 0, }; @@ -2322,6 +2313,15 @@ static int __cmd_report(int argc, const char **argv) perf_stat.data.path = input_name; perf_stat.data.mode = PERF_DATA_MODE_READ; + perf_tool__init(&perf_stat.tool, /*ordered_events=*/false); + perf_stat.tool.attr = perf_event__process_attr; + perf_stat.tool.event_update = perf_event__process_event_update; + perf_stat.tool.thread_map = process_thread_map_event; + perf_stat.tool.cpu_map = process_cpu_map_event; + perf_stat.tool.stat_config = process_stat_config_event; + perf_stat.tool.stat = perf_event__process_stat_event; + perf_stat.tool.stat_round = process_stat_round_event; + session = perf_session__new(&perf_stat.data, &perf_stat.tool); if (IS_ERR(session)) return PTR_ERR(session); -- 2.45.2.741.gdbec12cfda-goog