From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Nick Terrell <terrelln@fb.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Song Liu <song@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Huacai Chen <chenhuacai@kernel.org>,
Yanteng Si <siyanteng@loongson.cn>,
Sun Haiyong <sunhaiyong@loongson.cn>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 24/27] perf test event_update: Ensure tools is initialized
Date: Wed, 26 Jun 2024 13:36:26 -0700 [thread overview]
Message-ID: <20240626203630.1194748-25-irogers@google.com> (raw)
In-Reply-To: <20240626203630.1194748-1-irogers@google.com>
Ensure tool is initialized to avoid lazy initialization pattern so
that more uses of struct perf_tool can be made const.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/event_update.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
index fdecad920f59..d6b4ce3ef4ee 100644
--- a/tools/perf/tests/event_update.c
+++ b/tools/perf/tests/event_update.c
@@ -103,6 +103,7 @@ static int test__event_update(struct test_suite *test __maybe_unused, int subtes
TEST_ASSERT_VAL("failed to synthesize attr update scale",
!perf_event__synthesize_event_update_scale(NULL, evsel, process_event_scale));
+ perf_tool__init(&tmp.tool, /*ordered_events=*/false);
tmp.name = evsel__name(evsel);
TEST_ASSERT_VAL("failed to synthesize attr update name",
--
2.45.2.741.gdbec12cfda-goog
next prev parent reply other threads:[~2024-06-26 20:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 20:36 [PATCH v2 00/27] Constify tool pointers Ian Rogers
2024-06-26 20:36 ` [PATCH v2 01/27] perf auxevent: Zero size dummy tool Ian Rogers
2024-06-28 17:44 ` Adrian Hunter
2024-06-28 18:34 ` Ian Rogers
2024-06-26 20:36 ` [PATCH v2 02/27] perf cs-etm: Fix address sanitizer dso build failure Ian Rogers
2024-06-26 20:36 ` [PATCH v2 03/27] perf tool: Constify tool pointers Ian Rogers
2024-06-26 20:36 ` [PATCH v2 04/27] perf tool: Move fill defaults into tool.c Ian Rogers
2024-06-26 20:36 ` [PATCH v2 05/27] perf tool: Add perf_tool__init Ian Rogers
2024-06-26 20:36 ` [PATCH v2 06/27] perf kmem: Use perf_tool__init Ian Rogers
2024-06-26 20:36 ` [PATCH v2 07/27] perf buildid-list: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 08/27] perf kvm: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 09/27] perf lock: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 10/27] perf evlist: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 11/27] perf record: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 12/27] perf c2c: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 13/27] perf script: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 14/27] perf inject: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 15/27] perf report: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 16/27] perf stat: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 17/27] perf annotate: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 18/27] perf sched: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 19/27] perf mem: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 20/27] perf timechart: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 21/27] perf diff: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 22/27] perf data convert json: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 23/27] perf data convert ctf: " Ian Rogers
2024-06-26 20:36 ` Ian Rogers [this message]
2024-06-26 20:36 ` [PATCH v2 25/27] perf kwork: " Ian Rogers
2024-06-26 20:36 ` [PATCH v2 26/27] perf tool: Remove perf_tool__fill_defaults Ian Rogers
2024-06-26 20:36 ` [PATCH v2 27/27] perf session: Constify tool Ian Rogers
2024-06-28 17:24 ` [PATCH v2 00/27] Constify tool pointers Namhyung Kim
2024-06-28 17:52 ` Ian Rogers
2024-06-28 22:07 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626203630.1194748-25-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=chenhuacai@kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=siyanteng@loongson.cn \
--cc=song@kernel.org \
--cc=sunhaiyong@loongson.cn \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).