From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: daniel.sneddon@linux.intel.com, tony.luck@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Brice Goglin <brice.goglin@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: [PATCH PATCH v2 1/9] x86/cpu/topology: Add CPU type to struct cpuinfo_topology
Date: Thu, 27 Jun 2024 13:44:06 -0700 [thread overview]
Message-ID: <20240627-add-cpu-type-v2-1-f927bde83ad0@linux.intel.com> (raw)
In-Reply-To: <20240627-add-cpu-type-v2-0-f927bde83ad0@linux.intel.com>
Sometimes it is required to identify the type of a core for taking specific
actions e.g. intel_pstate driver uses the core type to determine CPU
scaling. Also, some CPU vulnerabilities only affect a specific CPU type
e.g. RFDS only affects Intel Atom. For hybrid systems that have variants
P+E, P-only(Core) and E-only(Atom), it gets challenging to identify which
variant is vulnerable to a specific vulnerability, as these variants share
the same family, model and stepping.
Such processors do have CPUID fields that uniquely identify them. Like,
P+E, P-only and E-only enumerates CPUID.1A.CORE_TYPE, while P+E
additionally enumerates CPUID.7.HYBRID. Linux does not currently use this
field.
Add a new field hw_cpu_type to struct cpuinfo_topology which can be used to
match a CPU based on its type.
The hw_cpu_type is populated in the below debugfs file:
# cat /sys/kernel/debug/x86/topo/cpus/#
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
---
arch/x86/include/asm/processor.h | 3 +++
arch/x86/include/asm/topology.h | 9 +++++++++
arch/x86/kernel/cpu/debugfs.c | 1 +
arch/x86/kernel/cpu/topology_common.c | 9 +++++++++
4 files changed, 22 insertions(+)
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index cb4f6c513c48..d8d715fcc25c 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -105,6 +105,9 @@ struct cpuinfo_topology {
// Cache level topology IDs
u32 llc_id;
u32 l2c_id;
+
+ // Hardware defined CPU-type
+ u8 hw_cpu_type;
};
struct cpuinfo_x86 {
diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index abe3a8f22cbd..717fdb928dc3 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -33,6 +33,14 @@
#include <linux/numa.h>
#include <linux/cpumask.h>
+#define X86_CPU_TYPE_INTEL_SHIFT 24
+
+enum x86_hw_topo_cpu_type {
+ X86_HW_CPU_TYPE_UNKNOWN = 0,
+ X86_HW_CPU_TYPE_INTEL_ATOM = 0x20,
+ X86_HW_CPU_TYPE_INTEL_CORE = 0x40,
+};
+
#ifdef CONFIG_NUMA
#include <asm/mpspec.h>
@@ -139,6 +147,7 @@ extern const struct cpumask *cpu_clustergroup_mask(int cpu);
#define topology_logical_die_id(cpu) (cpu_data(cpu).topo.logical_die_id)
#define topology_die_id(cpu) (cpu_data(cpu).topo.die_id)
#define topology_core_id(cpu) (cpu_data(cpu).topo.core_id)
+#define topology_hw_cpu_type(cpu) (cpu_data(cpu).topo.hw_cpu_type)
#define topology_ppin(cpu) (cpu_data(cpu).ppin)
#define topology_amd_node_id(cpu) (cpu_data(cpu).topo.amd_node_id)
diff --git a/arch/x86/kernel/cpu/debugfs.c b/arch/x86/kernel/cpu/debugfs.c
index 3baf3e435834..8082e03a5976 100644
--- a/arch/x86/kernel/cpu/debugfs.c
+++ b/arch/x86/kernel/cpu/debugfs.c
@@ -22,6 +22,7 @@ static int cpu_debug_show(struct seq_file *m, void *p)
seq_printf(m, "die_id: %u\n", c->topo.die_id);
seq_printf(m, "cu_id: %u\n", c->topo.cu_id);
seq_printf(m, "core_id: %u\n", c->topo.core_id);
+ seq_printf(m, "hw_cpu_type: %x\n", c->topo.hw_cpu_type);
seq_printf(m, "logical_pkg_id: %u\n", c->topo.logical_pkg_id);
seq_printf(m, "logical_die_id: %u\n", c->topo.logical_die_id);
seq_printf(m, "llc_id: %u\n", c->topo.llc_id);
diff --git a/arch/x86/kernel/cpu/topology_common.c b/arch/x86/kernel/cpu/topology_common.c
index 9a6069e7133c..8b47bd6b0623 100644
--- a/arch/x86/kernel/cpu/topology_common.c
+++ b/arch/x86/kernel/cpu/topology_common.c
@@ -140,6 +140,14 @@ static void parse_topology(struct topo_scan *tscan, bool early)
}
}
+static void topo_set_hw_cpu_type(struct cpuinfo_x86 *c)
+{
+ c->topo.hw_cpu_type = X86_HW_CPU_TYPE_UNKNOWN;
+
+ if (c->x86_vendor == X86_VENDOR_INTEL && c->cpuid_level >= 0x1a)
+ c->topo.hw_cpu_type = cpuid_eax(0x1a) >> X86_CPU_TYPE_INTEL_SHIFT;
+}
+
static void topo_set_ids(struct topo_scan *tscan, bool early)
{
struct cpuinfo_x86 *c = tscan->c;
@@ -190,6 +198,7 @@ void cpu_parse_topology(struct cpuinfo_x86 *c)
}
topo_set_ids(&tscan, false);
+ topo_set_hw_cpu_type(c);
}
void __init cpu_init_topology(struct cpuinfo_x86 *c)
--
2.34.1
next prev parent reply other threads:[~2024-06-27 20:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 20:44 [PATCH v2 0/9] Add CPU-type to topology Pawan Gupta
2024-06-27 20:44 ` Pawan Gupta [this message]
2024-06-28 8:03 ` [PATCH PATCH v2 1/9] x86/cpu/topology: Add CPU type to struct cpuinfo_topology Borislav Petkov
2024-06-28 17:32 ` [PATCH " Pawan Gupta
2024-07-03 23:07 ` Borislav Petkov
2024-07-09 1:24 ` Pawan Gupta
2024-07-09 12:45 ` Borislav Petkov
2024-06-27 20:44 ` [PATCH PATCH v2 2/9] cpufreq: intel_pstate: Use topology_cpu_type() Pawan Gupta
2024-07-01 17:08 ` Rafael J. Wysocki
2024-07-01 17:14 ` Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 3/9] perf/x86/intel: Use topology_hw_cpu_type() Pawan Gupta
2024-06-28 8:59 ` Mi, Dapeng
2024-06-28 18:51 ` [PATCH " Pawan Gupta
2024-07-01 3:37 ` Mi, Dapeng
2024-07-01 17:32 ` Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 4/9] x86/cpu: Remove get_this_hybrid_cpu_type() Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 5/9] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 6/9] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 7/9] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 8/9] x86/bugs: Declutter vulnerable CPU list Pawan Gupta
2024-07-03 1:00 ` Josh Poimboeuf
2024-07-03 18:09 ` Pawan Gupta
2024-06-27 20:44 ` [PATCH PATCH v2 9/9] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
2024-07-03 1:04 ` Josh Poimboeuf
2024-07-03 18:26 ` Pawan Gupta
2024-07-03 22:04 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627-add-cpu-type-v2-1-f927bde83ad0@linux.intel.com \
--to=pawan.kumar.gupta@linux.intel.com \
--cc=Perry.Yuan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=brice.goglin@gmail.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).