From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338116F30D; Fri, 28 Jun 2024 20:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719605612; cv=none; b=Jz4DAGftxyauDCR5aHI7wJifZDJVbmrBWMHmYrCIdo4bEajDgk5DacJBpO+ZNFemVACsALtKjI19tzFuvsk0nGH80PFtYNJiUMQHAkdgow5FIm9i0jcLesrkAcXc2MZ4PtEIRkF5d863cU0lCKLGNOQ4/sFP6R0pS2XRJpbS2vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719605612; c=relaxed/simple; bh=AKSfB9Pv2OAjQLUIVLE4UZWRwL+hsgkfnDe14P1BTu0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HD/uxmKLtkI7Dui6VTHHQcVX2GwWnE6PlzzvK4TcwO1yLdKpSDrhIjGusqAMzPebVHl2n5HQaA1JtFVtZnMcGoUUEVqEypsziEjk0AsQOyx25L9Z4Slybdo5Muu591I7V9UxhpTDGTM+fWXKD9O2mhwiv8dmznhJczReBlYkrww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EoXTZyG3; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EoXTZyG3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719605610; x=1751141610; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AKSfB9Pv2OAjQLUIVLE4UZWRwL+hsgkfnDe14P1BTu0=; b=EoXTZyG3Eu7I9Wo4u+maSsn5XqyOgM9SnjPfmbRzEsgcZDAicfBDKyHo I/tzN7CGOSGZczTxT4jr++Vs7G3M0AM/w3MvyTeFVYoriDDgJqbbGkcOA C+vzQh8aFQiFzjkRNlpnPvYd3rRh7FsFzu3Rj/JqvF2SGzP1GH6LArsrm AXK/jha5BxJCF6VpECTpBGfXmO7u5VQhyxIXe9vPjbETCtJ8CFL9Pxhd7 331oa/Zg3ZlbyNjSQrgj/eWmhX+HfMwyv53oUFo/jppUWd5k/QGLTSvvw +fr3t1YiR6BthA9x0VRd3dsE+iMbDxGNwGIaspxU3ZmoOZ4yq+Zc/LDW4 A==; X-CSE-ConnectionGUID: ET59DwycTw2zxRHNYvqbcA== X-CSE-MsgGUID: Rr0kFWZRR8uAVgqusTcOxg== X-IronPort-AV: E=McAfee;i="6700,10204,11117"; a="12306963" X-IronPort-AV: E=Sophos;i="6.09,170,1716274800"; d="scan'208";a="12306963" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 13:13:29 -0700 X-CSE-ConnectionGUID: SqEWqzgTSxa/BEhpzquRSQ== X-CSE-MsgGUID: lOO9zeeRRxiJApF7JhkaLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,170,1716274800"; d="scan'208";a="49312547" Received: from jacob-builder.jf.intel.com ([10.54.39.125]) by fmviesa005.fm.intel.com with ESMTP; 28 Jun 2024 13:13:29 -0700 From: Jacob Pan To: X86 Kernel , Sean Christopherson , LKML , Thomas Gleixner , Dave Hansen , "H. Peter Anvin" , "Ingo Molnar" , "Borislav Petkov" , "Xin Li" , linux-perf-users@vger.kernel.org, Peter Zijlstra Cc: Paolo Bonzini , Tony Luck , Andy Lutomirski , acme@kernel.org, kan.liang@linux.intel.com, Andi Kleen , "Mehta, Sohil" , Jacob Pan Subject: [PATCH v3 00/11] Add support for NMI source reporting Date: Fri, 28 Jun 2024 13:18:28 -0700 Message-Id: <20240628201839.673086-1-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Thomas and all, Non-Maskable Interrupts (NMIs) are routed to the local Advanced Programmable Interrupt Controller (APIC) using vector #2. Before the advent of the Flexible Return and Event Delivery (FRED)[1], the vector information set by the NMI initiator was disregarded or lost within the hardware, compelling system software to poll every registered NMI handler to pinpoint the source of the NMI[2]. This approach led to several issues: 1. Inefficiency due to the CPU's time spent polling all handlers. 2. Increased latency from the additional time taken to poll all handlers. 3. The occurrence of unnecessary NMIs if they are triggered shortly after being processed by a different source. To tackle these challenges, Intel introduced NMI source reporting as a part of the FRED specification (detailed in Chapter 9). This CPU feature ensures that while all NMI sources are still aggregated into NMI vector (#2) for delivery, the source of the NMI is now conveyed through FRED event data (a 16-bit bitmap on the stack). This allows for the selective dispatch of the NMI source handler based on the bitmap, eliminating the need to invoke all NMI source handlers indiscriminately. In line with the hardware architecture, various interrupt sources can generate NMIs by encoding an NMI delivery mode. However, this patchset activates only the local NMI sources that are currently utilized by the Linux kernel, which includes: 1. Performance monitoring. 2. Inter-Processor Interrupts (IPIs) for functions like CPU backtrace, machine check, Kernel GNU Debugger (KGDB), reboot, panic stop, and self-test. Other NMI sources will continue to be handled as previously when the NMI source is not utilized or remains unidentified. Next steps: 1. KVM support 2. Optimization to reuse IDT NMI vector 2 as NMI source for "known" source. Link:https://lore.kernel.org/lkml/746fecd5-4c79-42f9-919e-912ec415e73f@zytor.com/ [1] https://www.intel.com/content/www/us/en/content-details/779982/flexible-return-and-event-delivery-fred-specification.html [2] https://lore.kernel.org/lkml/171011362209.2468526.15187874627966416701.tglx@xen13/ Thanks, Jacob --- V3: - Added KVM VMX patches to handle NMI exits (Sean) - Clean up in KVM for code reuse in PV IPI (patch 10 and 11) - Misc fixes based on reviews from HPA, Li Xin, and Sohil Change logs are in individual patches. Jacob Pan (9): x86/irq: Add enumeration of NMI source reporting CPU feature x86/irq: Define NMI source vectors x86/irq: Extend NMI handler registration interface to include source x86/irq: Factor out common NMI handling code x86/irq: Process nmi sources in NMI handler perf/x86: Enable NMI source reporting for perfmon x86/irq: Enable NMI source on IPIs delivered as NMI x86/irq: Move __prepare_ICR to x86 common header KVM: X86: Use common code for PV IPIs in linux guest Zeng Guang (2): KVM: VMX: Expand FRED kvm entry with event data KVM: VMX: Handle NMI Source report in VM exit arch/x86/entry/entry_64_fred.S | 2 +- arch/x86/events/amd/ibs.c | 2 +- arch/x86/events/core.c | 9 ++- arch/x86/events/intel/core.c | 6 +- arch/x86/include/asm/apic.h | 22 ++++++ arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/fred.h | 8 +- arch/x86/include/asm/irq_vectors.h | 38 ++++++++++ arch/x86/include/asm/nmi.h | 4 +- arch/x86/kernel/apic/hw_nmi.c | 5 +- arch/x86/kernel/apic/ipi.c | 4 +- arch/x86/kernel/apic/local.h | 16 ---- arch/x86/kernel/cpu/mce/inject.c | 4 +- arch/x86/kernel/cpu/mshyperv.c | 2 +- arch/x86/kernel/kgdb.c | 6 +- arch/x86/kernel/kvm.c | 10 +-- arch/x86/kernel/nmi.c | 117 ++++++++++++++++++++++++++--- arch/x86/kernel/nmi_selftest.c | 7 +- arch/x86/kernel/reboot.c | 4 +- arch/x86/kernel/smp.c | 4 +- arch/x86/kernel/traps.c | 4 +- arch/x86/kvm/vmx/vmx.c | 13 +++- arch/x86/platform/uv/uv_nmi.c | 4 +- drivers/acpi/apei/ghes.c | 2 +- drivers/char/ipmi/ipmi_watchdog.c | 2 +- drivers/edac/igen6_edac.c | 2 +- drivers/watchdog/hpwdt.c | 6 +- 27 files changed, 224 insertions(+), 80 deletions(-) -- 2.25.1