From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Nick Terrell <terrelln@fb.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Oliver Upton <oliver.upton@linux.dev>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Song Liu <song@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Huacai Chen <chenhuacai@kernel.org>,
Yanteng Si <siyanteng@loongson.cn>,
Sun Haiyong <sunhaiyong@loongson.cn>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 22/28] perf diff: Use perf_tool__init
Date: Fri, 28 Jun 2024 21:53:44 -0700 [thread overview]
Message-ID: <20240629045350.285243-23-irogers@google.com> (raw)
In-Reply-To: <20240629045350.285243-1-irogers@google.com>
Use perf_tool__init so that more uses of struct perf_tool can be const
and not relying on perf_tool__fill_defaults.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-diff.c | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 4c0567882a7a..28c5208fcdc9 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -467,21 +467,7 @@ static int diff__process_sample_event(const struct perf_tool *tool,
return ret;
}
-static struct perf_diff pdiff = {
- .tool = {
- .sample = diff__process_sample_event,
- .mmap = perf_event__process_mmap,
- .mmap2 = perf_event__process_mmap2,
- .comm = perf_event__process_comm,
- .exit = perf_event__process_exit,
- .fork = perf_event__process_fork,
- .lost = perf_event__process_lost,
- .namespaces = perf_event__process_namespaces,
- .cgroup = perf_event__process_cgroup,
- .ordered_events = true,
- .ordering_requires_timestamps = true,
- },
-};
+static struct perf_diff pdiff;
static struct evsel *evsel_match(struct evsel *evsel,
struct evlist *evlist)
@@ -1959,6 +1945,18 @@ int cmd_diff(int argc, const char **argv)
if (ret < 0)
return ret;
+ perf_tool__init(&pdiff.tool, /*ordered_events=*/true);
+ pdiff.tool.sample = diff__process_sample_event;
+ pdiff.tool.mmap = perf_event__process_mmap;
+ pdiff.tool.mmap2 = perf_event__process_mmap2;
+ pdiff.tool.comm = perf_event__process_comm;
+ pdiff.tool.exit = perf_event__process_exit;
+ pdiff.tool.fork = perf_event__process_fork;
+ pdiff.tool.lost = perf_event__process_lost;
+ pdiff.tool.namespaces = perf_event__process_namespaces;
+ pdiff.tool.cgroup = perf_event__process_cgroup;
+ pdiff.tool.ordering_requires_timestamps = true;
+
perf_config(diff__config, NULL);
argc = parse_options(argc, argv, options, diff_usage, 0);
--
2.45.2.803.g4e1b14247a-goog
next prev parent reply other threads:[~2024-06-29 4:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 4:53 [PATCH v3 00/28] Constify tool pointers Ian Rogers
2024-06-29 4:53 ` [PATCH v3 01/28] perf auxtrace: Remove dummy tools Ian Rogers
2024-07-11 6:43 ` Adrian Hunter
2024-07-11 6:46 ` Adrian Hunter
2024-07-11 16:08 ` Ian Rogers
2024-06-29 4:53 ` [PATCH v3 02/28] perf s390-cpumsf: Remove unused struct Ian Rogers
2024-06-29 4:53 ` [PATCH v3 03/28] perf cs-etm: Fix address sanitizer dso build failure Ian Rogers
2024-06-29 4:53 ` [PATCH v3 04/28] perf tool: Constify tool pointers Ian Rogers
2024-06-29 4:53 ` [PATCH v3 05/28] perf tool: Move fill defaults into tool.c Ian Rogers
2024-06-29 4:53 ` [PATCH v3 06/28] perf tool: Add perf_tool__init Ian Rogers
2024-06-29 4:53 ` [PATCH v3 07/28] perf kmem: Use perf_tool__init Ian Rogers
2024-06-29 4:53 ` [PATCH v3 08/28] perf buildid-list: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 09/28] perf kvm: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 10/28] perf lock: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 11/28] perf evlist: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 12/28] perf record: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 13/28] perf c2c: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 14/28] perf script: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 15/28] perf inject: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 16/28] perf report: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 17/28] perf stat: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 18/28] perf annotate: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 19/28] perf sched: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 20/28] perf mem: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 21/28] perf timechart: " Ian Rogers
2024-06-29 4:53 ` Ian Rogers [this message]
2024-06-29 4:53 ` [PATCH v3 23/28] perf data convert json: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 24/28] perf data convert ctf: " Ian Rogers
2024-06-29 4:53 ` [PATCH v3 25/28] perf test event_update: Ensure tools is initialized Ian Rogers
2024-06-29 4:53 ` [PATCH v3 26/28] perf kwork: Use perf_tool__init Ian Rogers
2024-06-29 4:53 ` [PATCH v3 27/28] perf tool: Remove perf_tool__fill_defaults Ian Rogers
2024-06-29 4:53 ` [PATCH v3 28/28] perf session: Constify tool Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240629045350.285243-23-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=siyanteng@loongson.cn \
--cc=song@kernel.org \
--cc=sunhaiyong@loongson.cn \
--cc=suzuki.poulose@arm.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).