From: Changbin Du <changbin.du@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Nathan Chancellor <nathan@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
Hui Wang <hw.huiwang@huawei.com>,
Changbin Du <changbin.du@huawei.com>
Subject: [PATCH v5 3/8] perf: disasm: use build_id_path if fallback failed
Date: Tue, 2 Jul 2024 12:18:32 +0800 [thread overview]
Message-ID: <20240702041837.5306-4-changbin.du@huawei.com> (raw)
In-Reply-To: <20240702041837.5306-1-changbin.du@huawei.com>
If we can not fallback for special dso (vmlinx and vdso), use the
build_id_path found previously.
Signed-off-by: Changbin Du <changbin.du@huawei.com>
---
tools/perf/util/disasm.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
index c4ab98c0eaa1..f4e94ff37e50 100644
--- a/tools/perf/util/disasm.c
+++ b/tools/perf/util/disasm.c
@@ -1176,15 +1176,21 @@ static int dso__disassemble_filename(struct dso *dso, char *filename, size_t fil
return fallback_filename(dso, filename, filename_size);
if (dso__is_kcore(dso) || dso__is_vdso(dso))
- return fallback_filename(dso, filename, filename_size);
+ goto fallback;
- if (read_buildid_linkname(filename, linkname, sizeof(linkname) - 1) ||
- strstr(linkname, DSO__NAME_KALLSYMS) || strstr(linkname, DSO__NAME_VDSO)) {
- return fallback_filename(dso, filename, filename_size);
+ if (!read_buildid_linkname(filename, linkname, sizeof(linkname) - 1) &&
+ (!strstr(linkname, DSO__NAME_KALLSYMS) && !strstr(linkname, DSO__NAME_VDSO))) {
+ /* It's not kallsysms or vdso, use build_id path found above */
+ goto out;
}
- if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND)
- dso__set_binary_type(dso, DSO_BINARY_TYPE__BUILD_ID_CACHE);
+fallback:
+ if (fallback_filename(dso, filename, filename_size)) {
+ /* if fallback failed, use build_id path found above */
+out:
+ if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND)
+ dso__set_binary_type(dso, DSO_BINARY_TYPE__BUILD_ID_CACHE);
+ }
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2024-07-02 4:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 4:18 [PATCH v5 0/8] perf: support specify vdso path in cmdline Changbin Du
2024-07-02 4:18 ` [PATCH v5 1/8] " Changbin Du
2024-07-18 17:02 ` Adrian Hunter
2024-07-22 12:19 ` duchangbin
2024-07-22 13:15 ` Adrian Hunter
2024-07-23 1:50 ` duchangbin
2024-07-02 4:18 ` [PATCH v5 2/8] perf: disasm: refactor function dso__disassemble_filename Changbin Du
2024-07-02 4:18 ` Changbin Du [this message]
2024-07-02 4:18 ` [PATCH v5 4/8] perf: build-id: name debugging vdso as "debug" Changbin Du
2024-07-18 17:03 ` Adrian Hunter
2024-07-22 12:08 ` duchangbin
2024-07-22 13:21 ` Adrian Hunter
2024-07-23 1:51 ` duchangbin
2024-07-02 4:18 ` [PATCH v5 5/8] perf: symbol: generalize vmlinux path searching Changbin Du
2024-07-02 4:18 ` [PATCH v5 6/8] perf: build-id: try to search debugging vdso and add to cache Changbin Du
2024-07-02 4:18 ` [PATCH v5 7/8] perf: disasm: prefer debugging files in build-id cache Changbin Du
2024-07-02 4:18 ` [PATCH v5 8/8] perf buildid-cache: recognize vdso when adding files Changbin Du
2024-07-03 23:18 ` Namhyung Kim
2024-07-04 1:43 ` duchangbin
2024-07-24 14:55 ` kernel test robot
2024-07-15 11:38 ` [PATCH v5 0/8] perf: support specify vdso path in cmdline duchangbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702041837.5306-4-changbin.du@huawei.com \
--to=changbin.du@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hw.huiwang@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).