* [PATCH] perf annotate: Convert comma to semicolon
@ 2024-07-16 7:34 Chen Ni
2024-07-16 13:33 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Chen Ni @ 2024-07-16 7:34 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang, nabijaczleweli, penberg
Cc: linux-perf-users, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Fixes: aca7a94d6a59 ("perf tools: Move UI bits to tools/perf/ui directory")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
tools/perf/ui/browsers/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index ea986430241e..fe991a81256b 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -985,7 +985,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel,
browser.b.width = notes->src->widths.max_line_len;
browser.b.nr_entries = notes->src->nr_entries;
- browser.b.entries = ¬es->src->source,
+ browser.b.entries = ¬es->src->source;
browser.b.width += 18; /* Percentage */
if (annotate_opts.hide_src_code)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf annotate: Convert comma to semicolon
2024-07-16 7:34 [PATCH] perf annotate: Convert comma to semicolon Chen Ni
@ 2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:12 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2024-07-16 13:33 UTC (permalink / raw)
To: Chen Ni
Cc: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, adrian.hunter, kan.liang, nabijaczleweli, penberg,
linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 12:35 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: aca7a94d6a59 ("perf tools: Move UI bits to tools/perf/ui directory")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/ui/browsers/annotate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index ea986430241e..fe991a81256b 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -985,7 +985,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel,
>
> browser.b.width = notes->src->widths.max_line_len;
> browser.b.nr_entries = notes->src->nr_entries;
> - browser.b.entries = ¬es->src->source,
> + browser.b.entries = ¬es->src->source;
> browser.b.width += 18; /* Percentage */
>
> if (annotate_opts.hide_src_code)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf annotate: Convert comma to semicolon
2024-07-16 13:33 ` Ian Rogers
@ 2024-07-26 14:12 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-07-26 14:12 UTC (permalink / raw)
To: Ian Rogers
Cc: Chen Ni, peterz, mingo, namhyung, mark.rutland,
alexander.shishkin, jolsa, adrian.hunter, kan.liang,
nabijaczleweli, penberg, linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 06:33:15AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:35 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: aca7a94d6a59 ("perf tools: Move UI bits to tools/perf/ui directory")
I'm removing this fixes tag to avoid churn on the stable trees, the
referred cset just moves things around, so its not where the harmless
comma was introduced.
Thanks, applied.
- Arnaldo
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
>
> Thanks,
> Ian
>
> > ---
> > tools/perf/ui/browsers/annotate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> > index ea986430241e..fe991a81256b 100644
> > --- a/tools/perf/ui/browsers/annotate.c
> > +++ b/tools/perf/ui/browsers/annotate.c
> > @@ -985,7 +985,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel,
> >
> > browser.b.width = notes->src->widths.max_line_len;
> > browser.b.nr_entries = notes->src->nr_entries;
> > - browser.b.entries = ¬es->src->source,
> > + browser.b.entries = ¬es->src->source;
> > browser.b.width += 18; /* Percentage */
> >
> > if (annotate_opts.hide_src_code)
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-26 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16 7:34 [PATCH] perf annotate: Convert comma to semicolon Chen Ni
2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:12 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).