* [PATCH] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest
@ 2024-05-06 8:48 Zhenyu Wang
2024-05-15 3:21 ` [PATCH RESEND] " Zhenyu Wang
0 siblings, 1 reply; 7+ messages in thread
From: Zhenyu Wang @ 2024-05-06 8:48 UTC (permalink / raw)
To: peterz
Cc: kan.liang, linux-kernel, linux-perf-users, Rui Zhang,
Artem Bityutskiy, Wendy Wang
Package C2 residency counter is also available on Sierra Forest.
So add it support in srf_cstates.
Cc: Rui Zhang <rui.zhang@intel.com>
Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
Cc: Wendy Wang <wendy.wang@intel.com>
Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support")
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
arch/x86/events/intel/cstate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
index 08bba679678c..cdf44500783e 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -64,7 +64,7 @@
* perf code: 0x00
* Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL,
* KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL,
- * RPL,SPR,MTL
+ * RPL,SPR,MTL,SRF
* Scope: Package (physical package)
* MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter.
* perf code: 0x01
@@ -689,7 +689,8 @@ static const struct cstate_model srf_cstates __initconst = {
.core_events = BIT(PERF_CSTATE_CORE_C1_RES) |
BIT(PERF_CSTATE_CORE_C6_RES),
- .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES),
+ .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) |
+ BIT(PERF_CSTATE_PKG_C6_RES),
.module_events = BIT(PERF_CSTATE_MODULE_C6_RES),
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-05-06 8:48 [PATCH] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest Zhenyu Wang @ 2024-05-15 3:21 ` Zhenyu Wang 2024-05-15 13:01 ` Wang, Wendy 2024-06-12 8:08 ` [PATCH RESEND AGAIN] " Zhenyu Wang 0 siblings, 2 replies; 7+ messages in thread From: Zhenyu Wang @ 2024-05-15 3:21 UTC (permalink / raw) To: peterz Cc: kan.liang, linux-kernel, linux-perf-users, x86, Rui Zhang, Artem Bityutskiy, Wendy Wang Package C2 residency counter is also available on Sierra Forest. So add it support in srf_cstates. Cc: Rui Zhang <rui.zhang@intel.com> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> Cc: Wendy Wang <wendy.wang@intel.com> Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> --- arch/x86/events/intel/cstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c index e64eaa8dda5a..4cd36848cfff 100644 --- a/arch/x86/events/intel/cstate.c +++ b/arch/x86/events/intel/cstate.c @@ -64,7 +64,7 @@ * perf code: 0x00 * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, - * RPL,SPR,MTL + * RPL,SPR,MTL,SRF * Scope: Package (physical package) * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. * perf code: 0x01 @@ -683,7 +683,8 @@ static const struct cstate_model srf_cstates __initconst = { .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | BIT(PERF_CSTATE_CORE_C6_RES), - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | + BIT(PERF_CSTATE_PKG_C6_RES), .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-05-15 3:21 ` [PATCH RESEND] " Zhenyu Wang @ 2024-05-15 13:01 ` Wang, Wendy 2024-06-12 8:08 ` [PATCH RESEND AGAIN] " Zhenyu Wang 1 sibling, 0 replies; 7+ messages in thread From: Wang, Wendy @ 2024-05-15 13:01 UTC (permalink / raw) To: Zhenyu Wang, peterz@infradead.org Cc: kan.liang@linux.intel.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, x86@kernel.org, Zhang, Rui, Bityutskiy, Artem, Wang, Wendy Verified on SRF-SP, the Perf PC2 counter is updated: [root@p-srf07 ~]# perf stat --per-socket -e cstate_pkg/c2-residency/ sleep 20 Performance counter stats for 'system wide': S0 1 9,589,297,024 cstate_pkg/c2-residency/ S1 1 10,204,349,952 cstate_pkg/c2-residency/ 20.003533150 seconds time elapsed [root@p-srf07 ~]# perf stat --per-socket -e cstate_pkg/c2-residency/ sleep 20 Performance counter stats for 'system wide': S0 1 9,309,806,784 cstate_pkg/c2-residency/ S1 1 10,897,684,928 cstate_pkg/c2-residency/ 20.004747926 seconds time elapsed Tested-by: Wendy Wang <wendy.wang@intel.com> -----Original Message----- From: Zhenyu Wang <zhenyuw@linux.intel.com> Sent: Wednesday, May 15, 2024 11:22 AM To: peterz@infradead.org Cc: kan.liang@linux.intel.com; linux-kernel@vger.kernel.org; linux-perf-users@vger.kernel.org; x86@kernel.org; Zhang, Rui <rui.zhang@intel.com>; Bityutskiy, Artem <artem.bityutskiy@intel.com>; Wang, Wendy <wendy.wang@intel.com> Subject: [PATCH RESEND] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest Package C2 residency counter is also available on Sierra Forest. So add it support in srf_cstates. Cc: Rui Zhang <rui.zhang@intel.com> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> Cc: Wendy Wang <wendy.wang@intel.com> Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> --- arch/x86/events/intel/cstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c index e64eaa8dda5a..4cd36848cfff 100644 --- a/arch/x86/events/intel/cstate.c +++ b/arch/x86/events/intel/cstate.c @@ -64,7 +64,7 @@ * perf code: 0x00 * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, - * RPL,SPR,MTL + * RPL,SPR,MTL,SRF * Scope: Package (physical package) * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. * perf code: 0x01 @@ -683,7 +683,8 @@ static const struct cstate_model srf_cstates __initconst = { .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | BIT(PERF_CSTATE_CORE_C6_RES), - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | + BIT(PERF_CSTATE_PKG_C6_RES), .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), }; -- 2.43.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND AGAIN] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-05-15 3:21 ` [PATCH RESEND] " Zhenyu Wang 2024-05-15 13:01 ` Wang, Wendy @ 2024-06-12 8:08 ` Zhenyu Wang 2024-07-17 3:16 ` [PATCH tip rebase] " Zhenyu Wang 1 sibling, 1 reply; 7+ messages in thread From: Zhenyu Wang @ 2024-06-12 8:08 UTC (permalink / raw) To: peterz Cc: kan.liang, linux-kernel, linux-perf-users, x86, Rui Zhang, Artem Bityutskiy, Wendy Wang Package C2 residency counter is also available on Sierra Forest. So add it support in srf_cstates. Cc: Rui Zhang <rui.zhang@intel.com> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> Cc: Wendy Wang <wendy.wang@intel.com> Tested-by: Wendy Wang <wendy.wang@intel.com> Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> --- arch/x86/events/intel/cstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c index 9d6e8f13d13a..b1a822af25d0 100644 --- a/arch/x86/events/intel/cstate.c +++ b/arch/x86/events/intel/cstate.c @@ -64,7 +64,7 @@ * perf code: 0x00 * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, - * RPL,SPR,MTL + * RPL,SPR,MTL,SRF * Scope: Package (physical package) * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. * perf code: 0x01 @@ -684,7 +684,8 @@ static const struct cstate_model srf_cstates __initconst = { .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | BIT(PERF_CSTATE_CORE_C6_RES), - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | + BIT(PERF_CSTATE_PKG_C6_RES), .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), }; -- 2.45.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH tip rebase] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-06-12 8:08 ` [PATCH RESEND AGAIN] " Zhenyu Wang @ 2024-07-17 3:16 ` Zhenyu Wang 2024-07-17 13:06 ` Liang, Kan 2024-07-17 16:29 ` Peter Zijlstra 0 siblings, 2 replies; 7+ messages in thread From: Zhenyu Wang @ 2024-07-17 3:16 UTC (permalink / raw) To: Peter Zijlstra Cc: kan.liang, linux-kernel, linux-perf-users, x86, Rui Zhang, Artem Bityutskiy, Wendy Wang Package C2 residency counter is also available on Sierra Forest. So add it support in srf_cstates. Cc: Rui Zhang <rui.zhang@intel.com> Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> Cc: Wendy Wang <wendy.wang@intel.com> Tested-by: Wendy Wang <wendy.wang@intel.com> Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> --- Hi, Peter This refresh resolved conflicts in comment against current tip tree. Please help to apply. Thanks! arch/x86/events/intel/cstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c index be58cfb012dd..9f116dfc4728 100644 --- a/arch/x86/events/intel/cstate.c +++ b/arch/x86/events/intel/cstate.c @@ -64,7 +64,7 @@ * perf code: 0x00 * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, - * RPL,SPR,MTL,ARL,LNL + * RPL,SPR,MTL,ARL,LNL,SRF * Scope: Package (physical package) * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. * perf code: 0x01 @@ -693,7 +693,8 @@ static const struct cstate_model srf_cstates __initconst = { .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | BIT(PERF_CSTATE_CORE_C6_RES), - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | + BIT(PERF_CSTATE_PKG_C6_RES), .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), }; -- 2.45.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH tip rebase] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-07-17 3:16 ` [PATCH tip rebase] " Zhenyu Wang @ 2024-07-17 13:06 ` Liang, Kan 2024-07-17 16:29 ` Peter Zijlstra 1 sibling, 0 replies; 7+ messages in thread From: Liang, Kan @ 2024-07-17 13:06 UTC (permalink / raw) To: Zhenyu Wang, Peter Zijlstra Cc: linux-kernel, linux-perf-users, x86, Rui Zhang, Artem Bityutskiy, Wendy Wang On 2024-07-16 11:16 p.m., Zhenyu Wang wrote: > Package C2 residency counter is also available on Sierra Forest. > So add it support in srf_cstates. > > Cc: Rui Zhang <rui.zhang@intel.com> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> > Cc: Wendy Wang <wendy.wang@intel.com> > Tested-by: Wendy Wang <wendy.wang@intel.com> > Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Thanks, Kan > --- > > Hi, Peter > > This refresh resolved conflicts in comment against current tip tree. > Please help to apply. > > Thanks! > > arch/x86/events/intel/cstate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c > index be58cfb012dd..9f116dfc4728 100644 > --- a/arch/x86/events/intel/cstate.c > +++ b/arch/x86/events/intel/cstate.c > @@ -64,7 +64,7 @@ > * perf code: 0x00 > * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, > * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, > - * RPL,SPR,MTL,ARL,LNL > + * RPL,SPR,MTL,ARL,LNL,SRF > * Scope: Package (physical package) > * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. > * perf code: 0x01 > @@ -693,7 +693,8 @@ static const struct cstate_model srf_cstates __initconst = { > .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | > BIT(PERF_CSTATE_CORE_C6_RES), > > - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), > + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | > + BIT(PERF_CSTATE_PKG_C6_RES), > > .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), > }; ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH tip rebase] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest 2024-07-17 3:16 ` [PATCH tip rebase] " Zhenyu Wang 2024-07-17 13:06 ` Liang, Kan @ 2024-07-17 16:29 ` Peter Zijlstra 1 sibling, 0 replies; 7+ messages in thread From: Peter Zijlstra @ 2024-07-17 16:29 UTC (permalink / raw) To: Zhenyu Wang Cc: kan.liang, linux-kernel, linux-perf-users, x86, Rui Zhang, Artem Bityutskiy, Wendy Wang On Wed, Jul 17, 2024 at 11:16:09AM +0800, Zhenyu Wang wrote: > Package C2 residency counter is also available on Sierra Forest. > So add it support in srf_cstates. > > Cc: Rui Zhang <rui.zhang@intel.com> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com> > Cc: Wendy Wang <wendy.wang@intel.com> > Tested-by: Wendy Wang <wendy.wang@intel.com> > Fixes: 3877d55a0db2 ("perf/x86/intel/cstate: Add Sierra Forest support") > Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> > --- > > Hi, Peter > > This refresh resolved conflicts in comment against current tip tree. > Please help to apply. Ok, I have it now. I'll try and stick it into perf/urgent once -rc1 rolls around. > > arch/x86/events/intel/cstate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c > index be58cfb012dd..9f116dfc4728 100644 > --- a/arch/x86/events/intel/cstate.c > +++ b/arch/x86/events/intel/cstate.c > @@ -64,7 +64,7 @@ > * perf code: 0x00 > * Available model: SNB,IVB,HSW,BDW,SKL,KNL,GLM,CNL, > * KBL,CML,ICL,ICX,TGL,TNT,RKL,ADL, > - * RPL,SPR,MTL,ARL,LNL > + * RPL,SPR,MTL,ARL,LNL,SRF > * Scope: Package (physical package) > * MSR_PKG_C3_RESIDENCY: Package C3 Residency Counter. > * perf code: 0x01 > @@ -693,7 +693,8 @@ static const struct cstate_model srf_cstates __initconst = { > .core_events = BIT(PERF_CSTATE_CORE_C1_RES) | > BIT(PERF_CSTATE_CORE_C6_RES), > > - .pkg_events = BIT(PERF_CSTATE_PKG_C6_RES), > + .pkg_events = BIT(PERF_CSTATE_PKG_C2_RES) | > + BIT(PERF_CSTATE_PKG_C6_RES), > > .module_events = BIT(PERF_CSTATE_MODULE_C6_RES), > }; > -- > 2.45.2 > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-17 16:29 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-06 8:48 [PATCH] perf/x86/intel/cstate: Add pkg C2 residency counter for Sierra Forest Zhenyu Wang 2024-05-15 3:21 ` [PATCH RESEND] " Zhenyu Wang 2024-05-15 13:01 ` Wang, Wendy 2024-06-12 8:08 ` [PATCH RESEND AGAIN] " Zhenyu Wang 2024-07-17 3:16 ` [PATCH tip rebase] " Zhenyu Wang 2024-07-17 13:06 ` Liang, Kan 2024-07-17 16:29 ` Peter Zijlstra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).