linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: coresight@lists.linaro.org, suzuki.poulose@arm.com,
	gankulkarni@os.amperecomputing.com, mike.leach@linaro.org,
	leo.yan@linux.dev, anshuman.khandual@arm.com
Cc: James Clark <james.clark@arm.com>,
	James Clark <james.clark@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-perf-users@vger.kernel.org
Subject: [PATCH v6 05/17] perf: cs-etm: Only save valid trace IDs into files
Date: Mon, 22 Jul 2024 11:11:47 +0100	[thread overview]
Message-ID: <20240722101202.26915-6-james.clark@linaro.org> (raw)
In-Reply-To: <20240722101202.26915-1-james.clark@linaro.org>

From: James Clark <james.clark@arm.com>

This isn't a bug because Perf always masks with
CORESIGHT_TRACE_ID_VAL_MASK before using these values, but to avoid it
looking like it could be, make an effort to not save bad values.

Signed-off-by: James Clark <james.clark@arm.com>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/arch/arm/util/cs-etm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
index b0118546cd4d..14b8afabce3a 100644
--- a/tools/perf/arch/arm/util/cs-etm.c
+++ b/tools/perf/arch/arm/util/cs-etm.c
@@ -643,7 +643,8 @@ static bool cs_etm_is_ete(struct perf_pmu *cs_etm_pmu, struct perf_cpu cpu)
 
 static __u64 cs_etm_get_legacy_trace_id(struct perf_cpu cpu)
 {
-	return CORESIGHT_LEGACY_CPU_TRACE_ID(cpu.cpu);
+	/* Wrap at 48 so that invalid trace IDs aren't saved into files. */
+	return CORESIGHT_LEGACY_CPU_TRACE_ID(cpu.cpu % 48);
 }
 
 static void cs_etm_save_etmv4_header(__u64 data[], struct auxtrace_record *itr, struct perf_cpu cpu)
-- 
2.34.1


  parent reply	other threads:[~2024-07-22 10:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 10:11 [PATCH v6 00/17] coresight: Use per-sink trace ID maps for Perf sessions James Clark
2024-07-22 10:11 ` [PATCH v6 01/17] perf: cs-etm: Create decoders after both AUX and HW_ID search passes James Clark
2024-07-22 10:11 ` [PATCH v6 02/17] perf: cs-etm: Allocate queues for all CPUs James Clark
2024-07-22 10:11 ` [PATCH v6 03/17] perf: cs-etm: Move traceid_list to each queue James Clark
2024-07-22 10:11 ` [PATCH v6 04/17] perf: cs-etm: Create decoders based on the trace ID mappings James Clark
2024-07-22 10:11 ` James Clark [this message]
2024-07-22 10:11 ` [PATCH v6 06/17] perf: cs-etm: Support version 0.1 of HW_ID packets James Clark
2024-07-22 10:11 ` [PATCH v6 07/17] perf: cs-etm: Print queue number in raw trace dump James Clark
2024-07-23 12:36   ` Mike Leach
2024-07-22 10:11 ` [PATCH v6 08/17] perf: cs-etm: Add runtime version check for OpenCSD James Clark
2024-07-22 10:11 ` [PATCH v6 09/17] coresight: Remove unused ETM Perf stubs James Clark
2024-07-22 10:11 ` [PATCH v6 10/17] coresight: Clarify comments around the PID of the sink owner James Clark
2024-07-22 10:11 ` [PATCH v6 11/17] coresight: Move struct coresight_trace_id_map to common header James Clark
2024-07-22 10:11 ` [PATCH v6 12/17] coresight: Expose map arguments in trace ID API James Clark
2024-07-22 10:11 ` [PATCH v6 13/17] coresight: Make CPU id map a property of a trace ID map James Clark
2024-07-22 10:11 ` [PATCH v6 14/17] coresight: Use per-sink trace ID maps for Perf sessions James Clark
2024-07-22 10:11 ` [PATCH v6 15/17] coresight: Remove pending trace ID release mechanism James Clark
2024-07-22 10:11 ` [PATCH v6 16/17] coresight: Emit sink ID in the HW_ID packets James Clark
2024-07-22 10:11 ` [PATCH v6 17/17] coresight: Make trace ID map spinlock local to the map James Clark
2024-07-26 14:18 ` [PATCH v6 00/17] coresight: Use per-sink trace ID maps for Perf sessions Arnaldo Carvalho de Melo
2024-07-26 14:26   ` Suzuki K Poulose
2024-07-26 14:32     ` Arnaldo Carvalho de Melo
2024-07-26 14:38       ` Suzuki K Poulose
2024-07-26 14:49         ` Arnaldo Carvalho de Melo
2024-08-22 14:35           ` Suzuki K Poulose
2024-08-29  9:05             ` James Clark
2024-08-29 15:31               ` Arnaldo Carvalho de Melo
2024-08-30  8:35                 ` James Clark
2024-08-30  8:37                 ` James Clark
2024-09-04 14:51                   ` Suzuki K Poulose
2024-08-22 14:05 ` (subset) " Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722101202.26915-6-james.clark@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=anshuman.khandual@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).