From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30E0189F31 for ; Mon, 29 Jul 2024 16:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722271580; cv=none; b=JC6SvcsjxSNdOa6EpodEUGaaB74oPJDB68vrGWRBuKuLgcuDEf/SySrPSsJyf3d/DDSMrFvf0csSZ+JvWzYviQ+M2BJ/KpKFCTj1oLc+TAVdxX7Bpz4mTLCJA81iJntARHRu/P4Q666c0NFh0qiSAubTHhoj+oWFv1A0baK4Fwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722271580; c=relaxed/simple; bh=DcCALxIHVCUK+9WrmJFTXpoeJxfw9pHG1sO9q8SD+00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YlwoY3HkJc5NbsXlu3jHF7r/NIKdEBGLgO0SdLsFKF1ms0jlN96l17RtJsEdnBdfIDFHne3+sMpcuDRnBIMmeMRYe9PmqDWitWjF1BCRnLya1XQEqgaa1Hu+BME0nCxPBntWA8Cn9DaODxoAfJd6Ugfq4wrImfGNPWV4OUAO8DU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=mJyZycx+; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="mJyZycx+" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1fd9e6189d5so23481155ad.3 for ; Mon, 29 Jul 2024 09:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1722271578; x=1722876378; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=esv+2bQw0aEMT9KM4UokUyH6FGgrDkyBUaVhFoJhC+U=; b=mJyZycx+hMEodAzZe9rbUdYqULnRVrcPJN0Y0oBMluGhX7EROrWyv/Rj7aqLnRorml tRmoyulT9QlLciumW9EVqeQYxBg3Um/woe6WrkyZ4iEUL54YvinHk0wN+WwCriZGELGI y2x4Xvi4Dee0ICkK6yDO6GB9/RTItdpsLn6jVhn410NJEhfkw7HpFLFqYckGaMBN7uLl 7ILn1M5v0bgPftZD3RkuEV4G9R5Hck6JLLnSDcq22USvZ5Gg4adW40pVXpTFi/3L/xuW XtNzQNrqHI1EU3YrocfJLmOkGjjvi0vOY09xEAkzjh/bIJf9lZL9w8U7EhHVBH0WpaG+ 8iBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722271578; x=1722876378; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=esv+2bQw0aEMT9KM4UokUyH6FGgrDkyBUaVhFoJhC+U=; b=H2zyRMnskqf09dIgMSPCRX/kMAwh0wx/GYMuK7mMGhJiyNWQa3/fs1qvnxaGITNSqB mG927KWx5uQOOyqed9jBMcF99jnzMbmhUM4Z6aeM72KpOpUwmY7sCJOlWlac8PDr7+OO aMwHSCRznGQAWwhcoNRzxZYWOU8wSh8hrQtBYJDx27wOcopHhTA+QeYEIe0Aqx202usL jYIN+UcCKbgx5DZ1QKYKyF4vI1MUAHYnIQgScXVtFu56nNasWjuydAggAhIvTNDUJT4n 8b46o/OtvzH3V+X5r96A5PJxHoGOET1jL9kELvoynW7hO6CBh8bp8i+A7k5UEb43jTKb pD2A== X-Gm-Message-State: AOJu0YwDoSN/YhymnAJMtBPqvUUjNA1HThyd/vAcjL15k0e70U44H/Yh w/Ih74Ifeg9ZZ91jhshapjt3VeAoHb1jy7hL+GDqZvea18cYHLvN4aI2yBTMyu4= X-Google-Smtp-Source: AGHT+IFSQceV8kL40vzasoKkWICuL+b5k2ukcYwrsTHg9WGugoQ3cfB1FuG9VUzxm2y6klGdQ4UbgQ== X-Received: by 2002:a17:902:ecd1:b0:1fd:a412:5ded with SMTP id d9443c01a7336-1ff0482c4b4mr61845635ad.26.1722271578209; Mon, 29 Jul 2024 09:46:18 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7d401c6sm85480545ad.117.2024.07.29.09.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 09:46:17 -0700 (PDT) From: Charlie Jenkins Date: Fri, 26 Jul 2024 22:29:37 -0700 Subject: [PATCH v2 7/8] libperf test: Add test_stat_overflow() Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240726-overflow_check_libperf-v2-7-7d154dcf6bea@rivosinc.com> References: <20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com> In-Reply-To: <20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Charlie Jenkins , Shunsuke Nakamura X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1722271564; l=6608; i=charlie@rivosinc.com; s=20231120; h=from:subject:message-id; bh=A//Q40WQ+t6MAB7Qrx+4soh8s9dOFzIWFwFxUkcU1xQ=; b=+cUdR4bb9FAKj9f/4IUP2R/tUuPZM+LqB0IMO5aNFMPM4mX7d13LQVKXc6rmVNnaFYgiGulWk PlzGGTIQ9umDJIit7xHV/tS7FtHPUUN0OsO1VqzI/T/ntOXJ8jerbFS X-Developer-Key: i=charlie@rivosinc.com; a=ed25519; pk=t4RSWpMV1q5lf/NWIeR9z58bcje60/dbtxxmoSfBEcs= From: Shunsuke Nakamura Added overflow test using refresh and period. Confirmation - That the overflow occurs the number of times specified by perf_evse__refresh() - That the period can be updated by perf_evsel__period() Committer testing: $ sudo make tests -C ./tools/lib/perf V=1 make: Entering directory '/home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/lib/perf' make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/build/Makefile.build dir=. obj=libperf make -C /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/lib/api/ O= libapi.a make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/build/Makefile.build dir=./fd obj=libapi make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/build/Makefile.build dir=./fs obj=libapi make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/build/Makefile.build dir=. obj=tests make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/build/Makefile.build dir=./tests obj=tests running static: - running tests/test-cpumap.c...OK - running tests/test-threadmap.c...OK - running tests/test-evlist.c... OK - running tests/test-evsel.c... period = 1000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 2000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 1000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 2000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 OK running dynamic: - running tests/test-cpumap.c...OK - running tests/test-threadmap.c...OK - running tests/test-evlist.c... OK - running tests/test-evsel.c... period = 1000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 2000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 1000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 period = 2000000 overflow limit = 3, overflow count = 3, POLL_IN = 2, POLL_HUP = 1, other signal event = 0 OK make: Leaving directory '/home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/lib/perf' Signed-off-by: Shunsuke Nakamura Signed-off-by: Charlie Jenkins --- tools/lib/perf/tests/test-evsel.c | 107 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) diff --git a/tools/lib/perf/tests/test-evsel.c b/tools/lib/perf/tests/test-evsel.c index 545ec3150546..b27dd65f2ec9 100644 --- a/tools/lib/perf/tests/test-evsel.c +++ b/tools/lib/perf/tests/test-evsel.c @@ -1,7 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 +#include #include #include #include +#include +#include +#include #include #include #include @@ -11,6 +15,15 @@ #include #include "tests.h" +#define WAIT_COUNT 10000000UL +static struct signal_counts { + int in; + int hup; + int others; + int overflow; +} sig_count; +static struct perf_evsel *s_evsel; + static int libperf_print(enum libperf_print_level level, const char *fmt, va_list ap) { @@ -349,6 +362,98 @@ static int test_stat_read_format(void) return 0; } +static void sig_handler(int signo, siginfo_t *info, void *uc) +{ + switch (info->si_code) { + case POLL_IN: + sig_count.in++; + break; + case POLL_HUP: + sig_count.hup++; + break; + default: + sig_count.others++; + } + + sig_count.overflow++; +} + +static int test_stat_overflow(int owner) +{ + static struct sigaction sig; + u64 period = 1000000; + int overflow_limit = 3; + + struct perf_thread_map *threads; + struct perf_event_attr attr = { + .type = PERF_TYPE_SOFTWARE, + .config = PERF_COUNT_SW_TASK_CLOCK, + .sample_type = PERF_SAMPLE_PERIOD, + .sample_period = period, + .disabled = 1, + }; + struct perf_event_attr *tmp_attr; + int err = 0, i; + + LIBPERF_OPTS(perf_evsel_open_opts, opts, + .open_flags = PERF_FLAG_FD_CLOEXEC, + .flags = (O_RDWR | O_NONBLOCK | O_ASYNC), + .signal = SIGRTMIN + 1, + .owner_type = owner, + .sig = &sig); + + /* setup signal handler */ + memset(&sig, 0, sizeof(struct sigaction)); + sig.sa_sigaction = (void *)sig_handler; + sig.sa_flags = SA_SIGINFO; + + threads = perf_thread_map__new_dummy(); + __T("failed to create threads", threads); + + perf_thread_map__set_pid(threads, 0, 0); + + s_evsel = perf_evsel__new(&attr); + __T("failed to create evsel", s_evsel); + + err = perf_evsel__open_opts(s_evsel, NULL, threads, &opts); + __T("failed to open evsel", err == 0); + + for (i = 0; i < 2; i++) { + volatile unsigned int wait_count = WAIT_COUNT; + + sig_count.in = 0; + sig_count.hup = 0; + sig_count.others = 0; + sig_count.overflow = 0; + + period = period << i; + err = perf_evsel__period(s_evsel, period); + __T("failed to period evsel", err == 0); + + tmp_attr = perf_evsel__attr(s_evsel); + __T_VERBOSE("\tperiod = %llu\n", tmp_attr->sample_period); + + err = perf_evsel__refresh(s_evsel, overflow_limit); + __T("failed to refresh evsel", err == 0); + + while (wait_count--) + ; + + __T_VERBOSE("\toverflow limit = %d, overflow count = %d, ", + overflow_limit, sig_count.overflow); + __T_VERBOSE("POLL_IN = %d, POLL_HUP = %d, other signal event = %d\n", + sig_count.in, sig_count.hup, sig_count.others); + + __T("failed to overflow count", overflow_limit == sig_count.overflow); + } + + perf_evsel__close(s_evsel); + perf_evsel__delete(s_evsel); + perf_thread_map__put(threads); + + return 0; +} + int test_evsel(int argc, char **argv) { __T_START; @@ -361,6 +466,8 @@ int test_evsel(int argc, char **argv) test_stat_user_read(PERF_COUNT_HW_INSTRUCTIONS); test_stat_user_read(PERF_COUNT_HW_CPU_CYCLES); test_stat_read_format(); + test_stat_overflow(F_OWNER_PID); + test_stat_overflow(F_OWNER_TID); __T_END; return tests_failed == 0 ? 0 : -1; -- 2.44.0