From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B60D014F98 for ; Tue, 13 Aug 2024 04:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723521984; cv=none; b=ovsWPvDYjKIjF3U77Iiq4XIvr50MCH8i7nVgE181+GNoio8H1XLGcXMZLb1+mZoXsHRJblynEZkvyHQBLfNCgfMUM9bL7hWpPhcNk618Tg38TT72pjbcYR1Iv2AoKpaI7vAoQmmPej30Cr66nUkPqsw9VBBKfzwYdGbra7RlTX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723521984; c=relaxed/simple; bh=r7VLecbvEUYJZiNB7TVZd9Y4ujlIzmSV6v7MT/SSs8g=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=jWHy/DcSlUqIfCwEX/XsWUgfbC27x99lWDyYJcLmEErNfMyVxw7Wfuw/zopnWNo6Xe5vIDycyw7dIRJ0ACKvujY32QZ77TYpqgvYmACHu2M+83SVFmonu4uW9Xd3ILrUQIQGGV/hbBxMEwcWhtJn/8+51kOh+ll9Sbpa9rONhYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SGMrBUvI; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SGMrBUvI" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-672bea19bedso121178327b3.3 for ; Mon, 12 Aug 2024 21:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723521982; x=1724126782; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=N5G8ycQLaD3nMVPTOXPScjjttSakw9EtQa3FEUmBo6I=; b=SGMrBUvIcUAef7dnNvuhb1B97BfqY3vyk689NTPyNSwE/5mFGR111rcUGM+YLhNxOR 4cTA06GOKR99P0B7xE1YautXPHDOuB0137bxf0HtvZLEHv0qD2fENIb3JqMmvO8tOJwa ueXGWqfAs24NGv/vRmWyRYE4LcQykIo0uIil9juc1Vtw/xSgZ4DcKL1PKJjYv8WbWFK8 k0HwuKLiNi+ObTJp1jHIogubJqtXdZHJ4XT5iTY8x09zARED2ipw8LpxBroyOQQtajcM y0IuHPzShHc31EJnapA59NAv5bFBJeLdvG4edU42TiDxYQ5uP3B6mqxAXCenKISCxthL IcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723521982; x=1724126782; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N5G8ycQLaD3nMVPTOXPScjjttSakw9EtQa3FEUmBo6I=; b=CaWJz71I0+XN3qTBb/7xoScsjY+hVKKbY5apDbnkJBKHe3tW4TycSeNnw5FOIS5S6m y084yXENDkfOP+Ezr5dKJ1HAtVzW4vC9YSgN61/Dw5t7atlj5eLpoZddUbm0bZbFryEa b0NXWDn3qmM7QgqTPXByAtPQvqX4wv/A1NXU5rQCz0/DhN+vOyjjb0QsYPQ+rvgvYK8i ko8dT6gePrkiMFwtD/H02WLpRBQYoziM1/6dajOYZAloDInQGBHVnEsyJUUc/SpfAom+ vEjX6bEBJKdM+6xB0dYmrFJT/jfMQuaKhXjNWFdgVVzMo6PRERaW1n5uznXp93jnp4p5 6gSQ== X-Forwarded-Encrypted: i=1; AJvYcCU4yx0L2IhUTFFLomcZzGF/SIoUTcayK/SszEIL6a9Vv0rVWqfQoUUiAFYVR1kPRdMsD4nQTx2JTQoRvE0sVxBq19WJmKkAU97G3EHsaadVgQ== X-Gm-Message-State: AOJu0YwusPB8KMDAZ+eWQjRKrk/tqDprHf7tWNtZY0GrwO0y1bh29pUI i3R+4gm5mTDn2PfS9j/R5vfa86KPj1m2eCxM+pA8Ewmr287tEZoq8PSfi+Z03dv8lEFVnhef7OX LUtBKgw== X-Google-Smtp-Source: AGHT+IHk5ugUWyyThW7pxKGjaf9kqmY9IFupwIrVuW8y8MBzmDy6CjYnNOFMda07TvzD1c+Cdw29uEdYt2JJ X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:ae34:31b6:7154:c399]) (user=irogers job=sendgmr) by 2002:a0d:e706:0:b0:699:fc36:65ad with SMTP id 00721157ae682-6a97238e489mr851317b3.3.1723521981709; Mon, 12 Aug 2024 21:06:21 -0700 (PDT) Date: Mon, 12 Aug 2024 21:06:12 -0700 Message-Id: <20240813040613.882075-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.46.0.76.ge559c4bf1a-goog Subject: [PATCH v1 1/2] perf disasm: Fix memory leak for locked operations From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Richter , Kajol Jain , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" lock__parse calls disasm_line__parse passing &ops->locked.ins.name. Ensure ops->locked.ins.name is freed in lock__delete. Found with lock/leak sanitizer. Signed-off-by: Ian Rogers --- tools/perf/util/disasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c index 22289003e16d..226d2181f694 100644 --- a/tools/perf/util/disasm.c +++ b/tools/perf/util/disasm.c @@ -566,6 +566,7 @@ static void lock__delete(struct ins_operands *ops) ins_ops__delete(ops->locked.ops); zfree(&ops->locked.ops); + zfree(&ops->locked.ins.name); zfree(&ops->target.raw); zfree(&ops->target.name); } -- 2.46.0.76.ge559c4bf1a-goog