From: James Clark <james.clark@linaro.org>
To: irogers@google.com, linux-perf-users@vger.kernel.org
Cc: James Clark <james.clark@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Yang Jihong <yangjihong@bytedance.com>,
Colin Ian King <colin.i.king@gmail.com>,
Andi Kleen <ak@linux.intel.com>, Ze Gao <zegao2021@gmail.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/7] Event parsing fixes
Date: Thu, 22 Aug 2024 14:24:44 +0100 [thread overview]
Message-ID: <20240822132506.1468090-1-james.clark@linaro.org> (raw)
I rebased this one and made some other fixes so that I could test it,
so I thought I'd repost it here in case it's helpful. I also added a
new test.
But for the testing it all looks ok.
There is one small difference where it now shows "stalled-cycles-..."
as <not supported> events, when before it just didn't show them at all when
they weren't supported:
$ perf stat -- true
Performance counter stats for 'true':
0.66 msec task-clock # 0.384 CPUs utilized
0 context-switches # 0.000 /sec
0 cpu-migrations # 0.000 /sec
52 page-faults # 78.999 K/sec
<not counted> cpu_atom/instructions/ (0.00%)
978,399 cpu_core/instructions/ # 1.02 insn per cycle
<not counted> cpu_atom/cycles/ (0.00%)
959,722 cpu_core/cycles/ # 1.458 GHz
<not supported> cpu_atom/stalled-cycles-frontend/
<not supported> cpu_core/stalled-cycles-frontend/
I don't think that's a big deal though and could probably be fixed up
later if we really want to.
Tested on Raptor Lake, Juno, N1, Ampere (with the DSU cycles PMU) and
I also faked an Apple M on Juno.
Changes since v3:
* Rebase onto perf-tools-next 6236ebe07
* Fix Intel TPEBS counting mode test
* Fix arm-spe build
* Add support for DT devices in stat test
* Add a new test for hybrid perf stat default arguments
Ian Rogers (5):
perf evsel: Add alternate_hw_config and use in evsel__match
perf stat: Uniquify event name improvements
perf stat: Remove evlist__add_default_attrs use strings
perf evsel x86: Make evsel__has_perf_metrics work for legacy events
perf evsel: Remove pmu_name
James Clark (2):
perf test: Make stat test work on DT devices
perf test: Add a test for default perf stat command
tools/perf/arch/arm64/util/arm-spe.c | 4 +-
tools/perf/arch/x86/util/evlist.c | 74 +----
tools/perf/arch/x86/util/evsel.c | 35 ++-
tools/perf/builtin-diff.c | 6 +-
tools/perf/builtin-stat.c | 291 +++++++-----------
tools/perf/tests/parse-events.c | 2 +-
tools/perf/tests/shell/stat.sh | 33 +-
.../perf/tests/shell/test_stat_intel_tpebs.sh | 11 +-
tools/perf/util/evlist.c | 46 +--
tools/perf/util/evlist.h | 12 -
tools/perf/util/evsel.c | 28 +-
tools/perf/util/evsel.h | 22 +-
tools/perf/util/metricgroup.c | 4 +-
tools/perf/util/parse-events.c | 58 ++--
tools/perf/util/parse-events.h | 8 +-
tools/perf/util/parse-events.y | 2 +-
tools/perf/util/pmu.c | 6 +-
tools/perf/util/pmu.h | 2 +-
tools/perf/util/stat-display.c | 101 ++++--
tools/perf/util/stat-shadow.c | 14 +-
tools/perf/util/stat.c | 2 +-
21 files changed, 348 insertions(+), 413 deletions(-)
--
2.34.1
next reply other threads:[~2024-08-22 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 13:24 James Clark [this message]
2024-08-22 13:24 ` [PATCH v4 1/7] perf evsel: Add alternate_hw_config and use in evsel__match James Clark
2024-08-22 13:24 ` [PATCH v4 2/7] perf stat: Uniquify event name improvements James Clark
2024-08-22 13:24 ` [PATCH v4 3/7] perf stat: Remove evlist__add_default_attrs use strings James Clark
2024-08-22 13:24 ` [PATCH v4 4/7] perf evsel x86: Make evsel__has_perf_metrics work for legacy events James Clark
2024-08-22 13:24 ` [PATCH v4 5/7] perf evsel: Remove pmu_name James Clark
2024-08-22 13:24 ` [PATCH v4 6/7] perf test: Make stat test work on DT devices James Clark
2024-08-22 13:24 ` [PATCH v4 7/7] perf test: Add a test for default perf stat command James Clark
2024-08-22 14:32 ` [PATCH v4 0/7] Event parsing fixes Liang, Kan
2024-08-22 15:10 ` Ian Rogers
2024-08-22 15:18 ` Liang, Kan
2024-08-27 9:13 ` James Clark
2024-08-28 5:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822132506.1468090-1-james.clark@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=colin.i.king@gmail.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=sunhaiyong@loongson.cn \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangjihong@bytedance.com \
--cc=yangyicong@hisilicon.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).