From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 849FC1B3F1D for ; Thu, 29 Aug 2024 15:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724943752; cv=none; b=YNRam1ihAu1IY0qPXCCPI/wgRwZ83stxtyeIYG0s+Xd5gazu8Cs9QhvUaqGQsqQDewEQ1LxkkM2pY37yz9YE+in2B8SnO/RtrkhUORDj+KRcQtvl+oI95IgUYInqXqAexA+m4QGo5SxHAMHakiYhzx/t0ekkRYiwVv/As2X5+Po= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724943752; c=relaxed/simple; bh=6JtjT923jGc/V3FlUSejai1b0EYlPO9Lq7KBqzesy7A=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=eyBwBclrN1lFEQEV8vmRmwDM+AyYSumFK3253d+h7CdL5x1vqrCrD+u4mRk2kgS31mlMXjASuovxd36wmFlkkkoA9+WfF+/y3ELnGb36qX3X3AfrJGCY+WrHG6C12BtXgCl1p/D80Nxbb1M6YczvY8GQju9kyNo0VA+qlT4KmHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WQsyUIEa; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WQsyUIEa" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc691f1f83aso309419276.1 for ; Thu, 29 Aug 2024 08:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724943749; x=1725548549; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Av0NGxXt1nyH9OnYaW8cLl1uNekiq9nEwkTz2fTJczM=; b=WQsyUIEadsJZNsHIriKVcJWmcDgeCjycIXmi7h2/XNl108Dm3DWiKJGEUSmHHpJOUh 4YUxF4eXRYkeqx86vQsX98XZ+v34Ace03Hgdhu4AXhiRAxZ5Uv595zePrnU208msWsDc UMRlc9Bp2k/L75OU5NlRwfp5c/vokH542CyF6BKqzDsF9YZorCMupg9Cv2QsP7tU1opF sV8Hi/jmloBzVFdGHw+PNw4bl3PrH1sUkaXFGSdmaQDx+CcaH+n+Ro9qE/4qG5RMDwuC ZUV/u8epjr2EyxBGMfxJ9ENZ0PCBmfYNKqDdkeihkFf6ugYwvXcTC0Y9sctSDktiMLCd hr+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724943749; x=1725548549; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Av0NGxXt1nyH9OnYaW8cLl1uNekiq9nEwkTz2fTJczM=; b=gKwKJ1Pfe6BY9jv6k6NjT0XqiNtOB7O0jk4bbx6dRB4zrlVio9J/osSj5f8TslGF1p ZhcM2RVbHtkKaMBy7M4jTRxLgtiLWEbn8CcDJdCn8xu6X5YnAE/wnbaeyTXRsRPCgzDq n6pQu07wjWj+cjmPK/aW5swNFhqHbauF+UzBlNSMe/cedSiD2ovCrRvgFMK4BN7dD63U O/mePOj0xf556MuyHN/4whdpPs94xsTz7weZtf+B8D32MXBiiHDEBAM24sHm8Ier6ZgH oimRW1LsXLMSOv3Mzl3fPnJNPV5OMv0wMbzs6Mpw4G7pusDUtR9iTvNMisJqdKsplACk 4Eqw== X-Forwarded-Encrypted: i=1; AJvYcCWD8r+WU0BacgAMpnlwL84v8Ie1jKfiVDPoQujRqA9M/ZNymEPPwyL8YdtBQrgXh2khykxpXKoeivnorffwhIWf@vger.kernel.org X-Gm-Message-State: AOJu0YxQ/61QglBT27xqlDKSjQQHxehtnww+Owtnq7dDkT5BjE7vea4a q+jh/6TmvxYxCL5LBPI99N75zvIRjNkLAj4buF12WbxV7+MWK0DeuKtSZBh6ykX4hzu4xfqTUlG 5x3R5CA== X-Google-Smtp-Source: AGHT+IFJieNy9A3Uv3j3AZR9Z45ANYmI2LGJZlQ+SwIrR3g7cbpr9Y1OJRykDxOd+oXunJ3IU0lxYLvJDeLt X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:e51a:f73b:d117:cb13]) (user=irogers job=sendgmr) by 2002:a25:6b0b:0:b0:e0b:acc7:b1fd with SMTP id 3f1490d57ef6-e1a5c6b65bbmr54154276.4.1724943749450; Thu, 29 Aug 2024 08:02:29 -0700 (PDT) Date: Thu, 29 Aug 2024 08:01:54 -0700 In-Reply-To: <20240829150154.37929-1-irogers@google.com> Message-Id: <20240829150154.37929-9-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240829150154.37929-1-irogers@google.com> X-Mailer: git-send-email 2.46.0.295.g3b9ea8a38a-goog Subject: [PATCH v1 8/8] perf test: Additional pipe tests with pipe output written to a file From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Nick Terrell , Yanteng Si , Yicong Yang , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Additional pipe tests where piped files are written to disk. This means that spotting a file name of "-" isn't a sufficient "is pipe?" test. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/pipe_test.sh | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/tools/perf/tests/shell/pipe_test.sh b/tools/perf/tests/shell/pipe_test.sh index ad10012fdc29..a3c94b4182c2 100755 --- a/tools/perf/tests/shell/pipe_test.sh +++ b/tools/perf/tests/shell/pipe_test.sh @@ -11,6 +11,7 @@ sym="noploop" skip_test_missing_symbol ${sym} data=$(mktemp /tmp/perf.data.XXXXXX) +data2=$(mktemp /tmp/perf.data2.XXXXXX) prog="perf test -w noploop" err=0 @@ -19,6 +20,8 @@ set -e cleanup() { rm -rf "${data}" rm -rf "${data}".old + rm -rf "${data2}" + rm -rf "${data2}".old trap - EXIT TERM INT } @@ -49,6 +52,14 @@ test_record_report() { return fi + perf record -g -e task-clock:u -o - ${prog} > ${data} + if ! perf report -i ${data} --task | grep -q ${task} + then + echo "Record+report pipe test [Failed - cannot find the test file in the perf report #3]" + err=1 + return + fi + echo "Record+report pipe test [Success]" } @@ -86,6 +97,21 @@ test_inject_bids() { return fi + perf record -e task-clock:u -o - ${prog} > ${data} + if ! perf inject ${inject_opt} -i ${data} | perf report -i - | grep -q ${sym}; then + echo "Inject ${inject_opt} build-ids test [Failed - cannot find noploop function in pipe #5]" + err=1 + return + fi + + perf record -e task-clock:u -o - ${prog} > ${data} + perf inject ${inject_opt} -i ${data} -o ${data2} + if ! perf report -i ${data2} | grep -q ${sym}; then + echo "Inject ${inject_opt} build-ids test [Failed - cannot find noploop function in pipe #6]" + err=1 + return + fi + echo "Inject ${inject_opt} build-ids test [Success]" } -- 2.46.0.295.g3b9ea8a38a-goog