From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C8F93D8E for ; Sat, 31 Aug 2024 07:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725087868; cv=none; b=dzuBtfiyfvGikqDNZBbkCQOFRCXfofR+6gTBl6VQl+F0uVPAOcJ15NtZ6DWcm3IAQ3zribWF7v2SYDnwadKZ8Vx0WuTlF3Dj8/5LGpWRwY5yboxMFXBquwN0yFW3WB15TO52iLd9NdStmNU/81DDmnB2C0Rys1mV0wQlE47E/bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725087868; c=relaxed/simple; bh=XVNfhs0bK32n2PUsqr3Dy1HmPIqiOmkZ0KlzLN1Y2bI=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=gP9IWzn903m2n+yrDCsszhKjwLXF/AEnjRMt5MHnVbP3CqwEk0R7VK8FJjFa/8gpWlb5ZSPGtKmy5634B+istJMNBZSksM0O6qIJMe6BOwhA62+lKqD5++Di5FeUguhvzoQGQYjk7H3OUyl4IsoDZfkig0e8aSXVrYwfJm+wNxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1Q2XQ2XX; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1Q2XQ2XX" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e0b8fa94718so4432339276.0 for ; Sat, 31 Aug 2024 00:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725087866; x=1725692666; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=Yix+TBZPkXSa49ue1ChfBQwhkMaD26rQNK5r6EhEs+8=; b=1Q2XQ2XXs4Wwe8kHtQTTeibT2lNIs6kK7/cAcmYTEf546xE3Og448m5RUdTkyzn49T LhSgwJS28adATwR4Nrgf62yzVJZWziNThD01jftL3aTkRrbm58QGaaAI+LjOztviC61y QiIfKzSMTzc52satrat2ktShRgEQwxcsyE5TAVVxdnshRRWRgkoCDjZD9pJq8hcPc9wH 0uP8mY78W+qU1i3jZAsTLHAGl5Th9RjmnsjWPCP/2uVgRB0MEwWEdAKJneypu/fR5PBh bYu/kQ9h7T0HOs5ZFU6vBDnobauIYQqdtoAJx8t1D0jMmnUKe8iVf02VosXscexYMPSX y/8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725087866; x=1725692666; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yix+TBZPkXSa49ue1ChfBQwhkMaD26rQNK5r6EhEs+8=; b=SRPkEKYrxD3eSBJhQ0vjKObyGzH9ochkuv+JI8upisWKI8RYx14WVc2/YJ4cpsa76r /izEAPB51FStWOntNgBCo2IXB6dP8QEYwHELU91+/mIjdgEwzNKQi1t581s7NApR9EeX Xsvllk2jOBfnl/SPiCA9nFT+v8WZvsMjysJQz1NAiwIWXbBr9M+P5vzI6loUfgwwRmgW yqupdtfzdKRW68Jbn6/h8KfcVOeW54Td14OiBzB6npywNBdZruJjejSPo19uHKVd0yup sHs1W92vFoCJVRZSCOkViY3ou7+PLLVOYdLhfZH3/St28BNN3T1qxc+rxrOunEl+RgKL D/ig== X-Forwarded-Encrypted: i=1; AJvYcCW341i+D8lf9SarYBwoYjA4Cgr4KKSTIuCc07G1BSd556817S8VCLBYQ2xsYW6ZeYsZRE7/P6z8y5v7wV3A0J5w@vger.kernel.org X-Gm-Message-State: AOJu0YyK5wAflTBCDIoeA33WveWSOV3NY83GecAFtjRGkYvPGSdd1nof 9ujSG8gUOTWL+b212wMxmFTHy/M0bjjHVYUI+q3NmBAoTZJ/BD2jOEATk662xVP924ndgX7ml8A BtXfPCA== X-Google-Smtp-Source: AGHT+IFSQlqCaooK8EKm3oSpG167pQvMkiIAlIb5MBJCP0D74T3jspayC9ArNyHScKXixrYOkTzvSYAFVc0S X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:4974:82ff:2f9:edb6]) (user=irogers job=sendgmr) by 2002:a05:6902:18d5:b0:e05:fb86:1909 with SMTP id 3f1490d57ef6-e1a7a1a339bmr674564276.6.1725087866165; Sat, 31 Aug 2024 00:04:26 -0700 (PDT) Date: Sat, 31 Aug 2024 00:04:09 -0700 Message-Id: <20240831070415.506194-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog Subject: [PATCH v1 0/6] Various 32-bit and test fixes From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Athira Rajeev , Dominique Martinet , Yang Jihong , Colin Ian King , Chaitanya S Prakash , "Masami Hiramatsu (Google)" , James Clark , John Garry , Junhao He , David Ahern , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Running `perf test` as an i386 executable yielded a number of failures, some of which are addressed here. The first 2 are straightforward use strtoull issues when parsing a 64-bit quantity in 32-bit land. The 3rd patch just avoids a fail when `perf probe` isn't compiled in (in my case as LIBELF wasn't present). The 4th and 5th cases fix the breakpoint length, on i386 so the sizeof(long) used matches the kernel's sizeof(long). On aarch64 the value is change to 4 instead of sizeof(long), ie 8, as future kernels may make 8 an invalid argument. The final change addresses i386 watchpoint support not supporting 8-byte values. Ian Rogers (6): perf pmus: Fix name comparisons on 32-bit systems perf time-utils: Fix 32-bit nsec parsing perf test: Skip uprobe test if probe command isn't present perf parse-events: Add default_breakpoint_len helper perf parse-events: Vary default_breakpoint_len on i386 and arm64 perf test: Make watchpoint data 32-bits on i386 tools/perf/tests/bp_account.c | 4 +++- tools/perf/tests/bp_signal.c | 3 ++- tools/perf/tests/bp_signal_overflow.c | 3 ++- tools/perf/tests/parse-events.c | 3 ++- .../shell/test_uprobe_from_different_cu.sh | 7 ++++++ tools/perf/tests/wp.c | 5 ++++ tools/perf/util/parse-events.c | 23 ++++++++++++++++++- tools/perf/util/parse-events.h | 2 ++ tools/perf/util/pmus.c | 6 ++--- tools/perf/util/time-utils.c | 4 ++-- 10 files changed, 50 insertions(+), 10 deletions(-) -- 2.46.0.469.g59c65b2a67-goog