From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700B219F431 for ; Tue, 3 Sep 2024 10:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358828; cv=none; b=rf/R+aIRaGAqr/64kF0WLDQTEAhMbZUZOkNOM07V9Qj7uTZcYuL53AwDfSjq8pucXLipbo2hQracqpPcvQ7S8WMDbKZCE2rricJzCZxz24WxmjD3v7Ebr9hv0QwC6Y1kdRgGRBzQbJ2M2nufF0FfeBdiVVPswDHcXujKn8/6Y9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358828; c=relaxed/simple; bh=BPeL2yxwaX+v/9HQukw21j++tqBN5rJHE71dumN/Dc8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=syH4DRymnpWMpgBTsLg6yQeMJO/rXs3EB4LKBJTrSChiMmvRmnUbOuD6ltItBlBc376zqmgBFr/HhvPMdFfa3p34XeHzi4115Qo/ZW0hPGFSPbQblH5Vaoa2JXm+mOQrsJFShA11TKj/3Glb6XJjTHnGUf0P7wRh51vDUSM7zBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hnxnQcQx; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hnxnQcQx" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42c2e50ec6aso16998985e9.0 for ; Tue, 03 Sep 2024 03:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725358825; x=1725963625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=O7MCvZ5Fhe/+eOHMrrRYarXfsg8B1NR75imdENvlnHc=; b=hnxnQcQxTsromoIW3Zt2fzalFtaiGBkQ4zfPnqvlWSv/6TLL8ocmrzWDoR3Gldz8IZ mjycAOxPeL5vN6HppL8a/pY7p1EOtdoCn0cxuzoR5G+tFt4N74oTIPG51f7GZE8Ok7BL 94gLFyuog058znDvrMTnRO3SSiVpQgxKPqefWrefaseOu4XkROm9uX3vhQvh6U+ZLqjw dj7n21Icn4j1s6wlOZxDyeI/iF5BQeeJNg6Fvb7PJI7xrqmEsg2KyHbJKewV72HaIs6Y VHVxGCb6OYf87RS4NXVSRiRDwNurtKrg8o9dr69lDfIDhCARuu+xDKFVxiIy//vFXEM6 hnHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725358825; x=1725963625; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O7MCvZ5Fhe/+eOHMrrRYarXfsg8B1NR75imdENvlnHc=; b=a3jvmx/htgi+BXboRDzKf/0rERuAujPTwoWfjQGkFmSUY8f4DGjhudP3uPmYs02wNv nFNeEB0QB7RyGEBmWRv02+M2xZXpv0bFn1nQ/woMxCe+UWUk1X2Isj1VJvPffpxiuiqZ 4s8WPG4hHZ5cWZhscilKPAVvv9Xj7XriWbESpN3jsRq4XEzfSWqzq3jU9Gjqc+i5jDVV N8cZ7w8zq6TQFKBRjHykzdz+XkDZD3wUWxZ50bMwc/FrN3ITCReVT7av1a7hW1UvzzP4 K/5qrC/c3/3/Co4CjsV26xyH5PxSZKpVD4reMRvl2qb4g/BvQCF3ahu7TAMRCWuTtFnJ Q8cQ== X-Forwarded-Encrypted: i=1; AJvYcCUeEitn+Wnt/vCNcUeetOYQalDS1SYi/wc3KJCwbUnprStatPFZIZLsQrTlByvqYy2fYjvcIXp8D0YvsoEt6vjz@vger.kernel.org X-Gm-Message-State: AOJu0Yxc6/PQZBPYk2ji1k4e9f10/TOaTblB9m8yo0Dry09KZr1OaZMn tYAYlqpoWvv+JLQTlOw3gX3B5g6roxERojs/w4/2eGZmqYgloSHtrcXgd/TTSiU= X-Google-Smtp-Source: AGHT+IGIRhFxfgT+AnDIMCr5Idq+CDt+OTG+ytIxS7mv+w/WEHRzrznSX+8/1l2ZXSAi8FDJzWB3iQ== X-Received: by 2002:a05:600c:1914:b0:424:8743:86b4 with SMTP id 5b1f17b1804b1-42bb4c4cbefmr100018935e9.6.1725358824235; Tue, 03 Sep 2024 03:20:24 -0700 (PDT) Received: from localhost.localdomain ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e274ccsm168739995e9.37.2024.09.03.03.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 03:20:23 -0700 (PDT) From: James Clark To: irogers@google.com, linux-perf-users@vger.kernel.org, kan.liang@linux.intel.com, ak@linux.intel.com, namhyung@kernel.org Cc: James Clark , John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Weilin Wang , Athira Rajeev , Dominique Martinet , Yang Jihong , Colin Ian King , Howard Chu , Ze Gao , Jing Zhang , Sun Haiyong , Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 0/7] Event parsing fixes Date: Tue, 3 Sep 2024 11:19:44 +0100 Message-Id: <20240903102005.78049-1-james.clark@linaro.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I rebased this one and made some other fixes so that I could test it, so I thought I'd repost it here in case it's helpful. I also added a new test. But for the testing it all looks ok. There is one small difference where it now hides _all_ default events, when previously it would only hide some selected subset of events like "stalled-cycles-frontend". I think this is now more consistent across platforms because, for example, Apple M only has cycles and instructions, and the rest of the default events would always show as there. Tested on Raptor Lake, Kaby Lake, Juno, N1, Ampere (with the DSU cycles PMU) and I also faked an Apple M on Juno. Changes since v5: * Test on x86 non hybrid * Assume 1 PMU in the test when no PMUs expose /cpus file Changes since v4: * Hide all default events when not verbose * Remove previous note about behavior from the cover letter and replace it with a new note about the new behavior Changes since v3: * Rebase onto perf-tools-next 6236ebe07 * Fix Intel TPEBS counting mode test * Fix arm-spe build * Add support for DT devices in stat test * Add a new test for hybrid perf stat default arguments Ian Rogers (5): perf evsel: Add alternate_hw_config and use in evsel__match perf stat: Uniquify event name improvements perf stat: Remove evlist__add_default_attrs use strings perf evsel x86: Make evsel__has_perf_metrics work for legacy events perf evsel: Remove pmu_name James Clark (2): perf test: Make stat test work on DT devices perf test: Add a test for default perf stat command tools/perf/arch/arm64/util/arm-spe.c | 4 +- tools/perf/arch/x86/util/evlist.c | 74 +---- tools/perf/arch/x86/util/evsel.c | 35 ++- tools/perf/builtin-diff.c | 6 +- tools/perf/builtin-stat.c | 291 +++++++----------- tools/perf/tests/parse-events.c | 2 +- tools/perf/tests/shell/stat.sh | 37 ++- .../perf/tests/shell/test_stat_intel_tpebs.sh | 11 +- tools/perf/util/evlist.c | 46 +-- tools/perf/util/evlist.h | 12 - tools/perf/util/evsel.c | 28 +- tools/perf/util/evsel.h | 22 +- tools/perf/util/metricgroup.c | 4 +- tools/perf/util/parse-events.c | 58 ++-- tools/perf/util/parse-events.h | 8 +- tools/perf/util/parse-events.y | 2 +- tools/perf/util/pmu.c | 6 +- tools/perf/util/pmu.h | 2 +- tools/perf/util/stat-display.c | 109 +++++-- tools/perf/util/stat-shadow.c | 14 +- tools/perf/util/stat.c | 2 +- 21 files changed, 360 insertions(+), 413 deletions(-) -- 2.34.1