From: Andi Kleen <ak@linux.intel.com>
To: linux-perf-users@vger.kernel.org
Cc: adrian.hunter@intel.com, namhyung@kernel.org, acme@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH v1 04/10] perf: Add perf_brstack_srcline to resolve brstack entries
Date: Thu, 5 Sep 2024 08:07:58 -0700 [thread overview]
Message-ID: <20240905151058.2127122-5-ak@linux.intel.com> (raw)
In-Reply-To: <20240905151058.2127122-1-ak@linux.intel.com>
Add a new perf_brstack_srcline python function that resolves a full
brstack to filename/line/line/discriminator for each entry.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
.../scripts/python/Perf-Trace-Util/Context.c | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/tools/perf/scripts/python/Perf-Trace-Util/Context.c b/tools/perf/scripts/python/Perf-Trace-Util/Context.c
index 3aa5e6385c1e..a95a27895a15 100644
--- a/tools/perf/scripts/python/Perf-Trace-Util/Context.c
+++ b/tools/perf/scripts/python/Perf-Trace-Util/Context.c
@@ -22,6 +22,7 @@
#include "../../../util/session.h"
#include "../../../util/srcline.h"
#include "../../../util/srccode.h"
+#include "../../../util/dso.h"
#if PY_MAJOR_VERSION < 3
#define _PyCapsule_GetPointer(arg1, arg2) \
@@ -182,6 +183,61 @@ static PyObject *perf_sample_srccode(PyObject *obj, PyObject *args)
return perf_sample_src(obj, args, true);
}
+static PyObject *do_perf_brstack_srcline(struct scripting_context *c, PyObject *ipp)
+{
+ struct addr_location al;
+ struct dso *dso;
+ u8 cpumode;
+ char *srcfile = NULL;
+ PyObject *result = NULL;
+ bool kernel;
+ u64 ip = PyLong_AsUnsignedLongLong(ipp);
+ unsigned line = 0, disc = 0;
+
+ kernel = machine__kernel_ip(c->machine, ip);
+ if (kernel)
+ cpumode = PERF_RECORD_MISC_KERNEL;
+ else
+ cpumode = PERF_RECORD_MISC_USER;
+
+ addr_location__init(&al);
+ if (machine__resolve(c->machine, &al, c->sample) < 0)
+ goto err2;
+ if (!thread__find_map(al.thread, cpumode, ip, &al))
+ goto err;
+ if (!al.map)
+ goto err;
+ dso = map__dso(al.map);
+ if (!dso)
+ goto err;
+ if (dso__data(dso)->status == DSO_DATA_STATUS_ERROR)
+ goto err;
+ srcfile = get_srcline_split(dso, map__rip_2objdump(al.map, al.addr), &line, &disc);
+ if (srcfile)
+ result = Py_BuildValue("(sII)", srcfile, line, disc);
+ free(srcfile);
+err:
+ addr_location__exit(&al);
+err2:
+ if (!result)
+ return Py_BuildValue("");
+ return result;
+}
+
+/* Resolve srcfile/line/disc for brstack from/to. */
+
+static PyObject *perf_brstack_srcline(PyObject *obj, PyObject *args)
+{
+ PyObject *brstack = NULL;
+ PyObject *from, *to;
+ struct scripting_context *c = get_args(args, "brstack", &brstack);
+ if (!c)
+ return NULL;
+ from = do_perf_brstack_srcline(c, PyDict_GetItemString(brstack, "from"));
+ to = do_perf_brstack_srcline(c, PyDict_GetItemString(brstack, "to"));
+ return Py_BuildValue("(OO)", from, to);
+}
+
static PyMethodDef ContextMethods[] = {
#ifdef HAVE_LIBTRACEEVENT
{ "common_pc", perf_trace_context_common_pc, METH_VARARGS,
@@ -199,6 +255,8 @@ static PyMethodDef ContextMethods[] = {
METH_VARARGS, "Get source file name and line number."},
{ "perf_sample_srccode", perf_sample_srccode,
METH_VARARGS, "Get source file name, line number and line."},
+ { "perf_brstack_srcline", perf_brstack_srcline,
+ METH_VARARGS, "Get source file name, line number, discriminator for from/to of a brstack entry." },
{ NULL, NULL, 0, NULL}
};
--
2.45.2
next prev parent reply other threads:[~2024-09-05 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 15:07 [RESEND] More dwarf support in python interface Andi Kleen
2024-09-05 15:07 ` [PATCH v1 01/10] perf: Avoid buffer overflow in python register interface Andi Kleen
2024-09-05 15:07 ` [PATCH v1 02/10] perf: Support discriminator in addr2line Andi Kleen
2024-09-05 15:07 ` [PATCH v1 03/10] perf: Plumb passing machine to scripts Andi Kleen
2024-09-05 15:07 ` Andi Kleen [this message]
2024-09-05 15:07 ` [PATCH v1 05/10] perf: Add perf_resolve_ip python interface Andi Kleen
2024-09-05 15:08 ` [PATCH v1 06/10] perf: Add plumbling for line/disc for inlines Andi Kleen
2024-09-05 15:08 ` [PATCH v1 07/10] perf: Support returning inlines in get_srcline_split Andi Kleen
2024-09-05 15:08 ` [PATCH v1 08/10] perf: resolve inlines for perf_brstack_srcline/perf_ip_srcline Andi Kleen
2024-09-05 15:08 ` [PATCH v1 09/10] perf: Add build id and filename to perf_brstack/ip_srcline Andi Kleen
2024-09-05 15:08 ` [PATCH v1 10/10] perf: Update documentation for new python callbacks Andi Kleen
2024-09-05 15:25 ` [RESEND] More dwarf support in python interface Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905151058.2127122-5-ak@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).