linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf tools: Fix a typo
@ 2024-09-07 13:10 Andrew Kreimer
  2024-09-09  0:30 ` Ian Rogers
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Kreimer @ 2024-09-07 13:10 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
	Ian Rogers, Adrian Hunter, Liang Kan
  Cc: Matthew Wilcox, linux-perf-users, linux-kernel, kernel-janitors,
	Andrew Kreimer

Fix a typo in comments.

Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 tools/perf/builtin-help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index b2a368ae295a..0854d3cd9f6a 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -417,7 +417,7 @@ static void open_html(const char *path)
 static int show_html_page(const char *perf_cmd)
 {
 	const char *page = cmd_to_page(perf_cmd);
-	char *page_path; /* it leaks but we exec bellow */
+	char *page_path; /* it leaks but we exec below */
 
 	if (get_html_page_path(&page_path, page) < 0)
 		return -1;
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Fix a typo
  2024-09-07 13:10 [PATCH] perf tools: Fix a typo Andrew Kreimer
@ 2024-09-09  0:30 ` Ian Rogers
  2024-09-11 14:24   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2024-09-09  0:30 UTC (permalink / raw)
  To: Andrew Kreimer
  Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
	Adrian Hunter, Liang Kan, Matthew Wilcox, linux-perf-users,
	linux-kernel, kernel-janitors

On Sat, Sep 7, 2024 at 6:10 AM Andrew Kreimer <algonell@gmail.com> wrote:
>
> Fix a typo in comments.
>
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-help.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index b2a368ae295a..0854d3cd9f6a 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -417,7 +417,7 @@ static void open_html(const char *path)
>  static int show_html_page(const char *perf_cmd)
>  {
>         const char *page = cmd_to_page(perf_cmd);
> -       char *page_path; /* it leaks but we exec bellow */
> +       char *page_path; /* it leaks but we exec below */
>
>         if (get_html_page_path(&page_path, page) < 0)
>                 return -1;
> --
> 2.46.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Fix a typo
  2024-09-09  0:30 ` Ian Rogers
@ 2024-09-11 14:24   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-09-11 14:24 UTC (permalink / raw)
  To: Ian Rogers
  Cc: Andrew Kreimer, Peter Zijlstra, Ingo Molnar, Namhyung Kim,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
	Liang Kan, Matthew Wilcox, linux-perf-users, linux-kernel,
	kernel-janitors

On Sun, Sep 08, 2024 at 05:30:36PM -0700, Ian Rogers wrote:
> On Sat, Sep 7, 2024 at 6:10 AM Andrew Kreimer <algonell@gmail.com> wrote:
> >
> > Fix a typo in comments.
> >
> > Reported-by: Matthew Wilcox <willy@infradead.org>
> > Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next,

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-11 14:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-07 13:10 [PATCH] perf tools: Fix a typo Andrew Kreimer
2024-09-09  0:30 ` Ian Rogers
2024-09-11 14:24   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).