[PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[Andrii Nakryiko]

Build ID fetching code originated from ([0]), and is still both owned
and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

  [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f328373463b0..a86834bb4c25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4098,6 +4098,7 @@ F:	include/uapi/linux/btf*
 F:	include/uapi/linux/filter.h
 F:	kernel/bpf/
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 F:	lib/test_bpf.c
 F:	net/bpf/
 F:	net/core/filter.c
@@ -4218,6 +4219,7 @@ L:	bpf@vger.kernel.org
 S:	Maintained
 F:	kernel/bpf/stackmap.c
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 
 BROADCOM ASP 2.0 ETHERNET DRIVER
 M:	Justin Chen <justin.chen@broadcom.com>
-- 
2.43.5

Re: [PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[Alexei Starovoitov]

On Mon, Sep 9, 2024 at 12:04 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.

Song,

since you've added this logic back in
commit 615755a77b24 ("bpf: extend stackmap to save
binary_build_id+offset instead of address")

Pls provide your Ack.

> Fix the original omission in [0] to record this fact in MAINTAINERS.
>
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Jiri,

since you moved it in that commit pls Ack as well.

This change to the MAINTAINERS file should have been done back then.

So it's obvious who understands and maintains this code.

Currently get_maintainer.pl script is not helpful:

$ ./scripts/get_maintainer.pl lib/buildid.c
Andrew Morton <akpm@linux-foundation.org> (supporter:LIBRARY CODE)
linux-kernel@vger.kernel.org (open list:LIBRARY CODE)

Re: [PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[Song Liu]

On Mon, Sep 9, 2024 at 12:04 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
>
> Fix the original omission in [0] to record this fact in MAINTAINERS.
>
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Acked-by: Song Liu <song@kernel.org>

Thanks for making buildid parsing more reliable!

Song

Re: [PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[Jiri Olsa]

On Mon, Sep 09, 2024 at 12:04:26PM -0700, Andrii Nakryiko wrote:
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
> 
> Fix the original omission in [0] to record this fact in MAINTAINERS.
> 
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
> 
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f328373463b0..a86834bb4c25 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4098,6 +4098,7 @@ F:	include/uapi/linux/btf*
>  F:	include/uapi/linux/filter.h
>  F:	kernel/bpf/
>  F:	kernel/trace/bpf_trace.c
> +F:	lib/buildid.c
>  F:	lib/test_bpf.c
>  F:	net/bpf/
>  F:	net/core/filter.c
> @@ -4218,6 +4219,7 @@ L:	bpf@vger.kernel.org
>  S:	Maintained
>  F:	kernel/bpf/stackmap.c
>  F:	kernel/trace/bpf_trace.c
> +F:	lib/buildid.c
>  
>  BROADCOM ASP 2.0 ETHERNET DRIVER
>  M:	Justin Chen <justin.chen@broadcom.com>
> -- 
> 2.43.5
> 

Re: [PATCH bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Mon,  9 Sep 2024 12:04:26 -0700 you wrote:
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
> 
> Fix the original omission in [0] to record this fact in MAINTAINERS.
> 
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
> 
> [...]

Here is the summary with links:
  - [bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem
    https://git.kernel.org/bpf/bpf-next/c/58ff04e2e223

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html